Re: [jfx21u] RFR: 8317370: JavaFX runtime version is wrong at runtime

On Wed, 22 Nov 2023 16:14:12 GMT, John Neffenger wrote: > The only thing that didn't get copied over with the original commit is the > updated copyright statement in the VersionInfo.java class: That's because the copyright year was updated separately and later as part of [JDK-8318714](https://

Re: [jfx21u] RFR: 8317370: JavaFX runtime version is wrong at runtime

On Tue, 21 Nov 2023 20:19:04 GMT, John Neffenger wrote: > Backport 16169240667876633895b27464eb90033abb6166 > > Please review this backport of openjdk/jfx#1253 to JavaFX 21. Please give me > a day or two to test it again before starting your review. The backport looks good and works as expecte

Re: [jfx21u] RFR: 8317370: JavaFX runtime version is wrong at runtime

On Tue, 21 Nov 2023 20:19:04 GMT, John Neffenger wrote: > Backport 16169240667876633895b27464eb90033abb6166 > > Please review this backport of openjdk/jfx#1253 to JavaFX 21. Please give me > a day or two to test it again before starting your review. I ran the builds and unit tests on Linux, ma

[jfx21u] RFR: 8317370: JavaFX runtime version is wrong at runtime

Backport 16169240667876633895b27464eb90033abb6166 Please review this backport of openjdk/jfx#1253 to JavaFX 21. Please give me a day or two to test it again before starting your review. - Commit messages: - Backport 16169240667876633895b27464eb90033abb6166 Changes: https://git.ope

Re: RFR: 8317370: JavaFX runtime version is wrong at runtime [v2]

On Tue, 10 Oct 2023 16:24:42 GMT, John Neffenger wrote: >> Please review these changes to the build timestamp and to the JavaFX runtime >> version available in the system properties. > > John Neffenger has updated the pull request incrementally with one additional > commit since the last revisi

Re: RFR: 8317370: JavaFX runtime version is wrong at runtime [v2]

On Tue, 10 Oct 2023 16:24:42 GMT, John Neffenger wrote: >> Please review these changes to the build timestamp and to the JavaFX runtime >> version available in the system properties. > > John Neffenger has updated the pull request incrementally with one additional > commit since the last revisi

Re: RFR: 8317370: JavaFX runtime version is wrong at runtime [v2]

On Tue, 10 Oct 2023 16:24:42 GMT, John Neffenger wrote: >> Please review these changes to the build timestamp and to the JavaFX runtime >> version available in the system properties. > > John Neffenger has updated the pull request incrementally with one additional > commit since the last revisi

Re: RFR: 8317370: JavaFX runtime version is wrong at runtime [v2]

> Please review these changes to the build timestamp and to the JavaFX runtime > version available in the system properties. John Neffenger has updated the pull request incrementally with one additional commit since the last revision: Update the documentation in UPDATING-VERSION.md -

Re: RFR: 8317370: JavaFX runtime version is wrong at runtime

On Mon, 2 Oct 2023 22:06:38 GMT, John Neffenger wrote: > Please review these changes to the build timestamp and to the JavaFX runtime > version available in the system properties. Thanks, Kevin. I'll fix that. To all reviewers: I added tests of the method [VersionInfo.setupSystemProperties][1

Re: RFR: 8317370: JavaFX runtime version is wrong at runtime

On Mon, 2 Oct 2023 22:06:38 GMT, John Neffenger wrote: > Please review these changes to the build timestamp and to the JavaFX runtime > version available in the system properties. The fix and new test both look good. Testing is green. Can you also change the following in [`UPDATING-VERSION.md

Re: RFR: 8317370: JavaFX runtime version is wrong at runtime

On Mon, 2 Oct 2023 22:06:38 GMT, John Neffenger wrote: > Please review these changes to the build timestamp and to the JavaFX runtime > version available in the system properties. @tiainen can you review? - PR Comment: https://git.openjdk.org/jfx/pull/1253#issuecomment-1754743752

Re: RFR: 8317370: JavaFX runtime version is wrong at runtime

On Mon, 2 Oct 2023 22:06:38 GMT, John Neffenger wrote: > Please review these changes to the build timestamp and to the JavaFX runtime > version available in the system properties. @arapte or @johanvos Can one of you also review this? - PR Comment: https://git.openjdk.org/jfx/pull/

Re: RFR: 8317370: JavaFX runtime version is wrong at runtime

On Mon, 2 Oct 2023 22:06:38 GMT, John Neffenger wrote: > Please review these changes to the build timestamp and to the JavaFX runtime > version available in the system properties. @FlorianKirmaier Florian, I would appreciate any comments you might have, too, or even a formal review if you have

Re: RFR: 8317370: JavaFX runtime version is wrong at runtime

On Mon, 2 Oct 2023 22:06:38 GMT, John Neffenger wrote: > Please review these changes to the build timestamp and to the JavaFX runtime > version available in the system properties. This pull request makes three changes: 1. The ISO 8601 extended format of the build date and time is now used only

Re: RFR: 8317370: JavaFX runtime version is wrong at runtime

On Mon, 2 Oct 2023 22:06:38 GMT, John Neffenger wrote: > Please review these changes to the build timestamp and to the JavaFX runtime > version available in the system properties. I'll take a closer look, and also test this, when I can. This looks like the right approach to me. It should not c

RFR: 8317370: JavaFX runtime version is wrong at runtime

Please review these changes to the build timestamp and to the JavaFX runtime version available in the system properties. - Commit messages: - 8317370: JavaFX runtime version is wrong at runtime Changes: https://git.openjdk.org/jfx/pull/1253/files Webrev: https://webrevs.openjdk.or