On Wed, 22 Nov 2023 16:14:12 GMT, John Neffenger <jgn...@openjdk.org> wrote:
> The only thing that didn't get copied over with the original commit is the > updated copyright statement in the VersionInfo.java class: That's because the copyright year was updated separately and later as part of [JDK-8318714](https://bugs.openjdk.org/browse/JDK-8318714) . So it is correctly not part of this backport PR. > In general, do we try to keep that copyright statement updated when > backporting a fix? No. > By the way, would it be worthwhile to investigate whether we could stop > updating the copyright years or even drop the years altogether? Unless and until Oracle's legal department tells us we can stop doing this, I wouldn't spend any time asking whether we need to keep it up to date. However, in order to avoid unnecessary merge conflicts, especially for fixes that might be backported, I often skip updating the copyright year as part of a fix itself, as you did, preferring to let the automated scripts take care of it. ------------- PR Comment: https://git.openjdk.org/jfx21u/pull/32#issuecomment-1827997878
