Re: RFR: 8307363: TextFlow.underlineShape() [v3]

2023-05-11 Thread Phil Race
On Wed, 10 May 2023 23:32:04 GMT, Andy Goryachev wrote: >> Adding TextFlow.underlineShape() to add support for a spellchecker-like >> decoration, using >> >> getRange(start, end, TextLayout.TYPE_UNDERLINE); >> >> >> which mirrors an existing method in Text with exactly the same signature. >

Re: RFR: 8307363: TextFlow.underlineShape() [v3]

2023-05-11 Thread Kevin Rushforth
On Wed, 10 May 2023 17:22:01 GMT, Phil Race wrote: >> Andy Goryachev has updated the pull request incrementally with one >> additional commit since the last revision: >> >> review comments > > Seems fine. @prrace Can you re-review this when you get a chance? - PR Comment: https

Re: RFR: 8307363: TextFlow.underlineShape() [v3]

2023-05-11 Thread Kevin Rushforth
On Wed, 10 May 2023 23:32:04 GMT, Andy Goryachev wrote: >> Adding TextFlow.underlineShape() to add support for a spellchecker-like >> decoration, using >> >> getRange(start, end, TextLayout.TYPE_UNDERLINE); >> >> >> which mirrors an existing method in Text with exactly the same signature. >

Re: RFR: 8307363: TextFlow.underlineShape() [v2]

2023-05-10 Thread Andy Goryachev
On Wed, 10 May 2023 23:12:50 GMT, Kevin Rushforth wrote: >> Andy Goryachev has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains five additional >> co

Re: RFR: 8307363: TextFlow.underlineShape() [v3]

2023-05-10 Thread Andy Goryachev
> Adding TextFlow.underlineShape() to add support for a spellchecker-like > decoration, using > > getRange(start, end, TextLayout.TYPE_UNDERLINE); > > > which mirrors an existing method in Text with exactly the same signature. Andy Goryachev has updated the pull request incrementally with one

Re: RFR: 8307363: TextFlow.underlineShape() [v2]

2023-05-10 Thread Kevin Rushforth
On Wed, 10 May 2023 20:48:22 GMT, Andy Goryachev wrote: >> Adding TextFlow.underlineShape() to add support for a spellchecker-like >> decoration, using >> >> getRange(start, end, TextLayout.TYPE_UNDERLINE); >> >> >> which mirrors an existing method in Text with exactly the same signature. >

Re: RFR: 8307363: TextFlow.underlineShape() [v2]

2023-05-10 Thread Andy Goryachev
On Wed, 10 May 2023 20:48:22 GMT, Andy Goryachev wrote: >> Adding TextFlow.underlineShape() to add support for a spellchecker-like >> decoration, using >> >> getRange(start, end, TextLayout.TYPE_UNDERLINE); >> >> >> which mirrors an existing method in Text with exactly the same signature. >

Re: RFR: 8307363: TextFlow.underlineShape() [v2]

2023-05-10 Thread Andy Goryachev
> Adding TextFlow.underlineShape() to add support for a spellchecker-like > decoration, using > > getRange(start, end, TextLayout.TYPE_UNDERLINE); > > > which mirrors an existing method in Text with exactly the same signature. Andy Goryachev has updated the pull request with a new target base

Re: RFR: 8307363: TextFlow.underlineShape()

2023-05-10 Thread Andy Goryachev
On Wed, 10 May 2023 17:40:59 GMT, Kevin Rushforth wrote: > UPDATE: THIS COMMENT WAS MEANT FOR ANOTHER PR. we've all been there! :-) - PR Comment: https://git.openjdk.org/jfx/pull/1127#issuecomment-1542585334

Re: RFR: 8307363: TextFlow.underlineShape()

2023-05-10 Thread Kevin Rushforth
On Thu, 4 May 2023 18:50:35 GMT, Andy Goryachev wrote: > Adding TextFlow.underlineShape() to add support for a spellchecker-like > decoration, using > > getRange(start, end, TextLayout.TYPE_UNDERLINE); > > > which mirrors an existing method in Text with exactly the same signature. ~~It's de

Re: RFR: 8307363: TextFlow.underlineShape()

2023-05-10 Thread Kevin Rushforth
On Thu, 4 May 2023 18:50:35 GMT, Andy Goryachev wrote: > Adding TextFlow.underlineShape() to add support for a spellchecker-like > decoration, using > > getRange(start, end, TextLayout.TYPE_UNDERLINE); > > > which mirrors an existing method in Text with exactly the same signature. The API l

Re: RFR: 8307363: TextFlow.underlineShape()

2023-05-10 Thread Phil Race
On Thu, 4 May 2023 18:50:35 GMT, Andy Goryachev wrote: > Adding TextFlow.underlineShape() to add support for a spellchecker-like > decoration, using > > getRange(start, end, TextLayout.TYPE_UNDERLINE); > > > which mirrors an existing method in Text with exactly the same signature. Seems fin

Re: RFR: 8307363: TextFlow.underlineShape()

2023-05-10 Thread Kevin Rushforth
On Thu, 4 May 2023 18:50:35 GMT, Andy Goryachev wrote: > Adding TextFlow.underlineShape() to add support for a spellchecker-like > decoration, using > > getRange(start, end, TextLayout.TYPE_UNDERLINE); > > > which mirrors an existing method in Text with exactly the same signature. Maybe @pr

Re: RFR: 8307363: TextFlow.underlineShape()

2023-05-10 Thread Nir Lisker
On Thu, 4 May 2023 18:50:35 GMT, Andy Goryachev wrote: > Adding TextFlow.underlineShape() to add support for a spellchecker-like > decoration, using > > getRange(start, end, TextLayout.TYPE_UNDERLINE); > > > which mirrors an existing method in Text with exactly the same signature. I'm not f

Re: RFR: 8307363: TextFlow.underlineShape()

2023-05-10 Thread Andy Goryachev
On Thu, 4 May 2023 18:50:35 GMT, Andy Goryachev wrote: > Adding TextFlow.underlineShape() to add support for a spellchecker-like > decoration, using > > getRange(start, end, TextLayout.TYPE_UNDERLINE); > > > which mirrors an existing method in Text with exactly the same signature. @nlisker

RFR: 8307363: TextFlow.underlineShape()

2023-05-04 Thread Andy Goryachev
Adding TextFlow.underlineShape() to add support for a spellchecker-like decoration, using getRange(start, end, TextLayout.TYPE_UNDERLINE); which mirrors an existing method in Text with exactly the same signature. - Commit messages: - use the same javadoc as in Text - whitespace