On Thu, 4 May 2023 18:50:35 GMT, Andy Goryachev <ango...@openjdk.org> wrote:

> Adding TextFlow.underlineShape() to add support for a spellchecker-like 
> decoration, using 
> 
> getRange(start, end, TextLayout.TYPE_UNDERLINE);
> 
> 
> which mirrors an existing method in Text with exactly the same signature.

The API looks good. Go ahead and create the CSR. The implementation looks 
correct, as does the manual test addition to MonkeyTester. Can you also add an 
automated test?

-------------

PR Review: https://git.openjdk.org/jfx/pull/1127#pullrequestreview-1421112283

Reply via email to