On Mon, 9 Dec 2024 23:53:54 GMT, Marius Hanl wrote:
>> Alternative PR to https://github.com/openjdk/jfx/pull/1330 which does not
>> modify the layout of `VirtualFlow`.
>>
>> This PR fixes the glitching by removing the code in `NGNode.renderRectClip`,
>> which made many calculations leading to
On Mon, 9 Dec 2024 23:53:54 GMT, Marius Hanl wrote:
>> Alternative PR to https://github.com/openjdk/jfx/pull/1330 which does not
>> modify the layout of `VirtualFlow`.
>>
>> This PR fixes the glitching by removing the code in `NGNode.renderRectClip`,
>> which made many calculations leading to
On Thu, 12 Dec 2024 19:52:53 GMT, Andy Goryachev wrote:
> please address the merge conflict.
?
-
PR Comment: https://git.openjdk.org/jfx/pull/1462#issuecomment-2540033618
On Mon, 9 Dec 2024 23:53:54 GMT, Marius Hanl wrote:
>> Alternative PR to https://github.com/openjdk/jfx/pull/1330 which does not
>> modify the layout of `VirtualFlow`.
>>
>> This PR fixes the glitching by removing the code in `NGNode.renderRectClip`,
>> which made many calculations leading to
> Alternative PR to https://github.com/openjdk/jfx/pull/1330 which does not
> modify the layout of `VirtualFlow`.
>
> This PR fixes the glitching by removing the code in `NGNode.renderRectClip`,
> which made many calculations leading to floating point errors.
> Interestingly I found out, that `g
On Wed, 4 Dec 2024 12:27:54 GMT, Ambarish Rapte wrote:
>> Marius Hanl has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains six commits:
>>
>> - Merge branch 'master' of https://github.com/openjdk/jfx into
>> 8218745-tableview-glitch-
On Thu, 14 Nov 2024 21:52:57 GMT, Marius Hanl wrote:
>> Alternative PR to https://github.com/openjdk/jfx/pull/1330 which does not
>> modify the layout of `VirtualFlow`.
>>
>> This PR fixes the glitching by removing the code in `NGNode.renderRectClip`,
>> which made many calculations leading to
On Thu, 14 Nov 2024 21:52:57 GMT, Marius Hanl wrote:
>> Alternative PR to https://github.com/openjdk/jfx/pull/1330 which does not
>> modify the layout of `VirtualFlow`.
>>
>> This PR fixes the glitching by removing the code in `NGNode.renderRectClip`,
>> which made many calculations leading to
> Alternative PR to https://github.com/openjdk/jfx/pull/1330 which does not
> modify the layout of `VirtualFlow`.
>
> This PR fixes the glitching by removing the code in `NGNode.renderRectClip`,
> which made many calculations leading to floating point errors.
> Interestingly I found out, that `g
On Tue, 4 Jun 2024 12:33:06 GMT, Marius Hanl wrote:
>> you are right: I see the focus rectangle jitter at 175% scale on win 11 (w/o
>> the fix), so it must be a different issue. At this scale, it merely shows a
>> thinner line, perhaps that's why I did not notice it earlier.
>
>> you are right
> Alternative PR to https://github.com/openjdk/jfx/pull/1330 which does not
> modify the layout of `VirtualFlow`.
>
> This PR fixes the glitching by removing the code in `NGNode.renderRectClip`,
> which made many calculations leading to floating point errors.
> Interestingly I found out, that `g
On Tue, 4 Jun 2024 12:33:06 GMT, Marius Hanl wrote:
>> you are right: I see the focus rectangle jitter at 175% scale on win 11 (w/o
>> the fix), so it must be a different issue. At this scale, it merely shows a
>> thinner line, perhaps that's why I did not notice it earlier.
>
>> you are right
On Tue, 10 Sep 2024 20:22:43 GMT, Marius Hanl wrote:
>> Alternative PR to https://github.com/openjdk/jfx/pull/1330 which does not
>> modify the layout of `VirtualFlow`.
>>
>> This PR fixes the glitching by removing the code in `NGNode.renderRectClip`,
>> which made many calculations leading to
> Alternative PR to https://github.com/openjdk/jfx/pull/1330 which does not
> modify the layout of `VirtualFlow`.
>
> This PR fixes the glitching by removing the code in `NGNode.renderRectClip`,
> which made many calculations leading to floating point errors.
> Interestingly I found out, that `g
On Tue, 4 Jun 2024 12:33:06 GMT, Marius Hanl wrote:
>> you are right: I see the focus rectangle jitter at 175% scale on win 11 (w/o
>> the fix), so it must be a different issue. At this scale, it merely shows a
>> thinner line, perhaps that's why I did not notice it earlier.
>
>> you are right
On Thu, 11 Jul 2024 17:15:14 GMT, Marius Hanl wrote:
>> Alternative PR to https://github.com/openjdk/jfx/pull/1330 which does not
>> modify the layout of `VirtualFlow`.
>>
>> This PR fixes the glitching by removing the code in `NGNode.renderRectClip`,
>> which made many calculations leading to
On Thu, 11 Jul 2024 17:15:14 GMT, Marius Hanl wrote:
>> Alternative PR to https://github.com/openjdk/jfx/pull/1330 which does not
>> modify the layout of `VirtualFlow`.
>>
>> This PR fixes the glitching by removing the code in `NGNode.renderRectClip`,
>> which made many calculations leading to
> Alternative PR to https://github.com/openjdk/jfx/pull/1330 which does not
> modify the layout of `VirtualFlow`.
>
> This PR fixes the glitching by removing the code in `NGNode.renderRectClip`,
> which made many calculations leading to floating point errors.
> Interestingly I found out, that `g
On Fri, 31 May 2024 17:51:58 GMT, Andy Goryachev wrote:
> should this PR be closed in favor of #1462 ?
Either that, or else moved to Draft while #1462 is being reviewed.
-
PR Comment: https://git.openjdk.org/jfx/pull/1330#issuecomment-2162878296
On Fri, 31 May 2024 17:47:22 GMT, Andy Goryachev wrote:
> you are right: I see the focus rectangle jitter at 175% scale on win 11 (w/o
> the fix), so it must be a different issue. At this scale, it merely shows a
> thinner line, perhaps that's why I did not notice it earlier.
Yeah exactly, it
On Thu, 23 May 2024 12:56:22 GMT, Marius Hanl wrote:
>> This PR fixes the border glitch/gap as explained in both linked tickets.
>>
>> I noted that the `ScrollPane` control does not suffer from this problem,
>> although the code is mostly the same as in `VirtualFlow`. The `ScrollPane`
>> snaps
On Sun, 26 May 2024 12:47:20 GMT, Marius Hanl wrote:
>> Alternative PR to https://github.com/openjdk/jfx/pull/1330 which does not
>> modify the layout of `VirtualFlow`.
>>
>> This PR fixes the glitching by removing the code in `NGNode.renderRectClip`,
>> which made many calculations leading to
On Tue, 28 May 2024 14:32:01 GMT, Andy Goryachev wrote:
> I do not see the issue without the fix though (at the same resolution).
I can, the `TableView` is the root of the `Scene` in this case. Happens inside
a `StackPane` as well.
.
-
PR Comment: https://git.openjdk.org/jfx/pull/1462#issuecomment-2135380812
On Thu, 23 May 2024 21:51:55 GMT, Marius Hanl wrote:
> Alternative PR to https://github.com/openjdk/jfx/pull/1330 which does not
> modify the layout of `VirtualFlow`.
>
> This PR fixes the glitching by removing the code in `NGNode.renderRectClip`,
> which made many calculations leading to floa
> Alternative PR to https://github.com/openjdk/jfx/pull/1330 which does not
> modify the layout of `VirtualFlow`.
>
> This PR fixes the glitching by removing the code in `NGNode.renderRectClip`,
> which made many calculations leading to floating point errors.
> Interestingly I found out, that `g
On Fri, 24 May 2024 16:59:20 GMT, Andy Goryachev wrote:
>> Alternative PR to https://github.com/openjdk/jfx/pull/1330 which does not
>> modify the layout of `VirtualFlow`.
>>
>> This PR fixes the glitching by removing the code in `NGNode.renderRectClip`,
>> which made many calculations leading
On Thu, 23 May 2024 21:51:55 GMT, Marius Hanl wrote:
> Alternative PR to https://github.com/openjdk/jfx/pull/1330 which does not
> modify the layout of `VirtualFlow`.
>
> This PR fixes the glitching by removing the code in `NGNode.renderRectClip`,
> which made many calculations leading to floa
On Thu, 23 May 2024 22:02:41 GMT, Kevin Rushforth wrote:
> I'm reasonably sure there was a good reason for the code in NGNode doing what
> it did. This will need very careful review and testing before we would accept
> it.
100% agree.
Note that the code there is a shortcut for performance rea
On Thu, 23 May 2024 21:51:55 GMT, Marius Hanl wrote:
> Alternative PR to https://github.com/openjdk/jfx/pull/1330 which does not
> modify the layout of `VirtualFlow`.
>
> This PR fixes the glitching by removing the code in `NGNode.renderRectClip`,
> which made many calculations leading to floa
On Thu, 23 May 2024 21:51:55 GMT, Marius Hanl wrote:
> Alternative PR to https://github.com/openjdk/jfx/pull/1330 which does not
> modify the layout of `VirtualFlow`.
>
> This PR fixes the glitching by removing the code in `NGNode.renderRectClip`,
> which made many calculations leading to floa
Alternative PR to https://github.com/openjdk/jfx/pull/1330 which does not
modify the layout of `VirtualFlow`.
This PR fixes the glitching by removing the code in `NGNode.renderRectClip`,
which made many calculations leading to floating point errors.
Interestingly I found out, that `getClippedBou
> This PR fixes the border glitch/gap as explained in both linked tickets.
>
> I noted that the `ScrollPane` control does not suffer from this problem,
> although the code is mostly the same as in `VirtualFlow`. The `ScrollPane`
> snaps the content correctly, no matter which scale. I carefully c
On Sun, 10 Mar 2024 13:29:58 GMT, Marius Hanl wrote:
> But there is obviously a bug on the low level NGNode side as well. Not sure
> where to go from here.
does it mean this PR is not ready, or do we have other issue(s)?
Also, a CSR is needed for this PR to go forward.
-
PR Comme
On Wed, 10 Jan 2024 19:21:16 GMT, Marius Hanl wrote:
> This PR fixes the border glitch/gap as explained in both linked tickets.
>
> I noted that the `ScrollPane` control does not suffer from this problem,
> although the code is mostly the same as in `VirtualFlow`. The `ScrollPane`
> snaps the
> This PR fixes an issue which is probably in JavaFX since VirtualFlow exists.
> While horizontal scrolling any VirtualFlow control the left blue border
> sometimes disappear/gets smaller. (see also image below)
>
> This can be fixed by **snapping** the scroll bar value (similar like e.g. a
> **
36 matches
Mail list logo
