On Thu, 23 May 2024 22:02:41 GMT, Kevin Rushforth <k...@openjdk.org> wrote:
> I'm reasonably sure there was a good reason for the code in NGNode doing what > it did. This will need very careful review and testing before we would accept > it. 100% agree. Note that the code there is a shortcut for performance reasons. Removing it will also fix the bug since the code below is doing the right thing, but will probably result in a performance impact. Thats why I checked the other path and had a closer look what it does, since it still needs to the right for whatever clip is used. And there I saw that is does nearly the same thing, but with the `getClippedBounds` instead. With that in mind, we need to especially check if the fast path did something completely unexpected what the other 'slow' path did not and we may miss now. ------------- PR Comment: https://git.openjdk.org/jfx/pull/1462#issuecomment-2128150585
