Re: RFR: 8088343: Intermittent unit test failure in javafx.concurrent.ServiceLifecycleTest [v2]

2025-04-16 Thread Andy Goryachev
On Wed, 16 Apr 2025 16:35:39 GMT, Kevin Rushforth wrote: >> Andy Goryachev has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains two additional >> com

Re: RFR: 8088343: Intermittent unit test failure in javafx.concurrent.ServiceLifecycleTest [v3]

2025-04-16 Thread Andy Goryachev
> The code should not set the `Task.state` value to `CANCELLED` if the said > task is already `SUCCEEDED` or `FAILED`. > > This is a product bug. > > Added `@RepeatedTest(50)` to the tests that used to fail intermittently - > this made the test failed more reliably without the fix. Andy Goryac

Re: RFR: 8088343: Intermittent unit test failure in javafx.concurrent.ServiceLifecycleTest [v2]

2025-04-16 Thread Andy Goryachev
On Wed, 16 Apr 2025 16:23:14 GMT, Kevin Rushforth wrote: >> Andy Goryachev has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains two additional >> com

Re: RFR: 8088343: Intermittent unit test failure in javafx.concurrent.ServiceLifecycleTest [v2]

2025-04-16 Thread Kevin Rushforth
On Fri, 11 Apr 2025 17:06:38 GMT, Andy Goryachev wrote: >> The code should not set the `Task.state` value to `CANCELLED` if the said >> task is already `SUCCEEDED` or `FAILED`. >> >> This is a product bug. >> >> Added `@RepeatedTest(50)` to the tests that used to fail intermittently - >> this

Re: RFR: 8088343: Intermittent unit test failure in javafx.concurrent.ServiceLifecycleTest [v2]

2025-04-11 Thread Andy Goryachev
> The code should not set the `Task.state` value to `CANCELLED` if the said > task is already `SUCCEEDED` or `FAILED`. > > This is a product bug. > > Added `@RepeatedTest(50)` to the tests that used to fail intermittently - > this made the test failed more reliably without the fix. Andy Goryac

Re: RFR: 8088343: Intermittent unit test failure in javafx.concurrent.ServiceLifecycleTest

2025-04-10 Thread Kevin Rushforth
On Thu, 10 Apr 2025 21:22:21 GMT, Andy Goryachev wrote: > The code should not set the `Task.state` value to `CANCELLED` if the said > task is already `SUCCEEDED` or `FAILED`. > > This is a product bug. Reviewers: @kevinrushforth @arapte - PR Comment: https://git.openjdk.org/jfx/p

RFR: 8088343: Intermittent unit test failure in javafx.concurrent.ServiceLifecycleTest

2025-04-10 Thread Andy Goryachev
The code should not set the `Task.state` value to `CANCELLED` if the said task is already `SUCCEEDED` or `FAILED`. This is a product bug. - Commit messages: - 8088343 Changes: https://git.openjdk.org/jfx/pull/1769/files Webrev: https://webrevs.openjdk.org/?repo=jfx&pr=1769&range