On Wed, 16 Apr 2025 16:35:39 GMT, Kevin Rushforth wrote:
>> Andy Goryachev has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains two additional
>> com
> The code should not set the `Task.state` value to `CANCELLED` if the said
> task is already `SUCCEEDED` or `FAILED`.
>
> This is a product bug.
>
> Added `@RepeatedTest(50)` to the tests that used to fail intermittently -
> this made the test failed more reliably without the fix.
Andy Goryac
On Wed, 16 Apr 2025 16:23:14 GMT, Kevin Rushforth wrote:
>> Andy Goryachev has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains two additional
>> com
On Fri, 11 Apr 2025 17:06:38 GMT, Andy Goryachev wrote:
>> The code should not set the `Task.state` value to `CANCELLED` if the said
>> task is already `SUCCEEDED` or `FAILED`.
>>
>> This is a product bug.
>>
>> Added `@RepeatedTest(50)` to the tests that used to fail intermittently -
>> this
> The code should not set the `Task.state` value to `CANCELLED` if the said
> task is already `SUCCEEDED` or `FAILED`.
>
> This is a product bug.
>
> Added `@RepeatedTest(50)` to the tests that used to fail intermittently -
> this made the test failed more reliably without the fix.
Andy Goryac
On Thu, 10 Apr 2025 21:22:21 GMT, Andy Goryachev wrote:
> The code should not set the `Task.state` value to `CANCELLED` if the said
> task is already `SUCCEEDED` or `FAILED`.
>
> This is a product bug.
Reviewers: @kevinrushforth @arapte
-
PR Comment: https://git.openjdk.org/jfx/p
The code should not set the `Task.state` value to `CANCELLED` if the said task
is already `SUCCEEDED` or `FAILED`.
This is a product bug.
-
Commit messages:
- 8088343
Changes: https://git.openjdk.org/jfx/pull/1769/files
Webrev: https://webrevs.openjdk.org/?repo=jfx&pr=1769&range