Re: Possible leak on prism es2

2024-10-02 Thread Kevin Rushforth
I think you might be right. I see that you created a Draft PR. Can you also file a bug? -- Kevin On 9/27/2024 2:07 PM, Thiago Milczarek Sayão wrote: Hi, Pardon me If I'm bothering with nonsense, but I really think there's a leak, mainly because DrawableInfo is never freed (I did not find an

Re: Possible leak on prism es2

2024-09-27 Thread Thiago Milczarek Sayão
Hi, Pardon me If I'm bothering with nonsense, but I really think there's a leak, mainly because DrawableInfo is never freed (I did not find any code that frees it). Using valgrind, I see *many* entries like this: ==28403== 1,464 bytes in 61 blocks are still reachable in loss record 15,444 of 16,

Re: Possible leak on prism es2

2024-09-26 Thread Thiago Milczarek Sayão
Hi, I'm investigating the code, and for someone not familiar with it, it's very complex. On com.sun.javafx.tk.quantum.WindowStage it will do this when changing scene: if (oldScene != null) { ViewPainter painter = ((ViewScene)oldScene).getPainter(); QuantumRenderer.getInstance().disposePr

Re: Possible leak on prism es2

2024-09-24 Thread Thiago Milczarek Sayão
I might be mistaken, but it seems deleteDrawableInfo is never called. I think it should be called when the platform View is replaced or when the window is closed. Github search for deleteDrawableInfo https://github.com/search?q=repo%3Aopenjdk%2Fjfx%20deleteDrawableInfo&type=code Em ter., 24 de s

Possible leak on prism es2

2024-09-24 Thread Thiago Milczarek Sayão
Hi, While doing some work on replacing GLX with EGL I discovered a possible leak. Running this test: gradle -PFULL_TEST=true -PUSE_ROBOT=true :systemTests:test --tests SetSceneScalingTest will result in X11GLDrawable -> nCreateDrawable to be called multiple times on the same test, while GLDrawa