Integrated: 8311895: CSS Transitions

On Tue, 16 Aug 2022 03:01:23 GMT, Michael Strauß wrote: > Implementation of [CSS Transitions](https://www.w3.org/TR/css-transitions-1/). > > ### Future enhancements > CSS transition support for backgrounds and borders: #1471 > > ### Limitations > This implementation su

Re: RFR: 8311895: CSS Transitions [v23]

On Wed, 5 Jun 2024 21:59:13 GMT, Michael Strauß wrote: >> Implementation of [CSS >> Transitions](https://www.w3.org/TR/css-transitions-1/). >> >> ### Future enhancements >> CSS transition support for backgrounds and borders: #1471 >> >> ### Limita

Re: RFR: 8311895: CSS Transitions [v23]

On Wed, 5 Jun 2024 21:59:13 GMT, Michael Strauß wrote: >> Implementation of [CSS >> Transitions](https://www.w3.org/TR/css-transitions-1/). >> >> ### Future enhancements >> CSS transition support for backgrounds and borders: #1471 >> >> ### Limita

Re: RFR: 8311895: CSS Transitions [v23]

On Wed, 5 Jun 2024 21:59:13 GMT, Michael Strauß wrote: >> Implementation of [CSS >> Transitions](https://www.w3.org/TR/css-transitions-1/). >> >> ### Future enhancements >> CSS transition support for backgrounds and borders: #1471 >> >> ### Limita

Re: RFR: 8311895: CSS Transitions [v20]

On Sun, 26 May 2024 11:26:50 GMT, Nir Lisker wrote: >> Michael Strauß has updated the pull request incrementally with one >> additional commit since the last revision: >> >> documentation change > > I think the CSR needs updating. @nlisker @drmarmac Can you re-review (there have only been mi

Re: RFR: 8311895: CSS Transitions [v17]

On Tue, 4 Jun 2024 21:14:54 GMT, Kevin Rushforth wrote: >> I think it's fine. Another option is to link to the part of the reference >> where they are. > > I would prefer to keep them in one place (scene) and link to the ones there > (`../scene/doc-files/`). I've linked to the files in `scene/

Re: RFR: 8311895: CSS Transitions [v22]

On Wed, 5 Jun 2024 21:47:21 GMT, Michael Strauß wrote: >> modules/javafx.graphics/src/main/docs/javafx/scene/doc-files/cssref.html >> line 704: >> >>> 702: >>> 703: >> scope="row">transition‑property >>> 704: [ none | all | # >>> ] >> >> Why is there a

Re: RFR: 8311895: CSS Transitions [v23]

> Implementation of [CSS Transitions](https://www.w3.org/TR/css-transitions-1/). > > ### Future enhancements > CSS transition support for backgrounds and borders: #1471 > > ### Limitations > This implementation supports both shorthand and longhand notations for the &g

Re: RFR: 8311895: CSS Transitions [v22]

On Wed, 5 Jun 2024 17:43:46 GMT, Kevin Rushforth wrote: >> Michael Strauß has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains 62 commits: >> >> - Merge branch 'refs/heads/master' into feature/

Re: RFR: 8311895: CSS Transitions [v22]

On Fri, 31 May 2024 15:09:38 GMT, Michael Strauß wrote: >> Implementation of [CSS >> Transitions](https://www.w3.org/TR/css-transitions-1/). >> >> ### Future enhancements >> CSS transition support for backgrounds and borders: #1471 >> >> ### Limita

Re: RFR: 8311895: CSS Transitions [v17]

On Sat, 25 May 2024 20:49:08 GMT, Nir Lisker wrote: >> I've included the images that are also used in the CSS reference >> documentation. Now there are two copies of these images in two different >> `doc-files` folders, but I guess that's okay. > > I think it's fine. Another option is to link t

Re: RFR: 8311895: CSS Transitions [v22]

On Fri, 31 May 2024 15:09:38 GMT, Michael Strauß wrote: >> Implementation of [CSS >> Transitions](https://www.w3.org/TR/css-transitions-1/). >> >> ### Future enhancements >> CSS transition support for backgrounds and borders: #1471 >> >> ### Limita

Re: RFR: 8311895: CSS Transitions [v22]

> Implementation of [CSS > Transitions](https://gist.github.com/mstr2/c72f8c9faa87de14926978f517a6018a). > > ### Future enhancements > CSS transitions requires all participating objects to implement the > `Interpolatable` interface. For example, targeting `-fx-background-color

Re: RFR: 8311895: CSS Transitions [v21]

> Implementation of [CSS > Transitions](https://gist.github.com/mstr2/c72f8c9faa87de14926978f517a6018a). > > ### Future enhancements > CSS transitions requires all participating objects to implement the > `Interpolatable` interface. For example, targeting `-fx-background-color

Re: RFR: 8311895: CSS Transitions [v20]

On Sun, 26 May 2024 08:08:26 GMT, Michael Strauß wrote: >> Implementation of [CSS >> Transitions](https://gist.github.com/mstr2/c72f8c9faa87de14926978f517a6018a). >> >> ### Future enhancements >> CSS transitions requires all participating objects to implement the

Re: RFR: 8311895: CSS Transitions [v20]

On Sun, 26 May 2024 08:08:26 GMT, Michael Strauß wrote: >> Implementation of [CSS >> Transitions](https://gist.github.com/mstr2/c72f8c9faa87de14926978f517a6018a). >> >> ### Future enhancements >> CSS transitions requires all participating objects to implement the

Re: RFR: 8311895: CSS Transitions [v20]

> Implementation of [CSS > Transitions](https://gist.github.com/mstr2/c72f8c9faa87de14926978f517a6018a). > > ### Future enhancements > CSS transitions requires all participating objects to implement the > `Interpolatable` interface. For example, targeting `-fx-background-color

Re: RFR: 8311895: CSS Transitions [v19]

On Sat, 25 May 2024 23:19:03 GMT, Nir Lisker wrote: >> Michael Strauß has updated the pull request incrementally with one >> additional commit since the last revision: >> >> added documentation > > modules/javafx.graphics/src/main/docs/javafx/scene/doc-files/cssref.html line > 749: > >> 747

Re: RFR: 8311895: CSS Transitions [v19]

On Sat, 25 May 2024 21:39:24 GMT, Michael Strauß wrote: >> Implementation of [CSS >> Transitions](https://gist.github.com/mstr2/c72f8c9faa87de14926978f517a6018a). >> >> ### Future enhancements >> CSS transitions requires all participating objects to implement the

Re: RFR: 8311895: CSS Transitions [v18]

On Sat, 25 May 2024 21:17:06 GMT, Nir Lisker wrote: > This is what I would expect, so looks good. Where is this mentioned to the > user? Good question. Since we don't have any suitable API elements for javadocs, I've added some documentation to the CSS reference. - PR Comment: ht

Re: RFR: 8311895: CSS Transitions [v19]

> Implementation of [CSS > Transitions](https://gist.github.com/mstr2/c72f8c9faa87de14926978f517a6018a). > > ### Future enhancements > CSS transitions requires all participating objects to implement the > `Interpolatable` interface. For example, targeting `-fx-background-color

Re: RFR: 8311895: CSS Transitions [v18]

On Sat, 25 May 2024 20:40:39 GMT, Michael Strauß wrote: >> Implementation of [CSS >> Transitions](https://gist.github.com/mstr2/c72f8c9faa87de14926978f517a6018a). >> >> ### Future enhancements >> CSS transitions requires all participating objects to implement the

Re: RFR: 8311895: CSS Transitions [v17]

On Sat, 25 May 2024 19:39:12 GMT, Nir Lisker wrote: > I still don't know what happens when a value is programmatically set while a > css transition is in progress. What I understood is that binding the property > will not allow the transition to start/continue, but didn't see where setting > a

Re: RFR: 8311895: CSS Transitions [v17]

On Sat, 25 May 2024 21:04:24 GMT, Michael Strauß wrote: >> modules/javafx.graphics/src/main/docs/javafx/scene/doc-files/cssref.html >> line 690: >> >>> 688: changed, it smoothly transitions to the new value over a >>> period of time. Implicit transitions are supported >>> 689:

Re: RFR: 8311895: CSS Transitions [v17]

On Sat, 25 May 2024 19:35:56 GMT, Nir Lisker wrote: >> Michael Strauß has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains 57 commits: >> >> - Merge branch 'refs/heads/master' into feature/css-tran

Re: RFR: 8311895: CSS Transitions [v17]

On Sat, 25 May 2024 19:28:56 GMT, Nir Lisker wrote: >> Michael Strauß has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains 57 commits: >> >> - Merge branch 'refs/heads/master' into feature/css-tran

Re: RFR: 8311895: CSS Transitions [v17]

On Sat, 25 May 2024 20:37:44 GMT, Michael Strauß wrote: >> modules/javafx.graphics/src/main/java/javafx/animation/Interpolator.java >> line 277: >> >>> 275: * @since 23 >>> 276: */ >>> 277: public enum StepPosition { >> >> I think it would be helpful to include (or link to) image

Re: RFR: 8311895: CSS Transitions [v17]

On Sat, 25 May 2024 17:40:01 GMT, Nir Lisker wrote: >> Michael Strauß has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains 57 commits: >> >> - Merge branch 'refs/heads/master' into feature/css-tran

Re: RFR: 8311895: CSS Transitions [v17]

On Sat, 25 May 2024 10:40:05 GMT, Nir Lisker wrote: >> Michael Strauß has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains 57 commits: >> >> - Merge branch 'refs/heads/master' into feature/css-tran

Re: RFR: 8311895: CSS Transitions [v18]

> Implementation of [CSS > Transitions](https://gist.github.com/mstr2/c72f8c9faa87de14926978f517a6018a). > > ### Future enhancements > CSS transitions requires all participating objects to implement the > `Interpolatable` interface. For example, targeting `-fx-background-color

Re: RFR: 8311895: CSS Transitions [v2]

On Mon, 31 Jul 2023 18:10:46 GMT, Michael Strauß wrote: >> modules/javafx.graphics/src/main/java/javafx/animation/Interpolator.java >> line 319: >> >>> 317: * The output time value is determined by the {@link StepPosition}. >>> 318: * >>> 319: * @param intervals the number of int

Re: RFR: 8311895: CSS Transitions [v17]

On Fri, 24 May 2024 11:18:35 GMT, Michael Strauß wrote: >> Implementation of [CSS >> Transitions](https://gist.github.com/mstr2/c72f8c9faa87de14926978f517a6018a). >> >> ### Future enhancements >> CSS transitions requires all participating objects to implement the

Re: RFR: 8311895: CSS Transitions [v16]

On Fri, 24 May 2024 10:15:37 GMT, drmarmac wrote: > * Attempting to do background-color transitions doesn't work, I presume > because it's not yet `Interpolatable` in this PR. Do we need to emit a > warning in such a case? Right now the `transition` CSS code just seems to

Re: RFR: 8311895: CSS Transitions [v16]

On Fri, 24 May 2024 10:02:44 GMT, drmarmac wrote: >> Michael Strauß has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains 53 commits: >> >> - Merge branch 'master' into feature/css-transitions &

Re: RFR: 8311895: CSS Transitions [v17]

> Implementation of [CSS > Transitions](https://gist.github.com/mstr2/c72f8c9faa87de14926978f517a6018a). > > ### Future enhancements > CSS transitions requires all participating objects to implement the > `Interpolatable` interface. For example, targeting `-fx-background-color

Re: RFR: 8311895: CSS Transitions [v16]

On Thu, 2 May 2024 08:40:28 GMT, Michael Strauß wrote: >> Implementation of [CSS >> Transitions](https://gist.github.com/mstr2/c72f8c9faa87de14926978f517a6018a). >> >> ### Future enhancements >> CSS transitions requires all participating objects to implement the

Re: RFR: 8311895: CSS Transitions [v16]

> Implementation of [CSS > Transitions](https://gist.github.com/mstr2/c72f8c9faa87de14926978f517a6018a). > > ### Example > > .button { > -fx-background-color: dodgerblue; > } > > .button:hover { > -fx-background-color: red; > -fx-

Re: RFR: 8311895: CSS Transitions [v15]

> Implementation of [CSS > Transitions](https://gist.github.com/mstr2/c72f8c9faa87de14926978f517a6018a). > > ### Example > > .button { > -fx-background-color: dodgerblue; > } > > .button:hover { > -fx-background-color: red; > -fx-

Re: RFR: 8311895: CSS Transitions [v14]

> Implementation of [CSS > Transitions](https://gist.github.com/mstr2/c72f8c9faa87de14926978f517a6018a). > > ### Example > > .button { > -fx-background-color: dodgerblue; > } > > .button:hover { > -fx-background-color: red; > -fx-

Re: RFR: 8311895: CSS Transitions [v13]

> Implementation of [CSS > Transitions](https://gist.github.com/mstr2/c72f8c9faa87de14926978f517a6018a). > > ### Example > > .button { > -fx-background-color: dodgerblue; > } > > .button:hover { > -fx-background-color: red; > -fx-

Re: RFR: 8311895: CSS Transitions [v9]

On Tue, 14 Nov 2023 13:04:35 GMT, John Hendrikx wrote: >> Michael Strauß has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Test whether two Interpolatable instances are compatible > > modules/javafx.graphics/src/main/java/javafx/css/Stylea

Re: RFR: 8311895: CSS Transitions [v12]

> Implementation of [CSS > Transitions](https://gist.github.com/mstr2/c72f8c9faa87de14926978f517a6018a). > > ### Example > > .button { > -fx-background-color: dodgerblue; > } > > .button:hover { > -fx-background-color: red; > -fx-

Re: RFR: 8311895: CSS Transitions [v2]

On Mon, 31 Jul 2023 13:44:28 GMT, John Hendrikx wrote: >> Michael Strauß has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Make TransitionEvent final > > Some early feedback, it's a lot of code :) I've implemented @hjohn's suggestion of a

Re: RFR: 8311895: CSS Transitions [v11]

> Implementation of [CSS > Transitions](https://gist.github.com/mstr2/c72f8c9faa87de14926978f517a6018a). > > ### Example > > .button { > -fx-background-color: dodgerblue; > } > > .button:hover { > -fx-background-color: red; > -fx-

Re: RFR: 8311895: CSS Transitions [v9]

t; >> 232: >> 233: Node node = (Node)timer.getProperty().getBean(); >> 234: node.fireEvent(new TransitionEvent(eventType, >> timer.getProperty(), elapsedTime)); > > minor: > Suggestion: > > long elapsedTime; > >

Re: RFR: 8311895: CSS Transitions [v10]

> Implementation of [CSS > Transitions](https://gist.github.com/mstr2/c72f8c9faa87de14926978f517a6018a). > > ### Example > > .button { > -fx-background-color: dodgerblue; > } > > .button:hover { > -fx-background-color: red; > -fx-

Withdrawn: 8311895: CSS Transitions

On Tue, 16 Aug 2022 03:01:23 GMT, Michael Strauß wrote: > Implementation of [CSS > Transitions](https://gist.github.com/mstr2/c72f8c9faa87de14926978f517a6018a). > > ### Example > > .button { > -fx-background-color: dodgerblue; > } > > .button:hover { &

Re: RFR: 8311895: CSS Transitions [v9]

On Tue, 31 Oct 2023 17:24:05 GMT, Michael Strauß wrote: >> Implementation of [CSS >> Transitions](https://gist.github.com/mstr2/c72f8c9faa87de14926978f517a6018a). >> >> ### Example >> >> .button { >> -fx-background-color: dodgerblue; >> } &g

Re: RFR: 8311895: CSS Transitions [v2]

On Mon, 31 Jul 2023 13:44:28 GMT, John Hendrikx wrote: >> Michael Strauß has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Make TransitionEvent final > > Some early feedback, it's a lot of code :) @hjohn Would you be willing to expand you

Re: RFR: 8311895: CSS Transitions [v9]

> Implementation of [CSS > Transitions](https://gist.github.com/mstr2/c72f8c9faa87de14926978f517a6018a). > > ### Example > > .button { > -fx-background-color: dodgerblue; > } > > .button:hover { > -fx-background-color: red; > -fx-

Re: RFR: 8311895: CSS Transitions [v7]

On Wed, 9 Aug 2023 18:41:32 GMT, Michael Strauß wrote: >> Implementation of [CSS >> Transitions](https://gist.github.com/mstr2/c72f8c9faa87de14926978f517a6018a). >> >> ### Example >> >> .button { >> -fx-background-color: dodgerblue; >> } &g

Re: RFR: 8311895: CSS Transitions [v8]

> Implementation of [CSS > Transitions](https://gist.github.com/mstr2/c72f8c9faa87de14926978f517a6018a). > > ### Example > > .button { > -fx-background-color: dodgerblue; > } > > .button:hover { > -fx-background-color: red; > -fx-

Re: RFR: 8311895: CSS Transitions [v7]

On Wed, 9 Aug 2023 18:41:32 GMT, Michael Strauß wrote: >> Implementation of [CSS >> Transitions](https://gist.github.com/mstr2/c72f8c9faa87de14926978f517a6018a). >> >> ### Example >> >> .button { >> -fx-background-color: dodgerblue; >> } &g

Re: RFR: 8311895: CSS Transitions [v7]

> Implementation of [CSS > Transitions](https://gist.github.com/mstr2/c72f8c9faa87de14926978f517a6018a). > > ### Example > > .button { > -fx-background-color: dodgerblue; > } > > .button:hover { > -fx-background-color: red; > -fx-

Re: RFR: 8311895: CSS Transitions [v2]

On Tue, 1 Aug 2023 17:02:33 GMT, Michael Strauß wrote: >> Yeah, I figured as much. I just don't like code that you can't get covered >> in a unit test, or that contradicts itself. As you can see, I was confused, >> is it a bug or a feature? Perhaps a comment then to indicate that it's >> in

Re: RFR: 8311895: CSS Transitions [v2]

On Tue, 1 Aug 2023 16:44:08 GMT, Michael Strauß wrote: >> I'm not a native either, but it flows a bit better IMHO. I checked `String` >> class, they do it like that there as well. > > In the `String` class, I find 10 usages of `{@code false} otherwise`, and 2 > usages of `otherwise {@code fals

Re: RFR: 8311895: CSS Transitions [v2]

On Tue, 1 Aug 2023 10:49:42 GMT, John Hendrikx wrote: >> The constructor ensures that any spelling of "ALL" is converted to the >> interned constant "all", which is important as we would otherwise need a >> more computationally expensive case-insensitive string comparison in >> `Node.Transitio

Re: RFR: 8311895: CSS Transitions [v6]

> Implementation of [CSS > Transitions](https://gist.github.com/mstr2/c72f8c9faa87de14926978f517a6018a). > > ### Example > > .button { > -fx-background-color: dodgerblue; > } > > .button:hover { > -fx-background-color: red; > -fx-

Re: RFR: 8311895: CSS Transitions [v2]

On Tue, 1 Aug 2023 13:46:15 GMT, John Hendrikx wrote: >> That's true. However, `CssParser` is built around array-based sequences (see >> `StringConverter.SequenceConverter`), and changing these arrays to lists >> would seem out of place for this part of the codebase. What do you think? > > It d

Re: RFR: 8311895: CSS Transitions [v2]

On Tue, 1 Aug 2023 13:47:19 GMT, John Hendrikx wrote: >> I don't see any real difference here, but then again I'm not a native >> speaker. I'll defer to public opinion. > > I'm not a native either, but it flows a bit better IMHO. I checked `String` > class, they do it like that there as well.

Re: RFR: 8311895: CSS Transitions [v2]

On Mon, 31 Jul 2023 18:20:34 GMT, Michael Strauß wrote: >> modules/javafx.graphics/src/main/java/javafx/scene/Node.java line 8968: >> >>> 8966: >>> 8967: for (TransitionTimer timer : transitionTimers) { >>> 8968: if (timer.getProperty() == property) { >> >> minor: this prob

Re: RFR: 8311895: CSS Transitions [v2]

On Mon, 31 Jul 2023 18:16:19 GMT, Michael Strauß wrote: >> modules/javafx.graphics/src/main/java/javafx/css/TransitionEvent.java line >> 88: >> >>> 86: * @param eventType the event type >>> 87: * @param property the {@code StyleableProperty} that is targeted >>> by the transition >>>

Re: RFR: 8311895: CSS Transitions [v2]

On Mon, 31 Jul 2023 18:01:31 GMT, Michael Strauß wrote: >> modules/javafx.graphics/src/main/java/com/sun/scenario/animation/StepInterpolator.java >> line 73: >> >>> 71: } >>> 72: >>> 73: if (t >= 0 && step < 0) { >> >> `t >= 0` always holds, perhaps the original `t` was meant

Re: RFR: 8311895: CSS Transitions [v2]

On Mon, 31 Jul 2023 18:07:52 GMT, Michael Strauß wrote: >> modules/javafx.graphics/src/main/java/com/sun/javafx/css/TransitionDefinitionCssMetaData.java >> line 63: >> >>> 61: private static final Duration[] DURATION_ZERO = new Duration[] { >>> Duration.ZERO }; >>> 62: >>> 63: private

Re: RFR: 8311895: CSS Transitions [v2]

On Mon, 31 Jul 2023 18:29:19 GMT, Michael Strauß wrote: >> modules/javafx.graphics/src/main/java/com/sun/javafx/css/TransitionDefinition.java >> line 54: >> >>> 52: */ >>> 53: public TransitionDefinition(String propertyName, Duration duration, >>> 54: Du

Re: RFR: 8311895: CSS Transitions [v5]

> Implementation of [CSS > Transitions](https://gist.github.com/mstr2/c72f8c9faa87de14926978f517a6018a). > > ### Example > > .button { > -fx-background-color: dodgerblue; > } > > .button:hover { > -fx-background-color: red; > -fx-

Re: RFR: 8311895: CSS Transitions [v2]

mplements `StyleableProperty` directly? Or if classes > are refactored at some point and they decide to stop using these helpers? I don't see how I can make CSS transitions work without some property-specific implementation details. You're right that there is no requirement to use these c

Re: RFR: 8311895: CSS Transitions [v2]

On Mon, 31 Jul 2023 12:04:19 GMT, John Hendrikx wrote: >> Michael Strauß has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Make TransitionEvent final > > modules/javafx.graphics/src/main/java/com/sun/javafx/css/TransitionDefinition.java >

Re: RFR: 8311895: CSS Transitions [v2]

On Mon, 31 Jul 2023 13:39:06 GMT, John Hendrikx wrote: >> Michael Strauß has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Make TransitionEvent final > > modules/javafx.graphics/src/main/java/javafx/scene/Node.java line 8968: > >> 8966:

Re: RFR: 8311895: CSS Transitions [v2]

On Mon, 31 Jul 2023 13:33:41 GMT, John Hendrikx wrote: >> Michael Strauß has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Make TransitionEvent final > > modules/javafx.graphics/src/main/java/javafx/css/TransitionEvent.java line 88: > >>

Re: RFR: 8311895: CSS Transitions [v2]

On Mon, 31 Jul 2023 12:16:05 GMT, John Hendrikx wrote: >> Michael Strauß has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Make TransitionEvent final > > modules/javafx.graphics/src/main/java/com/sun/javafx/css/TransitionDefinitionCssMetaD

Re: RFR: 8311895: CSS Transitions [v2]

On Mon, 31 Jul 2023 12:39:26 GMT, John Hendrikx wrote: >> Michael Strauß has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Make TransitionEvent final > > modules/javafx.graphics/src/main/java/com/sun/javafx/css/TransitionDefinition.java >

Re: RFR: 8311895: CSS Transitions [v2]

On Mon, 31 Jul 2023 12:56:10 GMT, John Hendrikx wrote: >> Michael Strauß has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Make TransitionEvent final > > modules/javafx.graphics/src/main/java/com/sun/scenario/animation/StepInterpolator.jav

Re: RFR: 8311895: CSS Transitions [v4]

> Implementation of [CSS > Transitions](https://gist.github.com/mstr2/c72f8c9faa87de14926978f517a6018a). > > ### Example > > .button { > -fx-background-color: dodgerblue; > } > > .button:hover { > -fx-background-color: red; > -fx-

Re: RFR: 8311895: CSS Transitions [v3]

> Implementation of [CSS > Transitions](https://gist.github.com/mstr2/c72f8c9faa87de14926978f517a6018a). > > ### Example > > .button { > -fx-background-color: dodgerblue; > } > > .button:hover { > -fx-background-color: red; > -fx-

Re: RFR: 8311895: CSS Transitions [v2]

On Mon, 31 Jul 2023 00:09:38 GMT, Michael Strauß wrote: >> Implementation of [CSS >> Transitions](https://gist.github.com/mstr2/c72f8c9faa87de14926978f517a6018a). >> >> ### Example >> >> .button { >> -fx-background-color: dodgerblue; >> } &g

Re: RFR: 8311895: CSS Transitions [v2]

> Implementation of [CSS > Transitions](https://gist.github.com/mstr2/c72f8c9faa87de14926978f517a6018a). > > ### Example > > .button { > -fx-background-color: dodgerblue; > } > > .button:hover { > -fx-background-color: red; > -fx-

Re: RFR: 8311895: CSS Transitions

On Tue, 16 Aug 2022 03:01:23 GMT, Michael Strauß wrote: > Implementation of [CSS > Transitions](https://gist.github.com/mstr2/c72f8c9faa87de14926978f517a6018a). > > ### Example > > .button { > -fx-background-color: dodgerblue; > } > > .button:hover { &

Re: CSS Transitions

inline On 7/24/2023 5:09 PM, Michael Strauß wrote: My comments below: On Tue, Jul 25, 2023 at 1:18 AM Kevin Rushforth wrote: This seems like it might be a useful feature, if enough applications would want to take advantage of it. If we proceed, I have a couple comments: * All of our existin

Re: CSS Transitions

> This seems like it might be a useful feature, if enough applications > would want to take advantage of it. I think this feature is mainly useful for style themes, because it allows creating subtle animations for state transitions (hover, click, etc). Applications will probably continue to use th

Re: RFR: 8311895: CSS Transitions

On Tue, 16 Aug 2022 03:01:23 GMT, Michael Strauß wrote: > Implementation of [CSS > Transitions](https://gist.github.com/mstr2/c72f8c9faa87de14926978f517a6018a). > > ### Example > > .button { > -fx-background-color: dodgerblue; > } > > .button:hover { &

RFR: 8311895: CSS Transitions

Implementation of [CSS Transitions](https://gist.github.com/mstr2/c72f8c9faa87de14926978f517a6018a). ### Example .button { -fx-background-color: dodgerblue; } .button:hover { -fx-background-color: red; -fx-scale-x: 1.1; -fx-scale-y: 1.1; transition: -fx-background-color

Re: CSS Transitions

My comments below: On Tue, Jul 25, 2023 at 1:18 AM Kevin Rushforth wrote: > > This seems like it might be a useful feature, if enough applications > would want to take advantage of it. > > If we proceed, I have a couple comments: > > * All of our existing CSS attributes use "-fx-" as a prefix. My

Re: CSS Transitions

This seems like it might be a useful feature, if enough applications would want to take advantage of it. If we proceed, I have a couple comments: * All of our existing CSS attributes use "-fx-" as a prefix. My preference would be to do that for transitions as well, absent a compelling reason

Aw: Re: CSS Transitions

I think this is a good feature to have in JavaFX, especially as it makes it much easier to animate the UI.This looks good to me API wise. Since you implemented this as in modern CSS, this is also very easy for people coming from the Web.-- Marius Am 17.07.23, 21:24 schrieb "Michael Strauß" :

Re: CSS Transitions

I'd love to see this feature in JavaFX. This would allow for much cleaner (and better reusable) implementations of modern-looking UI which I'd like to have for current and future JavaFX projects. In the current state of JavaFX, you'd usually need to roll your own custom control skins which is n

Re: CSS Transitions

Here's an updated summary of the proposed feature: https://gist.github.com/mstr2/c72f8c9faa87de14926978f517a6018a And here's the full implementation: https://github.com/openjdk/jfx/pull/870 I'm interested in hearing from you whether you think this is a useful feature and whether the proposed API

Re: CSS Transitions

gt; > Note that step-wise interpolators are only available for CSS > > Transitions, they are not exposed as new public API in the > > `javafx.animation` framework. The reason for this is that step-wise > > interpolators accept negative input values and can produce different >

Re: CSS Transitions

Just a few questions inline: On 11/07/2023 21:52, Michael Strauß wrote: Easing Functions CSS Transitions specifies the `transition-timing-function` sub-property to define easing functions (see CSS Easing Functions [4]). Here is a list of all easing functions available in CSS

CSS Transitions

I've previously proposed to add implicit CSS transitions to JavaFX. Compared to the previous proposal, this new and refined proposal is a "minimally invasive" version that requires almost no new API. The previous proposal did get some reactions on GitHub, and I hope that this n

Aw: CSS Transitions

: "openjfx-dev" Betreff: CSS Transitions JavaFX supports animations using the tools in the `javafx.animation` package, but it lacks an easy way of defining animations in stylesheets. This feature has often been requested, but is still missing [0] [1] [2]. While there are several ways to

CSS Transitions

presented in [2]), I think the best approach is to implement CSS Transitions [3] for JavaFX. CSS Transitions is an established and stable specification, and it is ubiquitous all over the web. I've prepared a PR that illustrates how that feature can look like in JavaFX: https://github.com/openjd