Re: [jfx21u] RFR: 8317370: JavaFX runtime version is wrong at runtime

2023-11-27 Thread Kevin Rushforth
On Wed, 22 Nov 2023 16:14:12 GMT, John Neffenger wrote: > The only thing that didn't get copied over with the original commit is the > updated copyright statement in the VersionInfo.java class: That's because the copyright year was updated separately and later as part of [JDK-8318714](https://

Re: [jfx21u] RFR: 8317370: JavaFX runtime version is wrong at runtime

2023-11-27 Thread Kevin Rushforth
On Tue, 21 Nov 2023 20:19:04 GMT, John Neffenger wrote: > Backport 16169240667876633895b27464eb90033abb6166 > > Please review this backport of openjdk/jfx#1253 to JavaFX 21. Please give me > a day or two to test it again before starting your review. The backport looks good and works as expecte

Re: [jfx21u] RFR: 8317370: JavaFX runtime version is wrong at runtime

2023-11-22 Thread John Neffenger
On Tue, 21 Nov 2023 20:19:04 GMT, John Neffenger wrote: > Backport 16169240667876633895b27464eb90033abb6166 > > Please review this backport of openjdk/jfx#1253 to JavaFX 21. Please give me > a day or two to test it again before starting your review. I ran the builds and unit tests on Linux, ma

[jfx21u] RFR: 8317370: JavaFX runtime version is wrong at runtime

2023-11-21 Thread John Neffenger
Backport 16169240667876633895b27464eb90033abb6166 Please review this backport of openjdk/jfx#1253 to JavaFX 21. Please give me a day or two to test it again before starting your review. - Commit messages: - Backport 16169240667876633895b27464eb90033abb6166 Changes: https://git.ope