On Wed, 18 Jun 2025 15:33:45 GMT, Alexander Zvegintsev
wrote:
> This changeset introduces an adapted version of [the OpenJDK
> fix](https://github.com/openjdk/jdk/commit/2dfbf41d2a3dbcd44f9ed9a58a1b0932d7536977)
> for mouse and keyboard interactions with Robot.
> More info abo
On Thu, 26 Jun 2025 14:18:53 GMT, Lukasz Kostyra wrote:
> These PipeWire declarations have been just moved here from the original
> header. Is this move necessary?
It is about clang 17 warning, it was
[fixed](https://github.com/openjdk/jdk/pull/23236) on the jdk side.
I am trying to keep the c
On Wed, 25 Jun 2025 12:21:36 GMT, Lukasz Kostyra wrote:
> I see most checks relate to Gnome and its version - what would be the
> behavior if we ran the tests on a different desktop env like KDE?
This question has already been raised on the OpenJDK PR. The short answer is
that it's an unsuppor
This changeset introduces an adapted version of [the OpenJDK
fix](https://github.com/openjdk/jdk/commit/2dfbf41d2a3dbcd44f9ed9a58a1b0932d7536977)
for mouse and keyboard interactions with Robot.
More info about the issue itself is available in the PR
[description](https://github.com/openjdk/jdk/p
On Fri, 14 Feb 2025 13:02:44 GMT, Alexander Zvegintsev
wrote:
> Hi all,
>
> This pull request contains a backport of commit
> [53fe8f1a](https://github.com/openjdk/jfx/commit/53fe8f1a03f7e5c386a3341315834751c17b8514)
> from the [openjdk/jfx](https://git.openjdk.org/jfx) repos
Hi all,
This pull request contains a backport of commit
[53fe8f1a](https://github.com/openjdk/jfx/commit/53fe8f1a03f7e5c386a3341315834751c17b8514)
from the [openjdk/jfx](https://git.openjdk.org/jfx) repository.
The commit being backported was authored by Alexander Zvegintsev on 14 Feb 2025
On Thu, 13 Feb 2025 11:54:01 GMT, Alexander Zvegintsev
wrote:
> This changeset updates the pipewire headers to the 1.3.81, and it is the same
> as for the [OpenJDK](https://github.com/openjdk/jdk/pull/23426)
>
> It contains the minimum set of required header files needed to b
This changeset updates the pipewire headers to the 1.3.81, and it is the same
as for the [OpenJDK](https://github.com/openjdk/jdk/pull/23426)
It contains the minimum set of required header files needed to build the JFX.
The updated headers are a direct copy from the
https://gitlab.freedesktop.o
On Tue, 10 Dec 2024 14:10:23 GMT, Alexander Zvegintsev
wrote:
> This PR enables several previously disabled test cases for Wayland, as the
> required fixes are already in the promoted build.
> ([JDK-8335469](https://bugs.openjdk.org/browse/JDK-8335469),
> [JDK-83
On Tue, 10 Dec 2024 14:49:34 GMT, Kevin Rushforth wrote:
>> This PR enables several previously disabled test cases for Wayland, as the
>> required fixes are already in the promoted build.
>> ([JDK-8335469](https://bugs.openjdk.org/browse/JDK-8335469),
>> [JDK-8335468](https://bugs.openjdk.org/
This PR enables several previously disabled test cases for Wayland, as the
required fixes are already in the promoted build.
([JDK-8335469](https://bugs.openjdk.org/browse/JDK-8335469),
[JDK-8335468](https://bugs.openjdk.org/browse/JDK-8335468))
-
Commit messages:
- check JDK vers
On Mon, 2 Dec 2024 11:25:14 GMT, Nir Lisker wrote:
> would you object to making Dimension an inner class of Rectangle?
I am fine with it.
-
PR Comment: https://git.openjdk.org/jfx/pull/1653#issuecomment-2511707325
On Fri, 29 Nov 2024 17:00:42 GMT, Nir Lisker wrote:
> A small refactoring of the Dimension classes.
>
> * `com.sun.javafx.geom.Dimension` was removed and its uses were replaced by
> `com.sun.javafx.geom.Dimension2D`.
> * `com.sun.javafx.geom.Dimension2D` became a record.
> * `javafx.geometry.Di
On Mon, 25 Nov 2024 13:36:35 GMT, Alexander Zvegintsev
wrote:
> Hi all,
>
> This pull request contains a backport of commit
> [001f292e](https://github.com/openjdk/jfx/commit/001f292e9f6f31e903e1219ffbc84432bae5824b)
> from the [openjdk/jfx](https://git.openjdk.org/jfx) repos
On Mon, 25 Nov 2024 19:25:36 GMT, Alexander Zvegintsev
wrote:
>> Hi all,
>>
>> This pull request contains a backport of commit
>> [001f292e](https://github.com/openjdk/jfx/commit/001f292e9f6f31e903e1219ffbc84432bae5824b)
>> from the [openjdk/jfx](https://g
> Hi all,
>
> This pull request contains a backport of commit
> [001f292e](https://github.com/openjdk/jfx/commit/001f292e9f6f31e903e1219ffbc84432bae5824b)
> from the [openjdk/jfx](https://git.openjdk.org/jfx) repository.
>
> The commit being backported was authored by Al
On Mon, 25 Nov 2024 14:29:50 GMT, Alexander Zvegintsev
wrote:
> Hi all,
>
> This pull request contains a backport of commit
> [0ee74e18](https://github.com/openjdk/jfx/commit/0ee74e185673fba03d490122d0560a181ebd6fb2)
> from the [openjdk/jfx](https://git.openjdk.org/jfx) repos
On Mon, 25 Nov 2024 15:50:40 GMT, Kevin Rushforth wrote:
> I presume you have run the tests? GHA builds aren't enabled for your repo, so
> I can't tell.
Only locally, the `SwingNodeJDialogTest` passes on X11, and skips on Wayland
-
PR Comment: https://git.openjdk.org/jfx23u/pull/3
`tests/system/src/test/java/test/robot/javafx/scene/SRGBTest.java`. So this
change is skipped now.
The commit being backported was authored by Alexander Zvegintsev on 15 Aug 2024
and was reviewed by Kevin Rushforth.
Thanks!
-
Commit messages:
- 8337827: [XWayland] Skip failing tests on
Hi all,
This pull request contains a backport of commit
[001f292e](https://github.com/openjdk/jfx/commit/001f292e9f6f31e903e1219ffbc84432bae5824b)
from the [openjdk/jfx](https://git.openjdk.org/jfx) repository.
The commit being backported was authored by Alexander Zvegintsev on 25 Nov 2024
On Fri, 15 Nov 2024 01:47:40 GMT, Alexander Zvegintsev
wrote:
> This is the FX counterpart of the
> [openjdk/jdk/pull/22131](https://github.com/openjdk/jdk/pull/22131) /
> `b.`(aka crash prevention part)
>
> It does not crash without the
> [openjdk/jdk/pull/22131](https://
t.java`
> and `tests/system/src/test/java/test/robot/javafx/scene/SRGBTest.java` are
> not enabled back.
> But if the JDK and JavaFX have the fixes, everything works fine.
> Testing in other different scenarios also looks good.
Alexander Zvegintsev has updated the pull request increment
On Wed, 20 Nov 2024 03:00:36 GMT, Alexander Zvegintsev
wrote:
>> This is the FX counterpart of the
>> [openjdk/jdk/pull/22131](https://github.com/openjdk/jdk/pull/22131) /
>> `b.`(aka crash prevention part)
>>
>> It does not crash without the
>> [openjd
On Sat, 16 Nov 2024 16:39:43 GMT, Kevin Rushforth wrote:
> I can't reproduce the crash without this fix on my system, but since it does
> happen on some systems, it does need to be fixed.
Just to be on the same page, it still crashes for me (at least on Ubuntu 22.04)
as expected for the follow
On Fri, 15 Nov 2024 17:47:34 GMT, Kevin Rushforth wrote:
>> Alexander Zvegintsev has updated the pull request incrementally with two
>> additional commits since the last revision:
>>
>> - test cleanup
>> - add missing copyright header
>
> tests/system/s
t.java`
> and `tests/system/src/test/java/test/robot/javafx/scene/SRGBTest.java` are
> not enabled back.
> But if the JDK and JavaFX have the fixes, everything works fine.
> Testing in other different scenarios also looks good.
Alexander Zvegintsev has updated the pull reque
On Fri, 15 Nov 2024 12:53:46 GMT, Kevin Rushforth wrote:
> Can you rerun it?
Sure, done
https://github.com/azvegint/jfx/actions/runs/11849042656
-
PR Comment: https://git.openjdk.org/jfx/pull/1639#issuecomment-2478894882
t.java`
> and `tests/system/src/test/java/test/robot/javafx/scene/SRGBTest.java` are
> not enabled back.
> But if the JDK and JavaFX have the fixes, everything works fine.
> Testing in other different scenarios also looks good.
Alexander Zvegintsev has updated the pull request incrementa
This is the FX counterpart of the
[openjdk/jdk/pull/22131](https://github.com/openjdk/jdk/pull/22131) / `b.`(aka
crash prevention part)
It does not crash without the
[openjdk/jdk/pull/22131](https://github.com/openjdk/jdk/pull/22131) / `a.` part.
The crash prevention part is the same for the
On Thu, 29 Aug 2024 15:56:59 GMT, Kevin Rushforth wrote:
>> A Swing / FX interop app will crash if an application creates a new AWT /
>> Swing window after calling Platform.exit. The root cause of the crash is
>> that AWT caches the JNI env pointer for the AppKit thread, and assumes that
>> it
On Wed, 14 Aug 2024 06:21:58 GMT, Alexander Zvegintsev
wrote:
> This changeset introduces the `Util.isOnWayland()` method and skips failing
> tests on Wayland.
>
> After that, all tests run on Wayland without failures.
This pull request has now been integrated.
Changeset: 0ee
This changeset introduces the `Util.isOnWayland()` method and skips failing
tests on Wayland.
After that, all tests run on Wayland without failures.
-
Commit messages:
- add javadoc
- 8337827: [XWayland] Skip failing tests on Wayland
Changes: https://git.openjdk.org/jfx/pull/1536
On Wed, 3 Jul 2024 17:50:03 GMT, Andy Goryachev wrote:
> added missing @Override annotations
Marked as reviewed by azvegint (Committer).
-
PR Review: https://git.openjdk.org/jfx/pull/1494#pullrequestreview-2158934205
On Wed, 26 Jun 2024 11:25:37 GMT, Alexander Zvegintsev
wrote:
> Most of the headful test failures on XWayland are due to screen capture is
> not working.
>
> Wayland, unlike X11, does not allow arbitrary applications to capture the
> screen contents directly.
> Inste
On Tue, 2 Jul 2024 15:36:59 GMT, Kevin Rushforth wrote:
>> Alexander Zvegintsev has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> fix the SwingNodeJDialogTest.testNodeRemovalBeforeShow test failure
>
> mo
deJDialogTest.testNodeRemovalBeforeShow` case is still failing.
>
> 3. https://bugs.openjdk.org/browse/JDK-8335469
>
> Internally the ScreenCast session keeps open for
> [2s](https://github.com/openjdk/jdk/blob/d457609f700bbb1fed233f1a04501c995852e5ac/src/java.desktop/unix/classe
On Tue, 2 Jul 2024 13:07:55 GMT, Alexander Zvegintsev
wrote:
>> Most of the headful test failures on XWayland are due to screen capture is
>> not working.
>>
>> Wayland, unlike X11, does not allow arbitrary applications to capture the
>> screen contents direct
deJDialogTest.testNodeRemovalBeforeShow` case is still failing.
>
> 3. https://bugs.openjdk.org/browse/JDK-8335469
>
> Internally the ScreenCast session keeps open for
> [2s](https://github.com/openjdk/jdk/blob/d457609f700bbb1fed233f1a04501c995852e5ac/src/java.desktop/unix/classe
On Fri, 28 Jun 2024 13:20:57 GMT, Kevin Rushforth wrote:
>>> If the SecurityException is not thrown, how does the caller of getRGBPixels
>>> knows that the result will not be correct because of the missing
>>> permission? (as opposed to being incorrect due to a failure)
>>
>> He won't know it.
On Fri, 28 Jun 2024 13:52:10 GMT, Kevin Rushforth wrote:
>> Johan makes a good point, so go ahead and add it back.
>
> Worth noting is that this `HEADLESS` check is just an assertion to verify
> that the build logic properly excludes the file from the build when building
> headless. It otherwis
> Internally the ScreenCast session keeps open for
> [2s](https://github.com/openjdk/jdk/blob/d457609f700bbb1fed233f1a04501c995852e5ac/src/java.desktop/unix/classes/sun/awt/screencast/ScreencastHelper.java#L62).
> This is to reduce overhead in case of frequent consecutive screen captures.
>
On Fri, 28 Jun 2024 13:54:54 GMT, Thiago Milczarek Sayao
wrote:
> Just of out curiosity, please don't mind it too much:
>
> Why the piperwire include files are included? Since the infraestucture should
> be present for it to work (pipewire is quite new and not present on older
> linux distrib
On Fri, 28 Jun 2024 09:44:03 GMT, Johan Vos wrote:
> If the SecurityException is not thrown, how does the caller of getRGBPixels
> knows that the result will not be correct because of the missing permission?
> (as opposed to being incorrect due to a failure)
He won't know it. An indirect resul
On Fri, 28 Jun 2024 07:04:18 GMT, Johan Vos wrote:
>> I don't have a strong opinion. This file is unchanged relative to the
>> original in AWT. The other three already have some changes, so I'd probably
>> lean toward removing it.
>
> With the headless platform that I started in the sandbox pro
On Wed, 26 Jun 2024 11:25:37 GMT, Alexander Zvegintsev
wrote:
> Most of the headful test failures on XWayland are due to screen capture is
> not working.
>
> Wayland, unlike X11, does not allow arbitrary applications to capture the
> screen contents directly.
> Inste
On Wed, 26 Jun 2024 20:14:26 GMT, Phil Race wrote:
>> Most of the headful test failures on XWayland are due to screen capture is
>> not working.
>>
>> Wayland, unlike X11, does not allow arbitrary applications to capture the
>> screen contents directly.
>> Instead, screen capture functionality
Most of the headful test failures on XWayland are due to screen capture is not
working.
Wayland, unlike X11, does not allow arbitrary applications to capture the
screen contents directly.
Instead, screen capture functionality is managed by the compositor, which can
enforce stricter controls and
On Thu, 27 Jun 2024 18:15:53 GMT, Kevin Rushforth wrote:
>> Most of the headful test failures on XWayland are due to screen capture is
>> not working.
>>
>> Wayland, unlike X11, does not allow arbitrary applications to capture the
>> screen contents directly.
>> Instead, screen capture functio
48 matches
Mail list logo
