On Fri, 28 Jun 2024 13:54:54 GMT, Thiago Milczarek Sayao <tsa...@openjdk.org> wrote:
> Just of out curiosity, please don't mind it too much: > > Why the piperwire include files are included? Since the infraestucture should > be present for it to work (pipewire is quite new and not present on older > linux distributions) a runtime check is needed anyways. > > What's the advantage of calling dbus functions directly and not use libportal? This is mostly a copy and paste of the OpenJDK code, which should be able to be built on fairly old Linux distributions (consider OpenJDK backports to earlier versions), and we didn't want to add any new external dependencies there. So with this changeset, we are just bringing tested code with minimal changes to JFX. ------------- PR Comment: https://git.openjdk.org/jfx/pull/1490#issuecomment-2197228454
