JavaFX 25 is in Rampdown Phase Two (RDP2)

2025-08-07 Thread Kevin Rushforth
To: JavaFX Developers As a reminder, JavaFX 25 is now in Rampdown Phase Two (RDP2). [1] P1-P2 bug fixes, and test or doc fixes of any priority, can be fixed during RDP2. Explicit approval is needed for all bug fixes and enhancements (except for doc and test fixes) to go in to the jfx25 branch

Re: [External] : Re: Focus delegation API

2025-08-07 Thread Michael Strauß
> The proposal (lifted from WPF) is to provide a mechanism which would allow a > Control to replace an event’s original target with itself. This is a low-cost > way of making the control appear to be a black box at the event level. It > would certainly have a lower cost than, say, trying to hide

Re: RFR: 8364825: Skip failing MenuDoubleShortcutTest [v2]

2025-08-07 Thread Kevin Rushforth
On Thu, 7 Aug 2025 17:45:40 GMT, Ziad El Midaoui wrote: >> Skipping failing `MenuDoubleShortcutTest#nonMacMenuBarComesBeforeScene()` > > Ziad El Midaoui has updated the pull request incrementally with one > additional commit since the last revision: > > Minor update to MenuDoubleShortcutTest

Re: RFR: 8364825: Skip failing MenuDoubleShortcutTest [v2]

2025-08-07 Thread Andy Goryachev
On Thu, 7 Aug 2025 17:45:40 GMT, Ziad El Midaoui wrote: >> Skipping failing `MenuDoubleShortcutTest#nonMacMenuBarComesBeforeScene()` > > Ziad El Midaoui has updated the pull request incrementally with one > additional commit since the last revision: > > Minor update to MenuDoubleShortcutTest

Re: RFR: 8364825: Skip failing MenuDoubleShortcutTest [v2]

2025-08-07 Thread Kevin Rushforth
On Thu, 7 Aug 2025 17:36:49 GMT, Ziad El Midaoui wrote: >> Also, this will skip the test on all platforms. That might be a reasonable >> thing to do, but if that's what you propose, then please change the title >> (in JBS and the PR) to drop the "on Linux" part. > > The test is skipped on Mac b

Re: RFR: 8364825: Skip failing MenuDoubleShortcutTest [v2]

2025-08-07 Thread Kevin Rushforth
On Thu, 7 Aug 2025 17:45:40 GMT, Ziad El Midaoui wrote: >> Skipping failing `MenuDoubleShortcutTest#nonMacMenuBarComesBeforeScene()` > > Ziad El Midaoui has updated the pull request incrementally with one > additional commit since the last revision: > > Minor update to MenuDoubleShortcutTest

Re: RFR: 8364825: Skip failing MenuDoubleShortcutTest [v2]

2025-08-07 Thread Ziad El Midaoui
> Skipping failing `MenuDoubleShortcutTest#nonMacMenuBarComesBeforeScene()` Ziad El Midaoui has updated the pull request incrementally with one additional commit since the last revision: Minor update to MenuDoubleShortcutTest - Changes: - all: https://git.openjdk.org/jfx/pull/1

Re: RFR: 8364825: Skip failing MenuDoubleShortcutTest [v2]

2025-08-07 Thread Ziad El Midaoui
On Thu, 7 Aug 2025 17:01:59 GMT, Kevin Rushforth wrote: >> tests/system/src/test/java/test/robot/javafx/scene/MenuDoubleShortcutTest.java >> line 108: >> >>> 106: // On platforms other than Mac the menu bar should process the >>> event >>> 107: // and the scene should not. >>> 108:

Re: RFR: 8364825: Skip failing MenuDoubleShortcutTest on Linux

2025-08-07 Thread Kevin Rushforth
On Thu, 7 Aug 2025 16:25:29 GMT, Andy Goryachev wrote: >> Skipping failing `MenuDoubleShortcutTest#nonMacMenuBarComesBeforeScene()` > > tests/system/src/test/java/test/robot/javafx/scene/MenuDoubleShortcutTest.java > line 108: > >> 106: // On platforms other than Mac the menu bar should pro

Re: RFR: 8364825: Skip failing MenuDoubleShortcutTest on Linux

2025-08-07 Thread Andy Goryachev
On Thu, 7 Aug 2025 16:07:05 GMT, Ziad El Midaoui wrote: > Skipping failing `MenuDoubleShortcutTest#nonMacMenuBarComesBeforeScene()` tests/system/src/test/java/test/robot/javafx/scene/MenuDoubleShortcutTest.java line 108: > 106: // On platforms other than Mac the menu bar should process the

RFR: 8364825: Skip failing MenuDoubleShortcutTest on Linux

2025-08-07 Thread Ziad El Midaoui
Skipping failing `MenuDoubleShortcutTest#nonMacMenuBarComesBeforeScene()` - Commit messages: - Disabled Test nonMacMenuBarComesBeforeScene() Changes: https://git.openjdk.org/jfx/pull/1867/files Webrev: https://webrevs.openjdk.org/?repo=jfx&pr=1867&range=00 Issue: https://bugs.op

Re: RFR: 8271024: Implement macOS Metal Rendering Pipeline [v22]

2025-08-07 Thread Kevin Rushforth
On Thu, 7 Aug 2025 15:34:52 GMT, Andy Goryachev wrote: > > How widespread are the cases of unused Java fields/methods/classes that are > > used in the native code? > > Probably a few cases. The main benefit is maintainability in the long run. WebKit is the main place where we do this. By conve

Re: [External] : Re: Focus delegation API

2025-08-07 Thread Martin Fox
> On Aug 6, 2025, at 3:54 PM, John Hendrikx wrote: > > > On 06/08/2025 18:06, Martin Fox wrote: >> >> The TextField of a ComboBox or Spinner is not just an artifact of its skin. >> They are both explicitly composite controls that contains a TextField >> inside. It’s part of the API. And if

Re: RFR: 8354943: [Linux] Simplify and update glass gtk backend: window sizing, positioning, and state management issues [v51]

2025-08-07 Thread Thiago Milczarek Sayao
On Thu, 7 Aug 2025 14:29:05 GMT, Thiago Milczarek Sayao wrote: >> This is a continuation to >> [JDK-8236651](https://bugs.openjdk.org/browse/JDK-8236651) and it aims to >> stabilize the linux glass gtk backend. >> >> This is a refactor of the Glass GTK implementation, primarily focused on >>

Anyone else seeing robot test failures on macOS?

2025-08-07 Thread Martin Fox
When I do a complete run of the robot tests there’s a small set that consistently fail. The same tests pass if I run them individually. I haven’t dug into this yet but it looks like mouse events are getting lost (DualWindowTest) and key events are getting garbled (KeyEventClosesStageTest). But

Re: RFR: 8271024: Implement macOS Metal Rendering Pipeline [v22]

2025-08-07 Thread Andy Goryachev
On Thu, 7 Aug 2025 15:26:22 GMT, Nir Lisker wrote: > How widespread are the cases of unused Java fields/methods/classes that are > used in the native code? Probably a few cases. The main benefit is maintainability in the long run. - PR Comment: https://git.openjdk.org/jfx/pull/18

Integrated: 8360886: Cmd + plus shortcut does not work reliably

2025-08-07 Thread Martin Fox
On Mon, 30 Jun 2025 16:58:00 GMT, Martin Fox wrote: > The Mac platform code figures out where characters are on the keyboard as the > user types. The character table is updated on every key press by calling a > registerKeyEvent: in GlassApplication. This character table is used to > resolve Ke

Re: RFR: 8360886: Cmd + plus shortcut does not work reliably [v2]

2025-08-07 Thread Martin Fox
On Mon, 14 Jul 2025 18:26:34 GMT, Martin Fox wrote: >> Martin Fox has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Reverted manual tests, added system test, changed check for fake >> performKeyEquivalent event. > > Heads up, I just submi

Integrated: 8355990: [macOS] Restoring a maximized stage does not update the window size

2025-08-07 Thread Martin Fox
On Tue, 29 Jul 2025 14:45:36 GMT, Martin Fox wrote: > This PR fixes numerous bugs in the handling of setMaximized() on macOS and > also cleans up some issues seen when the user changes the maximized state > manually. > > - After setMaximized(false) a notifyResize event was never sent so the wi

Re: RFR: 8271024: Implement macOS Metal Rendering Pipeline [v22]

2025-08-07 Thread Nir Lisker
On Thu, 7 Aug 2025 14:52:32 GMT, Andy Goryachev wrote: > I wish we introduced an annotation for that (native use). lgtm. How widespread are the cases of unused Java fields/methods/classes that are used in the native code? - PR Comment: https://git.openjdk.org/jfx/pull/1824#issueco

Re: RFR: 8271024: Implement macOS Metal Rendering Pipeline [v22]

2025-08-07 Thread Andy Goryachev
On Thu, 7 Aug 2025 05:01:51 GMT, Ambarish Rapte wrote: >> ### Description >> This is the implementation of new graphics rendering pipeline for JavaFX >> using Metal APIs on MacOS. >> We released two Early Access (EA) builds and have reached a stage where it >> is ready to be integrated. >> Defa

Re: RFR: 8360886: Cmd + plus shortcut does not work reliably [v2]

2025-08-07 Thread Kevin Rushforth
On Mon, 14 Jul 2025 18:26:34 GMT, Martin Fox wrote: >> Martin Fox has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Reverted manual tests, added system test, changed check for fake >> performKeyEquivalent event. > > Heads up, I just submi

Re: RFR: 8354943: [Linux] Simplify and update glass gtk backend: window sizing, positioning, and state management issues [v51]

2025-08-07 Thread Thiago Milczarek Sayao
> This is a continuation to > [JDK-8236651](https://bugs.openjdk.org/browse/JDK-8236651) and it aims to > stabilize the linux glass gtk backend. > > This is a refactor of the Glass GTK implementation, primarily focused on > window size, positioning, and state management to resolve numerous issu

Re: RFR: 8355990: [macOS] Restoring a maximized stage does not update the window size [v2]

2025-08-07 Thread Kevin Rushforth
On Thu, 31 Jul 2025 15:05:20 GMT, Martin Fox wrote: >> This PR fixes numerous bugs in the handling of setMaximized() on macOS and >> also cleans up some issues seen when the user changes the maximized state >> manually. >> >> - After setMaximized(false) a notifyResize event was never sent so t

Re: RFR: 8271024: Implement macOS Metal Rendering Pipeline [v22]

2025-08-07 Thread Kevin Rushforth
On Thu, 7 Aug 2025 05:01:51 GMT, Ambarish Rapte wrote: >> ### Description >> This is the implementation of new graphics rendering pipeline for JavaFX >> using Metal APIs on MacOS. >> We released two Early Access (EA) builds and have reached a stage where it >> is ready to be integrated. >> Defa

Re: RFR: 8271024: Implement macOS Metal Rendering Pipeline [v22]

2025-08-07 Thread Nir Lisker
On Thu, 7 Aug 2025 05:01:51 GMT, Ambarish Rapte wrote: >> ### Description >> This is the implementation of new graphics rendering pipeline for JavaFX >> using Metal APIs on MacOS. >> We released two Early Access (EA) builds and have reached a stage where it >> is ready to be integrated. >> Defa