Re: RFR: 8356652: Input field ignores custom input source characters [v2]

2025-05-19 Thread Marc Durdin
On Fri, 16 May 2025 22:25:20 GMT, Martin Fox wrote: >> Under the hood the Keyman input method appears as a US English keyboard >> layout. The characters attached to an NSEvent are always US English Roman >> even if the selected Keyman layout is, say, Hebrew or Dvorak. Keyman sends >> the corre

Re: Let's discuss JDK-8338952

2025-05-19 Thread PavelTurk
Andy, I think this is a good solution because it provides everything needed for sorting. Moreover, it complies with the generics of TableColumn. For example, var column = new TableColumn("First Name"); SortPolicy sortPolicy = ... column.setSortPolicy(sortPolicy); But don't you think the VALUE

Integrated: 8238435: [macOs] Remove use of CGEventTap

2025-05-19 Thread Martin Fox
On Sun, 18 May 2025 19:02:14 GMT, Martin Fox wrote: > The GlassTouches code for monitoring touch events was disabled years ago > because it uses a global event tap. As Apple tightened security this started > generating alerts. With the latest version of Xcode (16.3) this unused code > is trigg

Re: RFR: 8354943: [Linux] Simplify and update glass gtk backend: window sizing, positioning, and state management issues [v21]

2025-05-19 Thread Thiago Milczarek Sayao
On Sat, 17 May 2025 12:07:19 GMT, Thiago Milczarek Sayao wrote: >> This is a continuation to >> [JDK-8236651](https://bugs.openjdk.org/browse/JDK-8236651) and it aims to >> stabilize the linux glass gtk backend. >> >> >> Overall, it has been made more robust within its scope, particularly in

RFR: 8314482: TextFlow: TabStopPolicy

2025-05-19 Thread Andy Goryachev
# Tab Stop Policy Andy Goryachev ## Summary Introduce a `tabStopPolicy` property in the `TextFlow` class which, when set, overrides the existing `tabSize` value and provides consistent way of setting tab stops at the paragraph level, regardless of the individual text segments font [0]. ![S

Re: RFR: 8354986: Update to Visual Studio 2022 version 17.13.2 on Windows

2025-05-19 Thread Alexander Matveev
On Wed, 14 May 2025 23:20:42 GMT, Kevin Rushforth wrote: > This PR updates the compiler on Windows to Visual Studio 2022 17.13.2 (from > 17.6.5) to match JDK 25. > > I ran a full headless and headful test run, including building media and > WebKit. All tests pass. > > NOTE: There is a compati

Re: RFR: 8238435: [macOs] Remove use of CGEventTap

2025-05-19 Thread Kevin Rushforth
On Sun, 18 May 2025 19:02:14 GMT, Martin Fox wrote: > The GlassTouches code for monitoring touch events was disabled years ago > because it uses a global event tap. As Apple tightened security this started > generating alerts. With the latest version of Xcode (16.3) this unused code > is trigg

Re: Let's discuss JDK-8338952

2025-05-19 Thread Andy Goryachev
One possible solution would be to deprecate the comparator property (not for removal, keep it for backward compatibility), and add a new property 'sortPolicy' which will use an interface that can be evolved, as opposed to a naive callback. public interface SortPolicy { public int compare(IT

Re: CodeArea: how to convert offset to TextPos?

2025-05-19 Thread Andy Goryachev
A good question! In the RichTextArea, it generally depends on the model. The default implementation, both in RichTextArea and CodeArea, the plaintext format handler uses "line.separator" system property (PlainTextFormatHandler:72). That is, both will emit \r\n line separators in Windows, \n e

Re: RFR: 8357157: Exception thrown from AnimationTimer freezes application [v2]

2025-05-19 Thread Andy Goryachev
On Mon, 19 May 2025 18:05:39 GMT, Michael Strauß wrote: >> 100 still looks excessive to me - it's unlikely that we'll have two >> different scenarios when this happens, so most of the time the log will have >> 100 identical traces. >> >> I mean, one is probably enough, we could have 2 or 4 jus

Re: RFR: 8357157: Exception thrown from AnimationTimer freezes application [v3]

2025-05-19 Thread Andy Goryachev
On Sat, 17 May 2025 12:24:46 GMT, Michael Strauß wrote: >> When an exception is thrown from `AnimationTimer::handle`, the JavaFX >> application freezes. The reason is that the user exception will bubble up >> into framework code, preventing the normal operation of JavaFX. >> >> The following p

Re: RFR: 8357157: Exception thrown from AnimationTimer freezes application [v2]

2025-05-19 Thread Michael Strauß
On Mon, 19 May 2025 15:30:17 GMT, Andy Goryachev wrote: >> I've removed the system property, so there's a hard-coded limit of 100 >> exceptions now. > > 100 still looks excessive to me - it's unlikely that we'll have two different > scenarios when this happens, so most of the time the log will

RFR: 8354986: Update to Visual Studio 2022 version 17.13.2 on Windows

2025-05-19 Thread Kevin Rushforth
This PR updates the compiler on Windows to Visual Studio 2022 17.13.2 (from 17.6.5) to match JDK 25. I ran a full headless and headful test run, including building media and WebKit. All tests pass. NOTE: There is a compatibility issue, introduced in VS 2022 17.10, that is seen when compiling w

Re: RFR: 8354986: Update to Visual Studio 2022 version 17.13.2 on Windows

2025-05-19 Thread Kevin Rushforth
On Wed, 14 May 2025 23:20:42 GMT, Kevin Rushforth wrote: > This PR updates the compiler on Windows to Visual Studio 2022 17.13.2 (from > 17.6.5) to match JDK 25. > > I ran a full headless and headful test run, including building media and > WebKit. All tests pass. > > NOTE: There is a compati

Re: RFR: 8355740: Update to Xcode 15.4 on macOS

2025-05-19 Thread Kevin Rushforth
On Mon, 28 Apr 2025 18:41:09 GMT, Kevin Rushforth wrote: > This PR updates the compiler on macOS to Xcode 15.4 (from 14.3.1) to match > JDK 25. > > I ran a full headless and headful test run, including building media and > WebKit. No issues were found. > > NOTE: Xcode 15.4 requires macOS 14 S

RFR: 8355740: Update to Xcode 15.4 on macOS

2025-05-19 Thread Kevin Rushforth
This PR updates the compiler on macOS to Xcode 15.4 (from 14.3.1) to match JDK 25. I ran a full headless and headful test run, including building media and WebKit. No issues were found. NOTE: Xcode 15.4 requires macOS 14 Sonoma to build (although it is known to build on macOS 13, which might b

Re: RFR: 8357157: Exception thrown from AnimationTimer freezes application [v2]

2025-05-19 Thread Andy Goryachev
On Sat, 17 May 2025 12:21:17 GMT, Michael Strauß wrote: >> On the other hand, AnimationTimer is a public API that allows for arbitrary >> code execution, which always has the potential to fail for any number of >> reasons (think of calling an unstable API from the timer callback). We can’t >>

Re: RFR: 8238435: [macOs] Remove use of CGEventTap

2025-05-19 Thread Andy Goryachev
On Sun, 18 May 2025 19:02:14 GMT, Martin Fox wrote: > The GlassTouches code for monitoring touch events was disabled years ago > because it uses a global event tap. As Apple tightened security this started > generating alerts. With the latest version of Xcode (16.3) this unused code > is trigg

Re: RFR: 8342530: Specifying "@Nx" scaling level in ImageStorage should only load that specific level [v3]

2025-05-19 Thread Michael Strauß
On Mon, 19 May 2025 07:06:38 GMT, Lukasz Kostyra wrote: >> This follow-up change finishes the earlier changes to >> `ImageStorage.loadAll()` and adds support for loading specific scale >> requested in the input. >> >> `loadAll()` will now first check if the input path ends with a scaling level

Re: [External] : Re: Headless Platform module?

2025-05-19 Thread Kevin Rushforth
I believe the situation is maybe a bit less complex though, because the new headless platform does not depend on Monocle. I see it as a replacement for the Monocle Headless sub-platform, but it has no compile-time nor run-time dependencies on Monocle. Oh, that does simplify things a fair bit

Integrated: 8342530: Specifying "@Nx" scaling level in ImageStorage should only load that specific level

2025-05-19 Thread Lukasz Kostyra
On Thu, 15 May 2025 11:27:21 GMT, Lukasz Kostyra wrote: > This follow-up change finishes the earlier changes to > `ImageStorage.loadAll()` and adds support for loading specific scale > requested in the input. > > `loadAll()` will now first check if the input path ends with a scaling level > s

Re: RFR: 8342530: Specifying "@Nx" scaling level in ImageStorage should only load that specific level [v3]

2025-05-19 Thread Lukasz Kostyra
On Mon, 19 May 2025 07:06:38 GMT, Lukasz Kostyra wrote: >> This follow-up change finishes the earlier changes to >> `ImageStorage.loadAll()` and adds support for loading specific scale >> requested in the input. >> >> `loadAll()` will now first check if the input path ends with a scaling level

Re: RFR: 8356652: Input field ignores custom input source characters [v2]

2025-05-19 Thread Andy Goryachev
On Fri, 16 May 2025 22:25:20 GMT, Martin Fox wrote: >> Under the hood the Keyman input method appears as a US English keyboard >> layout. The characters attached to an NSEvent are always US English Roman >> even if the selected Keyman layout is, say, Hebrew or Dvorak. Keyman sends >> the corre

Re: RFR: 8342530: Specifying "@Nx" scaling level in ImageStorage should only load that specific level [v3]

2025-05-19 Thread Kevin Rushforth
On Mon, 19 May 2025 07:06:38 GMT, Lukasz Kostyra wrote: >> This follow-up change finishes the earlier changes to >> `ImageStorage.loadAll()` and adds support for loading specific scale >> requested in the input. >> >> `loadAll()` will now first check if the input path ends with a scaling level

Re: RFR: 8238435: [macOs] Remove use of CGEventTap

2025-05-19 Thread Kevin Rushforth
On Sun, 18 May 2025 19:02:14 GMT, Martin Fox wrote: > The GlassTouches code for monitoring touch events was disabled years ago > because it uses a global event tap. As Apple tightened security this started > generating alerts. With the latest version of Xcode (16.3) this unused code > is trigg

Re: RFR: 8356690: Update JUnit to 5.12.2

2025-05-19 Thread Kevin Rushforth
On Sat, 10 May 2025 23:41:44 GMT, Marius Hanl wrote: > This PR bumps the JUnit version to 5.12.2. > Also removed 2 now unused variables since I phased out the JUnit Vintage > Engine + Hamcrest. > > Changelog: > https://junit.org/junit5/docs/current/release-notes/index.html#release-notes-5.12.2

Re: RFR: 8342530: Specifying "@Nx" scaling level in ImageStorage should only load that specific level [v3]

2025-05-19 Thread John Hendrikx
On Mon, 19 May 2025 07:06:38 GMT, Lukasz Kostyra wrote: >> This follow-up change finishes the earlier changes to >> `ImageStorage.loadAll()` and adds support for loading specific scale >> requested in the input. >> >> `loadAll()` will now first check if the input path ends with a scaling level

Re: Headless Platform module?

2025-05-19 Thread Craig Raw
Hi Johan, Thanks for working on this - count me as another developer who would love to see this part of a non-sandbox build of OpenJFX. > It is clear that a javafx.graphics module for MacOS should not contain code for Windows, but should it contain code for Headless? I would expect the answer to

Re: Headless Platform module?

2025-05-19 Thread Johan Vos
Hi Kevin, Thanks for the feedback and the valid questions. I believe the situation is maybe a bit less complex though, because the new headless platform does not depend on Monocle. I see it as a replacement for the Monocle Headless sub-platform, but it has no compile-time nor run-time dependencies

Let's discuss JDK-8338952

2025-05-19 Thread PavelTurk
About six months ago, I opened JDK-8338952 with a proposal to add an item comparator to (Tree)TableView. The reason for this issue is that when using non-standard sorting — for example, when there is a "Total" row in the table — the standard API becomes insufficient. One has to reinvent the wh

Re: RFR: 8342530: Specifying "@Nx" scaling level in ImageStorage should only load that specific level [v3]

2025-05-19 Thread Lukasz Kostyra
> This follow-up change finishes the earlier changes to > `ImageStorage.loadAll()` and adds support for loading specific scale > requested in the input. > > `loadAll()` will now first check if the input path ends with a scaling level > specified, and if that is the case it will attempt creating