On Thu, 15 May 2025 20:18:04 GMT, John Hendrikx wrote:
>> modules/javafx.graphics/src/main/java/com/sun/javafx/iio/common/ImageTools.java
>> line 166:
>>
>>> 164: return true;
>>> 165: }
>>> 166:
>>
>> 1. Is looking for a slash going to be compatible on all platforms? Where is
>
On Wed, 14 May 2025 15:31:46 GMT, Martin Fox wrote:
> Under the hood the Keyman input method appears as a US English keyboard
> layout. The characters attached to an NSEvent are always US English Roman
> even if the selected Keyman layout is, say, Hebrew or Dvorak. Keyman sends
> the correct H
On Thu, 15 May 2025 21:11:55 GMT, Phil Race wrote:
> Most of it wasn't really directed at you .. more at Kevin :-)
Those are good questions as to how we might need to evolve this if and when
JavaFX adds desktop-like APIs. We might, indeed, want some sort of "forward
these events to the other t
On Thu, 15 May 2025 22:57:08 GMT, Steven Loomis wrote:
>>> Do you think it's a bug in keyman or our code? I head the beep (correctly)
>>> but then n appears, despite the keyman onscreen keyboard showing an empty
>>> key. If it is our code, should there be some additional logic?
>>
>> Keyman is
On Thu, 15 May 2025 22:48:51 GMT, Martin Fox wrote:
>>> The N key in the Himyarit Musnad layout shouldn't generate a character
>>> (just a beep)
>>
>> Do you think it's a bug in keyman or our code? I head the beep (correctly)
>> but then n appears, despite the keyman onscreen keyboard showing
On Thu, 15 May 2025 22:25:51 GMT, Andy Goryachev wrote:
> Do you think it's a bug in keyman or our code? I head the beep (correctly)
> but then n appears, despite the keyman onscreen keyboard showing an empty
> key. If it is our code, should there be some additional logic?
Keyman is definitely
On Wed, 2 Apr 2025 14:06:58 GMT, Pabulaner IV wrote:
> When trying to register an open URI handler when using JavaFX with a native
> menu, this task fails on Mac.
> Either the native menu is not shown or the URIs are not received.
>
> This pull request fixes this issue if AWT is registered afte
On Wed, 14 May 2025 15:31:46 GMT, Martin Fox wrote:
> Under the hood the Keyman input method appears as a US English keyboard
> layout. The characters attached to an NSEvent are always US English Roman
> even if the selected Keyman layout is, say, Hebrew or Dvorak. Keyman sends
> the correct H
On Thu, 15 May 2025 19:04:26 GMT, Martin Fox wrote:
> The N key in the Himyarit Musnad layout shouldn't generate a character (just
> a beep)
Do you think it's a bug in keyman or our code? I head the beep (correctly) but
then n appears, despite the keyman onscreen keyboard showing an empty key
On Wed, 7 May 2025 16:41:37 GMT, Pabulaner IV wrote:
>> When trying to register an open URI handler when using JavaFX with a native
>> menu, this task fails on Mac.
>> Either the native menu is not shown or the URIs are not received.
>>
>> This pull request fixes this issue if AWT is registered
On Thu, 15 May 2025 20:43:00 GMT, John Hendrikx wrote:
>> I don't think that there's a perfect way to solve this. Yes, this can
>> theoretically happen, and then you'll see a visual glitch. I can imagine
>> that this might also be the reason why Windows shows a full-screen popup
>> when you sw
On Wed, 7 May 2025 16:41:37 GMT, Pabulaner IV wrote:
>> When trying to register an open URI handler when using JavaFX with a native
>> menu, this task fails on Mac.
>> Either the native menu is not shown or the URIs are not received.
>>
>> This pull request fixes this issue if AWT is registered
On Thu, 15 May 2025 20:32:57 GMT, Pabulaner IV wrote:
> Interesting feedback.
Most of it wasn't really directed at you .. more at Kevin :-)
The main question I had for you was about did it ever really work and I guess
you aren't sure.
> I don't understand Your last point. If no event handler i
On Thu, 15 May 2025 20:25:37 GMT, John Hendrikx wrote:
>> A single user-facing setting change should only result in a single change
>> notification in JavaFX, as that's what developers would intuitively expect.
>> I'm planning to add support for CSS system colors soon, which basically
>> expos
On Thu, 15 May 2025 20:10:53 GMT, John Hendrikx wrote:
>> This follow-up change finishes the earlier changes to
>> `ImageStorage.loadAll()` and adds support for loading specific scale
>> requested in the input.
>>
>> `loadAll()` will now first check if the input path ends with a scaling level
On Thu, 15 May 2025 20:34:21 GMT, Michael Strauß wrote:
>> Are you sure a delay is a good way to solve this? It won't guarantee that
>> no inconsistent states will be observed (what if Windows is slower, or a
>> change is reverted within the delay period -- you may still see "half"
>> changes
On Thu, 15 May 2025 19:16:03 GMT, Michael Strauß wrote:
> I am not comfortable with this change, as it falls under application
> requirements.
>
> The function of the JavaFX platform is to communicate the OS events as
> faithfully as it can, in my opinion
The function of JavaFX is to abstract
On Wed, 7 May 2025 16:41:37 GMT, Pabulaner IV wrote:
>> When trying to register an open URI handler when using JavaFX with a native
>> menu, this task fails on Mac.
>> Either the native menu is not shown or the URIs are not received.
>>
>> This pull request fixes this issue if AWT is registered
On Thu, 15 May 2025 18:50:20 GMT, Michael Strauß wrote:
>> If it takes that long to update all the colors, maybe we should not add
>> complexity to this subsystem and just send the events as they come?
>>
>> What exactly is the problem the user experiences right now?
>
> A single user-facing se
On Wed, 7 May 2025 16:41:37 GMT, Pabulaner IV wrote:
>> When trying to register an open URI handler when using JavaFX with a native
>> menu, this task fails on Mac.
>> Either the native menu is not shown or the URIs are not received.
>>
>> This pull request fixes this issue if AWT is registered
On Thu, 15 May 2025 11:27:21 GMT, Lukasz Kostyra wrote:
> This follow-up change finishes the earlier changes to
> `ImageStorage.loadAll()` and adds support for loading specific scale
> requested in the input.
>
> `loadAll()` will now first check if the input path ends with a scaling level
> s
On Thu, 15 May 2025 18:56:14 GMT, Michael Strauß wrote:
>> Some platform preference changes can trigger the emission of multiple
>> notifications. For example, when switching from a high-contrast theme on
>> Windows to the regular theme, the following notifications are emitted (log
>> can be v
On Thu, 15 May 2025 19:00:01 GMT, Andy Goryachev wrote:
> I am not comfortable with this change, as it falls under application
> requirements.
>
> The function of the JavaFX platform is to communicate the OS events as
> faithfully as it can, in my opinion. If the application requirements call
On Wed, 14 May 2025 15:31:46 GMT, Martin Fox wrote:
> Under the hood the Keyman input method appears as a US English keyboard
> layout. The characters attached to an NSEvent are always US English Roman
> even if the selected Keyman layout is, say, Hebrew or Dvorak. Keyman sends
> the correct H
On Wed, 14 May 2025 15:31:46 GMT, Martin Fox wrote:
> Under the hood the Keyman input method appears as a US English keyboard
> layout. The characters attached to an NSEvent are always US English Roman
> even if the selected Keyman layout is, say, Hebrew or Dvorak. Keyman sends
> the correct H
On Thu, 15 May 2025 18:56:14 GMT, Michael Strauß wrote:
>> Some platform preference changes can trigger the emission of multiple
>> notifications. For example, when switching from a high-contrast theme on
>> Windows to the regular theme, the following notifications are emitted (log
>> can be v
> Some platform preference changes can trigger the emission of multiple
> notifications. For example, when switching from a high-contrast theme on
> Windows to the regular theme, the following notifications are emitted (log
> can be viewed in `PlatformPreferencesChangedTest`):
>
>
> changed:
>
On Thu, 15 May 2025 18:35:47 GMT, Andy Goryachev wrote:
>> Quite a lot, Windows takes around 1-2 seconds to change to and from a
>> high-contrast theme (there's even a full-frame wait screen that pops up).
>> The suggested delay of 1 second works reliably on my machine.
>
> If it takes that lon
On Thu, 15 May 2025 18:28:59 GMT, Michael Strauß wrote:
>> modules/javafx.graphics/src/main/native-glass/win/PlatformSupport.h line 75:
>>
>>> 73: * Suggested aggregation delay for changes that come in over a
>>> period of time.
>>> 74: */
>>> 75: static constexpr int SUGGESTED_DE
On Thu, 15 May 2025 18:11:17 GMT, Andy Goryachev wrote:
>> Some platform preference changes can trigger the emission of multiple
>> notifications. For example, when switching from a high-contrast theme on
>> Windows to the regular theme, the following notifications are emitted (log
>> can be v
On Thu, 15 May 2025 18:13:35 GMT, Andy Goryachev wrote:
>> Some platform preference changes can trigger the emission of multiple
>> notifications. For example, when switching from a high-contrast theme on
>> Windows to the regular theme, the following notifications are emitted (log
>> can be v
On Thu, 15 May 2025 17:50:50 GMT, Michael Strauß wrote:
> Some platform preference changes can trigger the emission of multiple
> notifications. For example, when switching from a high-contrast theme on
> Windows to the regular theme, the following notifications are emitted (log
> can be viewe
Some platform preference changes can trigger the emission of multiple
notifications. For example, when switching from a high-contrast theme on
Windows to the regular theme, the following notifications are emitted (log can
be viewed in `PlatformPreferencesChangedTest`):
changed:
Windows
On Thu, 15 May 2025 11:27:21 GMT, Lukasz Kostyra wrote:
> This follow-up change finishes the earlier changes to
> `ImageStorage.loadAll()` and adds support for loading specific scale
> requested in the input.
>
> `loadAll()` will now first check if the input path ends with a scaling level
> s
On Wed, 14 May 2025 15:31:46 GMT, Martin Fox wrote:
> Under the hood the Keyman input method appears as a US English keyboard
> layout. The characters attached to an NSEvent are always US English Roman
> even if the selected Keyman layout is, say, Hebrew or Dvorak. Keyman sends
> the correct H
On Thu, 15 May 2025 17:26:39 GMT, Alexander Zuev wrote:
>> Noticed a bit of a problem.
>>
>> To reproduce, install Himyarit Musnad keyboard
>> https://keyman.com/keyboards/himyarit_musnad
>>
>> typing 'h' causes this character to appear: 𐩱
>> typing 'n' followed by 'h' generates garbage input
On Thu, 15 May 2025 15:55:41 GMT, Andy Goryachev wrote:
> typing 'h' causes this character to appear: 𐩱 typing 'n' followed by 'h'
> generates garbage input rather than expected 𐩱:
The same happens without the fix. For some reason events for the keys not
mapped on the active keyman keyboard st
On Wed, 14 May 2025 23:00:29 GMT, Michael Strauß wrote:
> The platform preferences API does not pick up the correct `UIColor` values
> when changing from a high-contrast Windows theme to another high-contrast
> theme.
>
> The reason is that the implementation incorrectly assumes that changing
On Wed, 7 May 2025 16:41:37 GMT, Pabulaner IV wrote:
>> When trying to register an open URI handler when using JavaFX with a native
>> menu, this task fails on Mac.
>> Either the native menu is not shown or the URIs are not received.
>>
>> This pull request fixes this issue if AWT is registered
On Wed, 14 May 2025 15:31:46 GMT, Martin Fox wrote:
> Under the hood the Keyman input method appears as a US English keyboard
> layout. The characters attached to an NSEvent are always US English Roman
> even if the selected Keyman layout is, say, Hebrew or Dvorak. Keyman sends
> the correct H
On Wed, 14 May 2025 23:00:29 GMT, Michael Strauß wrote:
> The platform preferences API does not pick up the correct `UIColor` values
> when changing from a high-contrast Windows theme to another high-contrast
> theme.
>
> The reason is that the implementation incorrectly assumes that changing
On Wed, 7 May 2025 16:41:37 GMT, Pabulaner IV wrote:
>> When trying to register an open URI handler when using JavaFX with a native
>> menu, this task fails on Mac.
>> Either the native menu is not shown or the URIs are not received.
>>
>> This pull request fixes this issue if AWT is registered
On Wed, 14 May 2025 15:31:46 GMT, Martin Fox wrote:
> Under the hood the Keyman input method appears as a US English keyboard
> layout. The characters attached to an NSEvent are always US English Roman
> even if the selected Keyman layout is, say, Hebrew or Dvorak. Keyman sends
> the correct H
On Thu, 15 May 2025 07:07:07 GMT, Ambarish Rapte wrote:
> Would it be possible to avoid re-layout of the cells that are after the Cell
> with a disclosureNode ?
This is actually what is happening, when we scroll down and find a TreeCell
that has a disclosure node this is when the condition `di
This follow-up change finishes the earlier changes to `ImageStorage.loadAll()`
and adds support for loading specific scale requested in the input.
`loadAll()` will now first check if the input path ends with a scaling level
specified, and if that is the case it will attempt creating a Stream. If
On Wed, 14 May 2025 23:00:29 GMT, Michael Strauß wrote:
> The platform preferences API does not pick up the correct `UIColor` values
> when changing from a high-contrast Windows theme to another high-contrast
> theme.
>
> The reason is that the implementation incorrectly assumes that changing
On Wed, 14 May 2025 18:26:23 GMT, Ziad El Midaoui
wrote:
>> this is the expected behavior though, right?
>>
>> what we **don't** want is the flicker - when the re-layout is needed but
>> happens in another pulse. When e.g. scrollbars need to appear/disappear it
>> may even lead to flicker th
47 matches
Mail list logo