On Mon, 28 Apr 2025 17:47:50 GMT, Martin Fox wrote:
> On macOS the system animates the transition into and out of fullscreen and
> this animation runs asynchronously. JavaFX tries to make the setFullScreen
> call appear synchronous by running a nested event loop while the transition
> is going
On Wed, 30 Apr 2025 17:52:01 GMT, Martin Fox wrote:
> macOS will allow any window to enter fullscreen mode but won't expand the
> window's size if the resizable bit isn't set in the window's style mask. For
> undecorated stages the code has to set this bit before entering fullscreen
> and rest
On Wed, 5 Feb 2025 21:21:09 GMT, Andy Goryachev wrote:
>> modules/javafx.graphics/src/main/java/javafx/scene/text/LayoutInfo.java line
>> 91:
>>
>>> 89: * @return the immutable list of {@code Rectangle2D} objects
>>> 90: */
>>> 91: public abstract List selectionShape(int start, in
The issue was happening because `-fx-highlight-text-fill` was set to white , so
when the background color is bright (>60% brightness ) the text is not visible
, the solution is to change the value to be dynamically set depending on the
level of brightness of the background this is done by
`-fx-
On Thu, 1 May 2025 13:54:49 GMT, Kevin Rushforth wrote:
> I will check whether this is the case by trying out HelloFXCanvas after first
> setting that variable. If so, then the fix for
> [JDK-8340378](https://bugs.openjdk.org/browse/JDK-8340378) will be to set
> that env variable from HelloFXC
On Mon, 7 Apr 2025 19:37:27 GMT, Andy Goryachev wrote:
>> Please refer to
>>
>> https://github.com/andy-goryachev-oracle/Test/blob/main/doc/Text/LayoutInfo.md
>>
>> The RichTextArea control
>> ([JDK-8301121](https://bugs.openjdk.org/browse/JDK-8301121)), or any custom
>> control that needs no
On Fri, 29 Nov 2024 17:00:42 GMT, Nir Lisker wrote:
> A small refactoring of the Dimension classes.
>
> * `com.sun.javafx.geom.Dimension` was removed and its uses were replaced by
> `com.sun.javafx.geom.Dimension2D`.
> * `com.sun.javafx.geom.Dimension2D` became a record.
> * `javafx.geometry.Di
On Thu, 1 May 2025 19:36:51 GMT, Michael Strauß wrote:
>> what's a "tidy" and is it a part of our build/validation?
>
> The closing `` tag is not required in HTML, and Javadoc doesn't seem to
> object. Is this a requirement of another tool? We're using `` without a
> closing tag in many places
On Fri, 11 Apr 2025 15:00:20 GMT, Andy Goryachev wrote:
>> modules/javafx.graphics/src/main/java/javafx/scene/text/TextLineInfo.java
>> line 36:
>>
>>> 34: * @param bounds the bounds of the text line, in local coordinates:
>>> 35: *
>>> 36: *
>>
>> We usually indent with 4 spaces.
>
> i
On Thu, 1 May 2025 15:50:22 GMT, Kevin Rushforth wrote:
>> in this economy, spaces are expensive ;-)
>
> More importantly, you need ` tags after each item. As it is, I doubt it
> would pass "tidy".
what's a "tidy" and is it a part of our build/validation?
-
PR Review Comment: http
On Thu, 1 May 2025 19:20:07 GMT, Andy Goryachev wrote:
>> More importantly, you need ` tags after each item. As it is, I doubt
>> it would pass "tidy".
>
> what's a "tidy" and is it a part of our build/validation?
The closing `` tag is not required in HTML, and Javadoc doesn't seem to
object.
On Mon, 7 Apr 2025 19:37:27 GMT, Andy Goryachev wrote:
>> Please refer to
>>
>> https://github.com/andy-goryachev-oracle/Test/blob/main/doc/Text/LayoutInfo.md
>>
>> The RichTextArea control
>> ([JDK-8301121](https://bugs.openjdk.org/browse/JDK-8301121)), or any custom
>> control that needs no
On Mon, 7 Apr 2025 19:14:40 GMT, Michael Strauß wrote:
>> `TextLineInfo` is a record, I don't want to add duplicate getXXX() aliases
>> there.
>>
>> The other (in `LayoutInfo`) are modeled after `Text`/`TextFlow` (e.g.
>> `underlineShape()`), I have no problem with any of these. I don't think
On Thu, 1 May 2025 18:13:03 GMT, Kevin Rushforth wrote:
>> Good point. The word 'shape' might be confusing, although it is still
>> correct in human terms (it is a shape, after all). I think it's ok, but we
>> could use the word "geometry" for these methods `selectionGeometry` /
>> `strikeTh
On Wed, 5 Feb 2025 21:18:20 GMT, Andy Goryachev wrote:
>> modules/javafx.graphics/src/main/java/javafx/scene/text/LayoutInfo.java line
>> 91:
>>
>>> 89: * @return the immutable list of {@code Rectangle2D} objects
>>> 90: */
>>> 91: public abstract List selectionShape(int start, in
This API is designed specifically not to confuse - there is no "text" property
in RichTextArea, cannot be. There is the "model" property, and the
corresponding setModel(). It is different with the CodeArea because the
CodeModel does operate with (decorated) plain text.
Additionally, the end r
It would be easy enough to add one as a convenience method, if it was
deemed useful enough. Andy can comment further.
-- Kevin
On 5/1/2025 10:41 AM, PavelTurk wrote:
To be honest, I think this will create problems when working with the
RichTextArea API.
Why? Because every developer will intu
To be honest, I think this will create problems when working with the
RichTextArea API.
Why? Because every developer will intuitively look for setText. For example,
TextArea
—https://docs.oracle.com/javase/8/javafx/api/javafx/scene/control/TextArea.html
—
has setText. CodeArea has setText. But
Note that there is an easy way to set plain text if you are using a
writable model:
rta.clear();
rta.appendText(String text);
-- Kevin
On 5/1/2025 7:55 AM, Andy Goryachev wrote:
Intentionally: the CodeArea model contains plain text, while in the
RichTextArea the content depends on the mode
On Tue, 29 Apr 2025 16:40:01 GMT, Martin Fox wrote:
> > * Will there be any problem one of the deferred Runnables causes an
> > exitFullScreen (e.g., on a different Stage in a dual screen case)? This
> > might be worth testing.
>
> Could you provide more details on what you want tested? I'm no
On Wed, 30 Apr 2025 17:52:01 GMT, Martin Fox wrote:
> macOS will allow any window to enter fullscreen mode but won't expand the
> window's size if the resizable bit isn't set in the window's style mask. For
> undecorated stages the code has to set this bit before entering fullscreen
> and rest
On Wed, 30 Apr 2025 23:34:06 GMT, Martin Fox wrote:
>> On macOS the system animates the transition into and out of fullscreen and
>> this animation runs asynchronously. JavaFX tries to make the setFullScreen
>> call appear synchronous by running a nested event loop while the transition
>> is g
> This is a continuation to
> [JDK-8236651](https://bugs.openjdk.org/browse/JDK-8236651) and it aims to
> stabilize the linux glass gtk backend.
>
>
> Overall, it has been made more robust within its scope, particularly in terms
> of sizing, positioning, and state management.
>
> List of chan
On Wed, 30 Apr 2025 21:53:38 GMT, Marius Hanl wrote:
> I setup an Ubuntu 24.04.2 LTS inside WSL, did export GDK_BACKEND=x11
> (otherwise I always got a crash).
Interesting. The crash is likely due to
[JDK-8340378](https://bugs.openjdk.org/browse/JDK-8340378). JavaFX glass calls
`putenv("GDK_B
Intentionally: the CodeArea model contains plain text, while in the
RichTextArea the content depends on the model. It may not contain anything and
be generated on the fly.
-andy
From: openjfx-dev on behalf of PavelTurk
Date: Thursday, May 1, 2025 at 05:40
To: openjfx-dev@openjdk.org
Sub
On Wed, 30 Apr 2025 23:34:06 GMT, Martin Fox wrote:
>> On macOS the system animates the transition into and out of fullscreen and
>> this animation runs asynchronously. JavaFX tries to make the setFullScreen
>> call appear synchronous by running a nested event loop while the transition
>> is g
On Tue, 29 Apr 2025 18:46:39 GMT, Martin Fox wrote:
>> Thiago Milczarek Sayao has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Remove old comment
>
> tests/system/src/test/java/test/robot/javafx/stage/StageAttributesTest.java
> line 312:
> This is a continuation to
> [JDK-8236651](https://bugs.openjdk.org/browse/JDK-8236651) and it aims to
> stabilize the linux glass gtk backend.
>
>
> Overall, it has been made more robust within its scope, particularly in terms
> of sizing, positioning, and state management.
>
> List of chan
On Thu, 24 Apr 2025 22:43:17 GMT, Thiago Milczarek Sayao
wrote:
>> tests/system/src/test/java/test/javafx/stage/FullScreenTest.java line 123:
>>
>>> 121: mode = EnumSource.Mode.INCLUDE,
>>> 122: names = {"DECORATED", "UNDECORATED", "TRANSPARENT"})
>>> 123: void testU
> This is a continuation to
> [JDK-8236651](https://bugs.openjdk.org/browse/JDK-8236651) and it aims to
> stabilize the linux glass gtk backend.
>
>
> Overall, it has been made more robust within its scope, particularly in terms
> of sizing, positioning, and state management.
>
> List of chan
I've just found out that RichTextArea doesn't have a setText method, but
CodeArea does.
Is this a mistake or was it done intentionally?
Best regards, Pavel
PS. Just don't think I spend my free time analyzing Javadoc. It's just that I
once opened an issue in RTFX suggesting
to add a setText me
On Wed, 30 Apr 2025 23:34:06 GMT, Martin Fox wrote:
>> On macOS the system animates the transition into and out of fullscreen and
>> this animation runs asynchronously. JavaFX tries to make the setFullScreen
>> call appear synchronous by running a nested event loop while the transition
>> is g
32 matches
Mail list logo
