> Implementation of
> [`StageStyle.EXTENDED`](https://gist.github.com/mstr2/0befc541ee7297b6db2865cc5e4dbd09).
Michael Strauß has updated the pull request incrementally with two additional
commits since the last revision:
- add MenuBar to stage tester
- documentation
-
Changes:
On 25/04/2025 00:25, Christopher Schnick wrote:
>
> The custom wrapper solution to synchronize sounds like a good idea. I
> will experiment with that. Would it not also be a solution to add such
> a synchronized property wrapper class to JavaFX itself?
>
Yeah, it definitely could be, as long as it
On Wed, 2 Apr 2025 14:06:58 GMT, Pabulaner IV wrote:
> When trying to register an open URI handler when using JavaFX with a native
> menu, this task fails on Mac.
> Either the native menu is not shown or the URIs are not received.
>
> This pull request fixes this issue if AWT is registered afte
On Thu, 24 Apr 2025 17:04:42 GMT, Martin Fox wrote:
> I did a rough pass on macOS and Windows. There's some failures in the
> StageLocation and StageAttributes tests that I haven't had time to look into.
>
> You might want to consider adding a few delay constants and using them
> instead of th
On Wed, 23 Apr 2025 19:48:52 GMT, Martin Fox wrote:
>> Thiago Milczarek Sayao has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Reenable RestoreSceneSizeTest (JDK-8353556)
>
> tests/system/src/test/java/test/javafx/stage/FullScreenTest.jav
On Thu, 24 Apr 2025 22:26:43 GMT, John Hendrikx wrote:
> The details button is private and not documented
it is not private: the method that creates it in the DialogPane:817 is
protected, so the application can override it and get a pointer to the button,
set styles, etc.
`protected Node crea
On Thu, 24 Apr 2025 13:58:05 GMT, Martin Fox wrote:
>> Thiago Milczarek Sayao has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Reenable RestoreSceneSizeTest (JDK-8353556)
>
> tests/system/src/test/java/test/javafx/stage/SizingTest.java li
On Thu, 24 Apr 2025 16:05:11 GMT, Martin Fox wrote:
>> Thiago Milczarek Sayao has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Reenable RestoreSceneSizeTest (JDK-8353556)
>
> tests/system/src/test/java/test/javafx/stage/SizingTest.java li
On Thu, 24 Apr 2025 14:50:22 GMT, Andy Goryachev wrote:
> > Then we can close this, as that's what the original code does already.
>
> Exactly (but I like the changes you made to add/remove "more"/"less" styles,
> since they won't erase any styles that the application might add during
> constr
The custom wrapper solution to synchronize sounds like a good idea. I
will experiment with that. Would it not also be a solution to add such a
synchronized property wrapper class to JavaFX itself?
The reason for why the expression helper replaces itself makes sense.
However, is that still a de
On Wed, 23 Apr 2025 23:26:23 GMT, Alexander Matveev
wrote:
> - Fixed gcc 14 compiler errors.
>
>
> ../../../gstreamer-lite/gstreamer/gst/gstclock.c: In function
> 'gst_clock_entry_new':
> ../../../gstreamer-lite/gstreamer/gst/gstclock.c:178:48: error: passing
> argument 1 of 'g_weak_ref_init
On 24/04/2025 22:07, Christopher Schnick wrote:
>
> Hey John,
>
> Thanks for taking your time on going into the details here.
>
> About our use case: We are actually not constructing UI in a
> background thread, all nodes are initialized and added to the scene on
> the platform thread. This is don
On Thu, 24 Apr 2025 20:56:52 GMT, Alexander Matveev
wrote:
>> modules/javafx.media/src/main/native/gstreamer/gstreamer-lite/gstreamer/gst/gst_private.h
>> line 535:
>>
>>> 533: {
>>> 534: GstClockEntry entry;
>>> 535: #if defined (GSTREAMER_LITE) && defined(LINUX)
>>
>> Why is this qualifie
On Thu, 24 Apr 2025 13:33:21 GMT, Kevin Rushforth wrote:
>> - Fixed gcc 14 compiler errors.
>>
>>
>> ../../../gstreamer-lite/gstreamer/gst/gstclock.c: In function
>> 'gst_clock_entry_new':
>> ../../../gstreamer-lite/gstreamer/gst/gstclock.c:178:48: error: passing
>> argument 1 of 'g_weak_ref_
Hey John,
Thanks for taking your time on going into the details here.
About our use case: We are actually not constructing UI in a background
thread, all nodes are initialized and added to the scene on the platform
thread. This is done because previously instantiating nodes on other
threads w
Thank you for a very good question!
The short answer is yes - it is possible to implement lazy styling in CodeArea,
as well as to implement styling of large documents in a reasonable fashion.
The styling is performed by the decoratorProperty of the CodeTextModel. Note:
please check out the Cod
On Thu, 24 Apr 2025 17:40:38 GMT, Michael Strauß wrote:
> Maybe you used a layout pane inside the `HeaderBar`, and set
> `HeaderBar.draggable = true` for the layout pane? This would then apply to
> the entire subtree of the pane, including the `MenuBar`.
Yes, the controls are in an `HBox` with
Suppose we have a very large file (1,000,000+ lines). For example, it could be
an XML file or a Java class written by a beginner programmer :).
The question is: how should we handle styling for such large files?
The simplest solution is to apply styles to all lines at once. Another option
is to
On Thu, 24 Apr 2025 14:42:33 GMT, Michael Strauß wrote:
>> Implementation of
>> [`StageStyle.EXTENDED`](https://gist.github.com/mstr2/0befc541ee7297b6db2865cc5e4dbd09).
>
> Michael Strauß has updated the pull request with a new target base due to a
> merge or a rebase. The pull request now cont
On Thu, 24 Apr 2025 09:15:15 GMT, Markus Mack wrote:
> * When placing a MenuBar in the HeaderBar, dragging the window by clicking on
> the menu will open the menu and drag the window away from the opened window,
> which looks broken, and ComboBox and TextField don't work at all. While the
> fi
On Wed, 23 Apr 2025 09:46:06 GMT, Thiago Milczarek Sayao
wrote:
>> This is a continuation to
>> [JDK-8236651](https://bugs.openjdk.org/browse/JDK-8236651) and it aims to
>> stabilize the linux glass gtk backend.
>>
>>
>> Overall, it has been made more robust within its scope, particularly in
On Wed, 16 Apr 2025 21:17:16 GMT, Marius Hanl wrote:
>> With this change, you can now run the `swt` tests as easy as: `:swt:test
>> -PSWT_TEST=true`.
>> 
>>
>> Note: At one point `IS_FULL_TEST` was used as
Backport of https://bugs.openjdk.org/browse/JDK-8318985 to jfx24u.
Fix is trivial and it resolves specular power issue on OpenGL pipeline for 3D
primitives.
-
Commit messages:
- Backport 2617ff5c891ba182581d323d8b424e4b8a6a6b63
Changes: https://git.openjdk.org/jfx24u/pull/25/files
On Thu, 24 Apr 2025 14:36:33 GMT, Michael Strauß wrote:
>> modules/javafx.graphics/src/main/java/javafx/stage/StageStyle.java line 113:
>>
>>> 111: * of the {@code Scene} to remain easily recognizable.
>>> Applications should set the scene fill to a color
>>> 112: * that matches the b
On Thu, 24 Apr 2025 14:55:34 GMT, Markus Mack wrote:
>> How a scene background is shown is already described in `Scene.fill`. Note
>> that if we get #1655, we might want to change this part of the specification
>> such that the color scheme of the buttons adjusts to the color scheme of the
>>
On Thu, 24 Apr 2025 15:13:45 GMT, Markus Mack wrote:
>> I think that's also not what it's supposed to mean. The header buttons don't
>> use the color of the scene background directly in their styling. Instead,
>> they use the scene background as a proxy to gauge the color scheme of the
>> enti
On Thu, 24 Apr 2025 14:03:58 GMT, Jayathirth D V wrote:
> Backport of https://bugs.openjdk.org/browse/JDK-8318985 to jfx24u.
> Fix is trivial and it resolves specular power issue on OpenGL pipeline for 3D
> primitives.
This pull request has now been integrated.
Changeset: 61b62810
Author:J
On Thu, 24 Apr 2025 15:01:24 GMT, Markus Mack wrote:
>> I agree when it actually makes a semantic difference. For example, there's a
>> difference between setting `Node.opacity` to zero, and setting
>> `Node.visible` to `false`. In the first case, the node will still receive
>> events, while i
On Thu, 24 Apr 2025 15:07:10 GMT, Michael Strauß wrote:
>> Ah, so I think I misunderstood this. Maybe change "is adjusted to" to "is
>> adjusted to match" or "is bound to" so it's clear the fill color is used as
>> the background, and not something else based on it. Also, add "elsewhere"
>> af
On Thu, 24 Apr 2025 14:36:52 GMT, Michael Strauß wrote:
>> modules/javafx.graphics/src/main/native-glass/mac/GlassWindow.h line 53:
>>
>>> 51: BOOLisDecorated;
>>> 52: BOOLisResizable;
>>> 53: BOOLisStandardButtonsVisible;
>>
>> showSt
On Thu, 24 Apr 2025 14:36:35 GMT, Michael Strauß wrote:
>> modules/javafx.graphics/src/main/java/javafx/stage/StageStyle.java line 117:
>>
>>> 115: * Custom header buttons
>>> 116: * If more control over the header buttons is desired,
>>> applications can opt out of the default header
On Thu, 24 Apr 2025 00:01:52 GMT, John Hendrikx wrote:
> Then we can close this, as that's what the original code does already.
Exactly (but I like the changes you made to add/remove "more"/"less" styles,
since they won't erase any styles that the application might add during
construction).
L
On Thu, 24 Apr 2025 08:12:57 GMT, Markus Mack wrote:
>> Michael Strauß has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> documentation
>
> modules/javafx.graphics/src/main/java/com/sun/javafx/tk/TKScene.java line 89:
>
>> 87: public T
On Thu, 10 Apr 2025 21:22:21 GMT, Andy Goryachev wrote:
> The code should not set the `Task.state` value to `CANCELLED` if the said
> task is already `SUCCEEDED` or `FAILED`.
>
> This is a product bug.
>
> Added `@RepeatedTest(50)` to the tests that used to fail intermittently -
> this made t
> Implementation of
> [`StageStyle.EXTENDED`](https://gist.github.com/mstr2/0befc541ee7297b6db2865cc5e4dbd09).
Michael Strauß has updated the pull request with a new target base due to a
merge or a rebase. The pull request now contains 84 commits:
- review comments
- Merge branch 'master' int
On Wed, 16 Apr 2025 20:28:14 GMT, Andy Goryachev wrote:
>> The code should not set the `Task.state` value to `CANCELLED` if the said
>> task is already `SUCCEEDED` or `FAILED`.
>>
>> This is a product bug.
>>
>> Added `@RepeatedTest(50)` to the tests that used to fail intermittently -
>> this
On Wed, 23 Apr 2025 23:26:23 GMT, Alexander Matveev
wrote:
> - Fixed gcc 14 compiler errors.
>
>
> ../../../gstreamer-lite/gstreamer/gst/gstclock.c: In function
> 'gst_clock_entry_new':
> ../../../gstreamer-lite/gstreamer/gst/gstclock.c:178:48: error: passing
> argument 1 of 'g_weak_ref_init
On Thu, 10 Apr 2025 16:11:07 GMT, Kevin Rushforth wrote:
> Fixes a link error that occurs when using C++14 to compile and link JavaFX on
> Linux.
>
>
> in function `PlatformSupport::PlatformSupport(JNIEnv_*, _jobject*)':
> PlatformSupport.cpp:90: undefined reference to
> `PlatformSupport::OBS
On Wed, 23 Apr 2025 12:13:52 GMT, Jayathirth D V wrote:
> When no specular color is set while rendering 3D primitives, 0.0 specular
> power value is used by default in our shaders.
> When same specular power value is used in pow() function in shader it results
> in undefined behaviour as mentio
On Wed, 16 Apr 2025 20:28:14 GMT, Andy Goryachev wrote:
>> The code should not set the `Task.state` value to `CANCELLED` if the said
>> task is already `SUCCEEDED` or `FAILED`.
>>
>> This is a product bug.
>>
>> Added `@RepeatedTest(50)` to the tests that used to fail intermittently -
>> this
On Sun, 23 Mar 2025 08:56:43 GMT, Michael Strauß wrote:
>> We generally use "Behavior" in the context of controls. Although not wrong,
>> I also think another name might be better. Maybe "Controller"? Or "Manager"?
>> Or ...
>
> After contemplating for a while, I still think that "Behavior" is
On Tue, 15 Apr 2025 10:56:31 GMT, Michael Strauß wrote:
>> Implementation of
>> [`StageStyle.EXTENDED`](https://gist.github.com/mstr2/0befc541ee7297b6db2865cc5e4dbd09).
>
> Michael Strauß has updated the pull request incrementally with one additional
> commit since the last revision:
>
> doc
On Tue, 8 Apr 2025 22:41:02 GMT, Martin Fox wrote:
>> definitely an unrelated issue, I just wanted to ask whether you guys think
>> it crosses the threshold for a bug.
>
>> control+left-click works as expected for me too.
>
> For control+left-click it looks like the code will call
> `columnReo
On Mon, 14 Apr 2025 21:04:30 GMT, Kevin Rushforth wrote:
>> Fixes a link error that occurs when using C++14 to compile and link JavaFX
>> on Linux.
>>
>>
>> in function `PlatformSupport::PlatformSupport(JNIEnv_*, _jobject*)':
>> PlatformSupport.cpp:90: undefined reference to
>> `PlatformSuppo
On Wed, 23 Apr 2025 15:27:23 GMT, Jayathirth D V wrote:
> As part of https://bugs.openjdk.org/browse/JDK-8353557,
> InitializeJavaFXLaunchTests were disabled as they were failing in Ubuntu24.04
> VM and product issue https://bugs.openjdk.org/browse/JDK-8353644 was created.
>
> But after verify
On Wed, 23 Apr 2025 09:46:06 GMT, Thiago Milczarek Sayao
wrote:
>> This is a continuation to
>> [JDK-8236651](https://bugs.openjdk.org/browse/JDK-8236651) and it aims to
>> stabilize the linux glass gtk backend.
>>
>>
>> Overall, it has been made more robust within its scope, particularly in
46 matches
Mail list logo
