Re: RFR: 8332947: [macos] java.awt.desktop.OpenURIHandler is not receiving events

2025-04-14 Thread Pabulaner IV
On Wed, 2 Apr 2025 14:06:58 GMT, Pabulaner IV wrote: > When trying to register an open URI handler when using JavaFX with a native > menu, this task fails on Mac. > Either the native menu is not shown or the URIs are not received. > > This pull request fixes this issue if AWT is registered afte

Re: RFR: 8354480: A Stage should allow simultaneous iconified and maximized states [v2]

2025-04-14 Thread Martin Fox
On Sun, 13 Apr 2025 18:01:08 GMT, Thiago Milczarek Sayao wrote: >> On some platforms (at least on Ubuntu 24.04 with GNOME and Windows 11), >> windows can remain maximized even when they are iconified (minimized). When >> the window is de-iconified (restored), it retains its maximized state. >>

Re: [jfx24u] RFR: 8354182: Create release notes for JavaFX 24.0.1

2025-04-14 Thread Ambarish Rapte
On Wed, 9 Apr 2025 23:17:49 GMT, Kevin Rushforth wrote: > Release notes for JavaFX 24.0.1. > > Notes to reviewers: > > I used the following filter to pick the issues: > > https://bugs.openjdk.org/issues/?filter=47358 > > The original filter, with the backport IDs, is here: > > https://bugs.o

Re: [jfx24u] RFR: 8354182: Create release notes for JavaFX 24.0.1

2025-04-14 Thread Joeri Sykora
On Wed, 9 Apr 2025 23:17:49 GMT, Kevin Rushforth wrote: > Release notes for JavaFX 24.0.1. > > Notes to reviewers: > > I used the following filter to pick the issues: > > https://bugs.openjdk.org/issues/?filter=47358 > > The original filter, with the backport IDs, is here: > > https://bugs.o

Re: RFR: 8332947: [macos] java.awt.desktop.OpenURIHandler is not receiving events

2025-04-14 Thread Kevin Rushforth
On Wed, 2 Apr 2025 14:06:58 GMT, Pabulaner IV wrote: > When trying to register an open URI handler when using JavaFX with a native > menu, this task fails on Mac. > Either the native menu is not shown or the URIs are not received. > > This pull request fixes this issue if AWT is registered afte

Re: RFR: 8354478: Improve StageStyle documentation [v2]

2025-04-14 Thread Thiago Milczarek Sayao
On Mon, 14 Apr 2025 23:38:36 GMT, Thiago Milczarek Sayao wrote: >> modules/javafx.graphics/src/main/java/javafx/stage/StageStyle.java line 41: >> >>> 39: /** >>> 40: * Defines a {@code Stage} style with no window decorations, such >>> as a title bar, >>> 41: * borders, or window

Re: RFR: 8354478: Improve StageStyle documentation [v2]

2025-04-14 Thread Thiago Milczarek Sayao
On Mon, 14 Apr 2025 16:00:10 GMT, Nir Lisker wrote: >> Thiago Milczarek Sayao has updated the pull request incrementally with two >> additional commits since the last revision: >> >> - Add "style" ib the UTILITY style like the others >> - Update modules/javafx.graphics/src/main/java/javafx/st

Re: RFR: 8354478: Improve StageStyle documentation [v3]

2025-04-14 Thread Thiago Milczarek Sayao
On Mon, 14 Apr 2025 14:36:13 GMT, Andy Goryachev wrote: >> Thiago Milczarek Sayao has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Restore "with a solid white background" > > modules/javafx.graphics/src/main/java/javafx/stage/StageStyle.j

Re: RFR: 8354478: Improve StageStyle documentation [v3]

2025-04-14 Thread Thiago Milczarek Sayao
> Improve StageStyle Documentation > > - Update `StageStyle.UTILITY`: > Clarified that UTILITY stages may impose platform-specific restrictions on > window states, such as preventing maximize, minimize (iconify), and > fullscreen operations. > > - Update `StageStyle.UNDECORATED`: > Improved the

Re: RFR: 8354455: [TestBug] Remove JUnit Vintage Engine with JUnit 4 [v2]

2025-04-14 Thread Andy Goryachev
On Sat, 12 Apr 2025 00:23:07 GMT, Marius Hanl wrote: >> These are the remaining bits and pieces in order to completely remove the >> JUnit Vintage Engine, and therefore JUnit 4 from JavaFX. >> After that, we should either document, that JUnit5 is used (just as >> information) or close >> [JDK-

Re: RFR: 8354455: [TestBug] Remove JUnit Vintage Engine with JUnit 4 [v2]

2025-04-14 Thread Andy Goryachev
On Mon, 14 Apr 2025 22:17:58 GMT, Kevin Rushforth wrote: > Getting these tests to run on macOS seems better for a follow-up. Quite right. The exception I see might indicate a problem even there - the exception is coming from `Display.getDefault()`, and `runOnSwtThread` uses the display to use

Re: RFR: 8354455: [TestBug] Remove JUnit Vintage Engine with JUnit 4 [v2]

2025-04-14 Thread Kevin Rushforth
On Mon, 14 Apr 2025 22:10:57 GMT, Andy Goryachev wrote: > a problem found in a doctored macOS test, I wonder if we'll see the same > issue on windows/linux? The SWT tests have never worked on macOS as far as I know -- even before JDK 9 modularization when they were disabled on all platforms.

Re: RFR: 8332947: [macos] java.awt.desktop.OpenURIHandler is not receiving events

2025-04-14 Thread Kevin Rushforth
On Mon, 14 Apr 2025 21:24:49 GMT, Kevin Rushforth wrote: > Also, since the proposed fix is in JavaFX, the JBS bug needs to be updated to > the correct component/subcomponent/version. I see that it's not quite that simple, since there is a corresponding AWT fix. You cannot use the same bug ID f

Re: RFR: 8332947: [macos] java.awt.desktop.OpenURIHandler is not receiving events

2025-04-14 Thread Kevin Rushforth
On Wed, 2 Apr 2025 14:06:58 GMT, Pabulaner IV wrote: > When trying to register an open URI handler when using JavaFX with a native > menu, this task fails on Mac. > Either the native menu is not shown or the URIs are not received. > > This pull request fixes this issue if AWT is registered afte

RFR: 8332947: [macos] java.awt.desktop.OpenURIHandler is not receiving events

2025-04-14 Thread Pabulaner IV
When trying to register an open URI handler when using JavaFX with a native menu, this task fails on Mac. Either the native menu is not shown or the URIs are not received. This pull request fixes this issue if AWT is registered after JavaFX, so that AWT runs embedded inside JavaFX. It fixes this

Re: RFR: 8354455: [TestBug] Remove JUnit Vintage Engine with JUnit 4 [v2]

2025-04-14 Thread Andy Goryachev
On Sat, 12 Apr 2025 00:23:07 GMT, Marius Hanl wrote: >> These are the remaining bits and pieces in order to completely remove the >> JUnit Vintage Engine, and therefore JUnit 4 from JavaFX. >> After that, we should either document, that JUnit5 is used (just as >> information) or close >> [JDK-

Re: RFR: 8332947: [macos] java.awt.desktop.OpenURIHandler is not receiving events

2025-04-14 Thread Dalibor Topic
On Wed, 2 Apr 2025 14:06:58 GMT, Pabulaner IV wrote: > When trying to register an open URI handler when using JavaFX with a native > menu, this task fails on Mac. > Either the native menu is not shown or the URIs are not received. > > This pull request fixes this issue if AWT is registered afte

Re: RFR: 8353632: [Linux] Undefined reference to PlatformSupport::OBSERVED_SETTINGS with C++14 [v2]

2025-04-14 Thread Kevin Rushforth
> Fixes a link error that occurs when using C++14 to compile and link JavaFX on > Linux. > > > in function `PlatformSupport::PlatformSupport(JNIEnv_*, _jobject*)': > PlatformSupport.cpp:90: undefined reference to > `PlatformSupport::OBSERVED_SETTINGS' > > > The solution, proposed by @johanvos

Re: RFR: 8332947: [macos] java.awt.desktop.OpenURIHandler is not receiving events

2025-04-14 Thread Pabulaner IV
On Wed, 2 Apr 2025 14:06:58 GMT, Pabulaner IV wrote: > When trying to register an open URI handler when using JavaFX with a native > menu, this task fails on Mac. > Either the native menu is not shown or the URIs are not received. > > This pull request fixes this issue if AWT is registered afte

Re: RFR: 8332947: [macos] java.awt.desktop.OpenURIHandler is not receiving events

2025-04-14 Thread Kevin Rushforth
On Tue, 8 Apr 2025 16:26:44 GMT, Pabulaner IV wrote: > Are there any news on my OCA status? @robilad Can you provide a status update? - PR Comment: https://git.openjdk.org/jfx/pull/1755#issuecomment-2787065269

Re: RFR: 8332947: [macos] java.awt.desktop.OpenURIHandler is not receiving events

2025-04-14 Thread Kevin Rushforth
On Wed, 2 Apr 2025 14:06:58 GMT, Pabulaner IV wrote: > When trying to register an open URI handler when using JavaFX with a native > menu, this task fails on Mac. > Either the native menu is not shown or the URIs are not received. > > This pull request fixes this issue if AWT is registered afte

Re: RFR: 8345348: CSS media feature queries [v16]

2025-04-14 Thread Michael Strauß
> Implementation of [CSS media > queries](https://gist.github.com/mstr2/cbb93bff03e073ec0c32aac317b22de7). Michael Strauß has updated the pull request incrementally with two additional commits since the last revision: - formatting - typo - Changes: - all: https://git.openjdk.o

Re: RFR: 8354478: Improve StageStyle documentation [v2]

2025-04-14 Thread Thiago Milczarek Sayao
> Improve StageStyle Documentation > > - Update `StageStyle.UTILITY`: > Clarified that UTILITY stages may impose platform-specific restrictions on > window states, such as preventing maximize, minimize (iconify), and > fullscreen operations. > > - Update `StageStyle.UNDECORATED`: > Improved the

Re: RFR: 8345348: CSS media feature queries [v13]

2025-04-14 Thread Michael Strauß
On Mon, 14 Apr 2025 11:34:43 GMT, John Hendrikx wrote: >> Michael Strauß has updated the pull request incrementally with one >> additional commit since the last revision: >> >> improved implementation of NullCoalescingPropertyBase > > modules/javafx.graphics/src/main/java/javafx/css/Rule.java

Re: [jfx24u] RFR: 8354182: Create release notes for JavaFX 24.0.1

2025-04-14 Thread Kevin Rushforth
On Wed, 9 Apr 2025 23:17:49 GMT, Kevin Rushforth wrote: > Release notes for JavaFX 24.0.1. > > Notes to reviewers: > > I used the following filter to pick the issues: > > https://bugs.openjdk.org/issues/?filter=47358 > > The original filter, with the backport IDs, is here: > > https://bugs.o

Re: RFR: 8354480: A Stage should allow simultaneous iconified and maximized states [v2]

2025-04-14 Thread Thiago Milczarek Sayao
On Mon, 14 Apr 2025 17:17:23 GMT, Martin Fox wrote: > I have some issues with the premise of this pull request. It's true that a > window's iconified and maximized _properties_ can be true at the same time. > But the window itself can't be in both states at once; the user will never > see a wi

Re: RFR: 8354478: Improve StageStyle documentation

2025-04-14 Thread Nir Lisker
On Sun, 13 Apr 2025 15:24:43 GMT, Thiago Milczarek Sayao wrote: > Improve StageStyle Documentation > > - Update `StageStyle.UTILITY`: > Clarified that UTILITY stages may impose platform-specific restrictions on > window states, such as preventing maximize, minimize (iconify), and > fullscreen

[jfx24u] RFR: 8354318: freetype.c: compilation error: 'incompatible pointer type' with gcc 14

2025-04-14 Thread Kevin Rushforth
Clean backport of "incompatible pointer type" fix to jfx24u - Commit messages: - Backport 5a897ab7017107471528ab527dac505d2e33aca9 Changes: https://git.openjdk.org/jfx24u/pull/21/files Webrev: https://webrevs.openjdk.org/?repo=jfx24u&pr=21&range=00 Issue: https://bugs.openjdk.or

Re: RFR: 8354480: A Stage should allow simultaneous iconified and maximized states [v2]

2025-04-14 Thread Andy Goryachev
On Mon, 14 Apr 2025 15:19:01 GMT, Thiago Milczarek Sayao wrote: >> modules/javafx.graphics/src/main/java/com/sun/glass/events/WindowEvent.java >> line 43: >> >>> 41: * and {@link #UNMINIMIZE}. >>> 42: */ >>> 43: @Deprecated >> >> I am curious: what would be the benefit of deprec

Re: RFR: 8354480: A Stage should allow simultaneous iconified and maximized states [v2]

2025-04-14 Thread Andy Goryachev
On Mon, 14 Apr 2025 15:30:16 GMT, Thiago Milczarek Sayao wrote: >> modules/javafx.graphics/src/main/java/com/sun/glass/events/WindowEvent.java >> line 76: >> >>> 74: case WindowEvent.FOCUS_DISABLED -> "FOCUS_DISABLED"; >>> 75: case WindowEvent.FOCUS_UNGRAB -> "FOCUS_UNG

Unnecessary layouts; TLDR; new method "requestLocalLayout"

2025-04-14 Thread John Hendrikx
I've been writing a container that does layout, and I've been using it extensively in my latest project. I noticed that many skins and controls will call requestLayout(), not realizing that this will mark the current node + all parent nodes with `NEEDS_LAYOUT`.  This causes all those containers to

Re: RFR: 8354478: Improve StageStyle documentation [v2]

2025-04-14 Thread Nir Lisker
On Mon, 14 Apr 2025 15:13:19 GMT, Thiago Milczarek Sayao wrote: >> Improve StageStyle Documentation >> >> - Update `StageStyle.UTILITY`: >> Clarified that UTILITY stages may impose platform-specific restrictions on >> window states, such as preventing maximize, minimize (iconify), and >> full

Re: RFR: 8354478: Improve StageStyle documentation

2025-04-14 Thread Lukasz Kostyra
On Sun, 13 Apr 2025 15:24:43 GMT, Thiago Milczarek Sayao wrote: > Improve StageStyle Documentation > > - Update `StageStyle.UTILITY`: > Clarified that UTILITY stages may impose platform-specific restrictions on > window states, such as preventing maximize, minimize (iconify), and > fullscreen

Re: RFR: 8354480: A Stage should allow simultaneous iconified and maximized states [v2]

2025-04-14 Thread Thiago Milczarek Sayao
On Mon, 14 Apr 2025 15:06:15 GMT, Andy Goryachev wrote: >> Thiago Milczarek Sayao has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Missed one change > > modules/javafx.graphics/src/main/java/com/sun/glass/events/WindowEvent.java > line 4

Re: Menu keyboard shortcuts not working anymore

2025-04-14 Thread Martin Fox
Clemens, Thanks for reporting this. I did some testing and I think I’ve reproduced the problem. What I’m seeing is specific to the Mac; when the focus is in a ComboBox, DatePicker, or Spinner the user can’t use Cmd+Q to quit the app. This also affects other menu items if you’re using the system

Re: RFR: 8354478: Improve StageStyle documentation

2025-04-14 Thread Andy Goryachev
On Sun, 13 Apr 2025 15:24:43 GMT, Thiago Milczarek Sayao wrote: > Improve StageStyle Documentation > > - Update `StageStyle.UTILITY`: > Clarified that UTILITY stages may impose platform-specific restrictions on > window states, such as preventing maximize, minimize (iconify), and > fullscreen

Re: RFR: 8354480: A Stage should allow simultaneous iconified and maximized states [v2]

2025-04-14 Thread Andy Goryachev
On Sun, 13 Apr 2025 18:01:08 GMT, Thiago Milczarek Sayao wrote: >> On some platforms (at least on Ubuntu 24.04 with GNOME and Windows 11), >> windows can remain maximized even when they are iconified (minimized). When >> the window is de-iconified (restored), it retains its maximized state. >>

Re: RFR: 8354478: Improve StageStyle documentation

2025-04-14 Thread John Hendrikx
On Sun, 13 Apr 2025 15:24:43 GMT, Thiago Milczarek Sayao wrote: > Improve StageStyle Documentation > > - Update `StageStyle.UTILITY`: > Clarified that UTILITY stages may impose platform-specific restrictions on > window states, such as preventing maximize, minimize (iconify), and > fullscreen

Re: RFR: 8345348: CSS media feature queries [v15]

2025-04-14 Thread Michael Strauß
> Implementation of [CSS media > queries](https://gist.github.com/mstr2/cbb93bff03e073ec0c32aac317b22de7). Michael Strauß has updated the pull request incrementally with one additional commit since the last revision: use equality instead of identity - Changes: - all: https://g

Re: RFR: 8345348: CSS media feature queries [v13]

2025-04-14 Thread Michael Strauß
On Mon, 14 Apr 2025 11:18:29 GMT, John Hendrikx wrote: >> Michael Strauß has updated the pull request incrementally with one >> additional commit since the last revision: >> >> improved implementation of NullCoalescingPropertyBase > > modules/javafx.graphics/src/main/java/com/sun/javafx/css/p

Re: RFR: 8345348: CSS media feature queries [v14]

2025-04-14 Thread Michael Strauß
> Implementation of [CSS media > queries](https://gist.github.com/mstr2/cbb93bff03e073ec0c32aac317b22de7). Michael Strauß has updated the pull request incrementally with one additional commit since the last revision: rename TokenStream methods - Changes: - all: https://git.ope

Re: RFR: 8345348: CSS media feature queries [v13]

2025-04-14 Thread Michael Strauß
On Mon, 14 Apr 2025 09:56:43 GMT, John Hendrikx wrote: >> Michael Strauß has updated the pull request incrementally with one >> additional commit since the last revision: >> >> improved implementation of NullCoalescingPropertyBase > > modules/javafx.graphics/src/main/java/com/sun/javafx/appli

Re: RFR: 8345348: CSS media feature queries [v13]

2025-04-14 Thread John Hendrikx
On Sun, 13 Apr 2025 17:34:15 GMT, Michael Strauß wrote: >> Implementation of [CSS media >> queries](https://gist.github.com/mstr2/cbb93bff03e073ec0c32aac317b22de7). > > Michael Strauß has updated the pull request incrementally with one additional > commit since the last revision: > > improve

Re: RFR: 8296554: MouseLocationOnScreenTest sometime fails when system is busy

2025-04-14 Thread Gopal Pattnaik
On Fri, 11 Apr 2025 09:37:12 GMT, Gopal Pattnaik wrote: > There was a Assertion fail issue in mouse location test case JDK-8296554, > Reason: We felt the one mili second delay time for the Robot test may be > insufficient in few OS. > Solution: We Changed the delay time to three mili second. >

Re: RFR: 8296554: MouseLocationOnScreenTest sometime fails when system is busy [v2]

2025-04-14 Thread Gopal Pattnaik
> There was a Assertion fail issue in mouse location test case JDK-8296554, > Reason: We felt the one mili second delay time for the Robot test may be > insufficient in few OS. > Solution: We Changed the delay time to three mili second. > > Verification: > Tested in Windows 11, and the Assert fai