On Mon, 14 Apr 2025 15:19:01 GMT, Thiago Milczarek Sayao <tsa...@openjdk.org>
wrote:
>> modules/javafx.graphics/src/main/java/com/sun/glass/events/WindowEvent.java
>> line 43:
>>
>>> 41: * and {@link #UNMINIMIZE}.
>>> 42: */
>>> 43: @Deprecated
>>
>> I am curious: what would be the benefit of deprecating, as opposed to
>> redefining?
>> Is there a possibility of a mismatch between the java code and the native?
>
> My idea is to update all platforms for consistency and eventually remove it,
> since it's for internal use.
>
> I think this area might be broken on native code and it'll need some update.
>
> This branch has this change as well as I'm fixing native Linux glass code to
> cope with it:
> https://github.com/openjdk/jfx-sandbox/tree/glass_gtk_bug_squashing
>
> This test (on the branch) does some mixing of States:
> `gradlew -PFULL_TEST=true -PUSE_ROBOT=true :systemTests:test --tests
> StageStatesTest`
I don't follow. Are you saying this PR is not complete?
Since the change is not in a public API, I think it makes more sense not to
leave partial changes. Any breakage then will be immediately obvious during
testing.
Do you think there might be hidden dependencies on the exact value?
-------------
PR Review Comment: https://git.openjdk.org/jfx/pull/1777#discussion_r2042485461
