Re: RFR: 8350048: Enforce threading restrictions for show and hide methods in Window, Control, and Skin [v2]

2025-02-26 Thread Ambarish Rapte
On Wed, 26 Feb 2025 23:39:27 GMT, Andy Goryachev wrote: >> - enforced fx application thread >> - added a headful test `TestThreadingRestrictions` >> >> ## Note to the Reviewers >> >> To avoid merge conflicts, the preferred order of integrations: >> >> #1697 >> #1713 >> #1717 > > Andy Goryach

Re: RFR: 8281384: Random chars on paste from Windows clipboard [v4]

2025-02-26 Thread Michael Strauß
On Wed, 26 Feb 2025 18:28:28 GMT, Oliver Schmidtmer wrote: >> Windows programs may reuse a clipboard buffer that is larger than the new >> content. In this case de NUL terminator is not at the end of the buffer, but >> within it. >> The current implementation copys the whole buffer into a tex

Re: RFR: 8350048: Enforce threading restrictions for show and hide methods in Window, Control, and Skin [v2]

2025-02-26 Thread Andy Goryachev
> - enforced fx application thread > - added a headful test `TestThreadingRestrictions` > > ## Note to the Reviewers > > To avoid merge conflicts, the preferred order of integrations: > > #1697 > #1713 > #1717 Andy Goryachev has updated the pull request with a new target base due to a merge

Re: RFR: 8347359: RichTextArea API Tests [v2]

2025-02-26 Thread Andy Goryachev
On Thu, 20 Feb 2025 19:40:42 GMT, Andy Goryachev wrote: >> Additional RichTextArea API tests. > > Andy Goryachev has updated the pull request with a new target base due to a > merge or a rebase. The pull request now contains 20 commits: > > - Merge remote-tracking branch 'origin/master' into 8

Re: RFR: 8347359: RichTextArea API Tests [v3]

2025-02-26 Thread Andy Goryachev
> Additional RichTextArea API tests. Andy Goryachev has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 21 commits: - Merge remote-tracking branch 'origin/master' into 8347359.rta.api.tests - Merge remote-tracking branch 'origin/master'

Re: [jfx24u] RFR: 8350437: [GHA] Update gradle wrapper-validation action to v3

2025-02-26 Thread Kevin Rushforth
On Fri, 21 Feb 2025 16:37:57 GMT, Kevin Rushforth wrote: > Clean backport of GHA-only fix to jfx24u. @johanvos Can you approve this (it doesn't need review, but needs maintainer approval). - PR Comment: https://git.openjdk.org/jfx24u/pull/8#issuecomment-2686202650

Re: What is the best way to get a high frame rate in a JavaFX application?

2025-02-26 Thread Kevin Rushforth
Yes, I think that's the best advice for now. Really, though, a good RFE would be to provide a way to adapt to the refresh rate of the monitor when vsync is being used. That's really the point of doing vsync in the first place. -- Kevin On 2/26/2025 10:17 AM, Johan Vos wrote: Hi Glavo, I be

Re: RFR: 8281384: Random chars on paste from Windows clipboard [v3]

2025-02-26 Thread Oliver Schmidtmer
> Windows programs may reuse a clipboard buffer that is larger than the new > content. In this case de NUL terminator is not at the end of the buffer, but > within it. > The current implementation copys the whole buffer into a text field, > including the NUL terminator and the remaining chars.

Re: RFR: 8281384: Random chars on paste from Windows clipboard [v4]

2025-02-26 Thread Oliver Schmidtmer
> Windows programs may reuse a clipboard buffer that is larger than the new > content. In this case de NUL terminator is not at the end of the buffer, but > within it. > The current implementation copys the whole buffer into a text field, > including the NUL terminator and the remaining chars.

Re: What is the best way to get a high frame rate in a JavaFX application?

2025-02-26 Thread Johan Vos
Hi Glavo, I believe setting the javafx.animation.pulse is indeed the best way to increase the render frequency (or to minimize the time between 2 pulses). It is independent of the hardware/pipeline being used. Of course, you may see a higher load in the JavaFX Application Thread and in the Quantum

Re: What is the best way to get a high frame rate in a JavaFX application?

2025-02-26 Thread Glavo
I found that setting `javafx.animation.pulse` to a higher value worked for me. I considered setting `javafx.animation.pulse` to 120 for all users to get smooth animation. Is this the most recommended approach at this time? Glavo On Wed, Feb 26, 2025 at 3:55 AM Glavo wrote: > Hi, > > Recently I

Re: RFR: 8281384: Random chars on paste from Windows clipboard [v2]

2025-02-26 Thread Kevin Rushforth
On Tue, 25 Feb 2025 15:24:39 GMT, Oliver Schmidtmer wrote: >> Windows programs may reuse a clipboard buffer that is larger than the new >> content. In this case de NUL terminator is not at the end of the buffer, but >> within it. >> The current implementation copys the whole buffer into a tex

Re: RFR: 8281384: Random chars on paste from Windows clipboard [v2]

2025-02-26 Thread John Hendrikx
On Tue, 25 Feb 2025 15:24:39 GMT, Oliver Schmidtmer wrote: >> Windows programs may reuse a clipboard buffer that is larger than the new >> content. In this case de NUL terminator is not at the end of the buffer, but >> within it. >> The current implementation copys the whole buffer into a tex

Re: RFR: 8281384: Random chars on paste from Windows clipboard [v2]

2025-02-26 Thread Kevin Rushforth
On Wed, 26 Feb 2025 13:22:16 GMT, Kevin Rushforth wrote: > I can't reproduce the original bug on Windows 11. Actually, I didn't run the test correctly earlier. I can reproduce it locally, so I'll be able to verify the fix (once we resolve the outstanding questions). - PR Comment:

Re: RFR: 8281384: Random chars on paste from Windows clipboard [v2]

2025-02-26 Thread Kevin Rushforth
On Tue, 25 Feb 2025 15:24:39 GMT, Oliver Schmidtmer wrote: >> Windows programs may reuse a clipboard buffer that is larger than the new >> content. In this case de NUL terminator is not at the end of the buffer, but >> within it. >> The current implementation copys the whole buffer into a tex

Re: RFR: 8281384: Random chars on paste from Windows clipboard [v2]

2025-02-26 Thread Lukasz Kostyra
On Tue, 25 Feb 2025 15:24:39 GMT, Oliver Schmidtmer wrote: >> Windows programs may reuse a clipboard buffer that is larger than the new >> content. In this case de NUL terminator is not at the end of the buffer, but >> within it. >> The current implementation copys the whole buffer into a tex

Re: RFR: 8281384: Random chars on paste from Windows clipboard [v2]

2025-02-26 Thread Kevin Rushforth
On Tue, 25 Feb 2025 15:24:39 GMT, Oliver Schmidtmer wrote: >> Windows programs may reuse a clipboard buffer that is larger than the new >> content. In this case de NUL terminator is not at the end of the buffer, but >> within it. >> The current implementation copys the whole buffer into a tex

Re: RFR: 8281384: Random chars on paste from Windows clipboard [v2]

2025-02-26 Thread Kevin Rushforth
On Tue, 25 Feb 2025 15:21:22 GMT, Oliver Schmidtmer wrote: >> modules/javafx.graphics/src/main/java/com/sun/glass/ui/win/WinSystemClipboard.java >> line 258: >> >>> 256: int nullTerm = data.length - 2; >>> 257: for (int i = 0; i < data.length; i += 2) {

[jfx24] Integrated: 8349472: Update copyright header for files modified in 2025

2025-02-26 Thread Ambarish Rapte
On Wed, 26 Feb 2025 00:32:02 GMT, Ambarish Rapte wrote: > Update copyright year for jfx24 release. This pull request has now been integrated. Changeset: ca0f3806 Author:Ambarish Rapte URL: https://git.openjdk.org/jfx/commit/ca0f3806bb8ab0b210fad262fdc5d900301b88bd Stats: 65 line

Re: [jfx24] RFR: 8349472: Update copyright header for files modified in 2025

2025-02-26 Thread Kevin Rushforth
On Wed, 26 Feb 2025 00:32:02 GMT, Ambarish Rapte wrote: > Update copyright year for jfx24 release. LGTM - Marked as reviewed by kcr (Lead). PR Review: https://git.openjdk.org/jfx/pull/1725#pullrequestreview-2644327282

Re: RFR: 8313556: Create implementation of NSAccessibilitySlider protocol [v7]

2025-02-26 Thread Alexander Zuev
> Create implementation for Slider and Stepper accessibility protocols. > Fix mapping. > Fix performAction parameter type in declaration. Alexander Zuev has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 14 commits: - Add accessibilityT