RFR: 8349891: Not implemented function should have printf

2025-02-13 Thread Jay Bhaskar
Some newly added, unimplemented functions in FileSystemJava.cpp during the WebKit upgrade to version 620.1 should include print statements to indicate at runtime when these functions are invoked. - Commit messages: - 8349891: Not implemented function should have printf Changes: ht

Re: RFR: 8337960: Improve performance of mfwrapper by reusing GStreamer media buffers for decoded video [v2]

2025-02-13 Thread Kevin Rushforth
On Thu, 13 Feb 2025 03:51:28 GMT, Alexander Matveev wrote: >> - Added new class `CMFGSTBuffer` which can allocate memory internally or >> provide GStreamer allocated memory to Media Foundation. >> - Added `GstBufferPool` to limit allocation of output buffers used for >> rendering (memory will

Re: RFR: 8349373: Support JavaFX preview features [v2]

2025-02-13 Thread Kevin Rushforth
On Thu, 13 Feb 2025 21:53:25 GMT, Michael Strauß wrote: >> Yeah, that's what I came to realize as well. So our property should remain >> boolean. >> >> The only other thing I could think of is for us to provide a new utility >> method (in some class in javafx.base) that an application must cal

Re: RFR: 8349096: Split/MenuButton: exception initializing in a background thread

2025-02-13 Thread Kevin Rushforth
On Wed, 12 Feb 2025 20:15:03 GMT, Andy Goryachev wrote: > ## Root Cause > > The ContextMenu (PopupWindow) cannot be shown in a background thread. > > ## Solution > > Bail out of `show()` if in a background thread. I took another look today, and I am convinced that we need to change the spec

Re: RFR: 8349004: DatePicker: NPE in show() when initialized in a background thread

2025-02-13 Thread Kevin Rushforth
On Wed, 12 Feb 2025 19:45:32 GMT, Andy Goryachev wrote: > ## Root Cause > > Focus is being requested in show(), even a background thread. > > ## Solution > > Do not request focus if in a background thread. I took another look today, and I am convinced that we need to change the spec and impl

Re: RFR: 8349373: Support JavaFX preview features [v2]

2025-02-13 Thread Michael Strauß
On Thu, 13 Feb 2025 18:41:21 GMT, Kevin Rushforth wrote: >> This is only done at compilation time, not at runtime. JEP 12 elaborates on >> this: >> >>> --enable-preview itself does not take a version number because it would be >>> easy to misinterpret. For example, on JDK 18, the (hypothetical

Withdrawn: 8277000: Tree-/TableRowSkin: replace listener to fixedCellSize by live lookup

2025-02-13 Thread duke
On Fri, 22 Nov 2024 20:31:08 GMT, Marius Hanl wrote: > This PR improves the `Tree-/TableRowSkin` code by doing a normal live lookup > for the `fixedCellSize` instead of adding listener just to update > variables(`fixedCellSizeEnabled` and `fixedCellSize`) which can otherwise be > also just loo

Re: RFR: 8349373: Support JavaFX preview features [v2]

2025-02-13 Thread Kevin Rushforth
On Fri, 7 Feb 2025 15:07:26 GMT, Michael Strauß wrote: >> modules/javafx.base/src/main/java/com/sun/javafx/PreviewFeature.java line 52: >> >>> 50: private static final String SUPPRESS_WARNING_PROPERTY = >>> "javafx.suppressPreviewBanner"; >>> 51: >>> 52: private static final boolean en

Re: RFR: 8349373: Support JavaFX preview features [v3]

2025-02-13 Thread Kevin Rushforth
On Fri, 7 Feb 2025 09:16:54 GMT, Michael Strauß wrote: >> This PR contains a definition of preview features for JavaFX, as well as a >> helper class to verify that an application has opted into preview features. > > Michael Strauß has updated the pull request incrementally with four > additiona

Re: RFR: 8313424: JavaFX controls in the title bar [v49]

2025-02-13 Thread Michael Strauß
> Implementation of > [`EXTENDED`](https://gist.github.com/mstr2/0befc541ee7297b6db2865cc5e4dbd09) > and `EXTENDED_UTILITY` stage style. Michael Strauß has updated the pull request incrementally with two additional commits since the last revision: - typo - update copyright headers -

Re: RFR: 8313424: JavaFX controls in the title bar [v47]

2025-02-13 Thread Michael Strauß
On Tue, 4 Feb 2025 20:51:59 GMT, Andy Goryachev wrote: > I wonder if the header bar needs to get clipped somehow: I don't think that's possible, layout containers never visually clip their contents (i.e. prevent pixels from being drawn). > (also weird padding around buttons in the left content

Re: RFR: 8313424: JavaFX controls in the title bar [v47]

2025-02-13 Thread Michael Strauß
On Tue, 4 Feb 2025 19:58:37 GMT, Andy Goryachev wrote: >> Michael Strauß has updated the pull request incrementally with one >> additional commit since the last revision: >> >> add "maximized" pseudo-class for custom maximize button > > modules/javafx.base/src/test/java/test/util/ReflectionUt

Re: RFR: 8313424: JavaFX controls in the title bar [v48]

2025-02-13 Thread Michael Strauß
On Thu, 13 Feb 2025 18:29:08 GMT, Michael Strauß wrote: >> Implementation of >> [`EXTENDED`](https://gist.github.com/mstr2/0befc541ee7297b6db2865cc5e4dbd09) >> and `EXTENDED_UTILITY` stage style. > > Michael Strauß has updated the pull request with a new target base due to a > merge or a rebas

Re: RFR: 8349255: TitledPane: exception initializing in a background thread

2025-02-13 Thread Kevin Rushforth
On Wed, 12 Feb 2025 19:10:30 GMT, Andy Goryachev wrote: >> ## Root Cause >> >> Animation was started in the background thread, causing concurrent access. >> >> ## Solution >> >> Disable animation if not the fx app thread. > > modules/javafx.graphics/src/main/java/javafx/scene/Node.java line 14

Re: RFR: 8349255: TitledPane: exception initializing in a background thread

2025-02-13 Thread Kevin Rushforth
On Wed, 12 Feb 2025 19:07:19 GMT, Andy Goryachev wrote: > ## Root Cause > > Animation was started in the background thread, causing concurrent access. > > ## Solution > > Disable animation if not the fx app thread. The fix looks good. I'll test it later. I left one comment about the change in

Re: RFR: 8313424: JavaFX controls in the title bar [v48]

2025-02-13 Thread Michael Strauß
> Implementation of > [`EXTENDED`](https://gist.github.com/mstr2/0befc541ee7297b6db2865cc5e4dbd09) > and `EXTENDED_UTILITY` stage style. Michael Strauß has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 62 commits: - Merge branch 'mas

Re: RFR: 8349256: Update PipeWire to 1.3.81

2025-02-13 Thread Kevin Rushforth
On Thu, 13 Feb 2025 11:54:01 GMT, Alexander Zvegintsev wrote: > This changeset updates the pipewire headers to the 1.3.81, and it is the same > as for the [OpenJDK](https://github.com/openjdk/jdk/pull/23426) > > It contains the minimum set of required header files needed to build the JFX. >

Integrated: 8349756: Memory leak in PaginationSkin when setting page count / index

2025-02-13 Thread Andy Goryachev
On Tue, 11 Feb 2025 15:46:17 GMT, Andy Goryachev wrote: > ## Root Cause > > Each time a `PaginationSkin.IndicatorButton` gets created it adds two > listeners (to the control's `styleClass` property and to the skin's > tooltipVisible property) via `ListenerHelper`. This was not detected by the

Re: RFR: 8349756: Memory leak in PaginationSkin when setting page count / index [v2]

2025-02-13 Thread Ambarish Rapte
On Tue, 11 Feb 2025 22:22:59 GMT, Andy Goryachev wrote: >> ## Root Cause >> >> Each time a `PaginationSkin.IndicatorButton` gets created it adds two >> listeners (to the control's `styleClass` property and to the skin's >> tooltipVisible property) via `ListenerHelper`. This was not detected b

Re: RFR: 8349256: Update PipeWire to 1.3.81

2025-02-13 Thread Lukasz Kostyra
On Thu, 13 Feb 2025 11:54:01 GMT, Alexander Zvegintsev wrote: > This changeset updates the pipewire headers to the 1.3.81, and it is the same > as for the [OpenJDK](https://github.com/openjdk/jdk/pull/23426) > > It contains the minimum set of required header files needed to build the JFX. >

Re: RFR: 8349256: Update PipeWire to 1.3.81

2025-02-13 Thread Kevin Rushforth
On Thu, 13 Feb 2025 11:54:01 GMT, Alexander Zvegintsev wrote: > This changeset updates the pipewire headers to the 1.3.81, and it is the same > as for the [OpenJDK](https://github.com/openjdk/jdk/pull/23426) > > It contains the minimum set of required header files needed to build the JFX. >

Re: RFR: 8349098: TabPane: exception initializing in a background thread [v2]

2025-02-13 Thread Ambarish Rapte
On Fri, 7 Feb 2025 18:42:01 GMT, Andy Goryachev wrote: >> ## Root Cause >> Animation gets started in a background thread, which causes the animation >> handler to run in the FX application thread, thus creating simultaneous >> access to the control's fields (list of children in this case). >>

RFR: 8349256: Update PipeWire to 1.3.81

2025-02-13 Thread Alexander Zvegintsev
This changeset updates the pipewire headers to the 1.3.81, and it is the same as for the [OpenJDK](https://github.com/openjdk/jdk/pull/23426) It contains the minimum set of required header files needed to build the JFX. The updated headers are a direct copy from the https://gitlab.freedesktop.o