On Fri, 7 Feb 2025 18:42:01 GMT, Andy Goryachev wrote:
>> ## Root Cause
>> Animation gets started in a background thread, which causes the animation
>> handler to run in the FX application thread, thus creating simultaneous
>> access to the control's fields (list of children in this case).
>>
On Wed, 5 Feb 2025 03:00:17 GMT, Alexander Matveev wrote:
> - Added new class `CMFGSTBuffer` which can allocate memory internally or
> provide GStreamer allocated memory to Media Foundation.
> - Added `GstBufferPool` to limit allocation of output buffers used for
> rendering (memory will not be
> - Added new class `CMFGSTBuffer` which can allocate memory internally or
> provide GStreamer allocated memory to Media Foundation.
> - Added `GstBufferPool` to limit allocation of output buffers used for
> rendering (memory will not be allocated for each buffer, but instead will be
> reused fr
On Wed, 12 Feb 2025 21:25:15 GMT, Kevin Rushforth wrote:
>> - Added new class `CMFGSTBuffer` which can allocate memory internally or
>> provide GStreamer allocated memory to Media Foundation.
>> - Added `GstBufferPool` to limit allocation of output buffers used for
>> rendering (memory will not
Yeah, it may be possible to do this; as said, I'm already storing a
StyleableProperty in the map (as it is needed to track the style origin
for the CSS system, otherwise it will never reset it when styles
changes), and exposing this property via a static property method would
certainly be trivial t
On Wed, 12 Feb 2025 23:45:55 GMT, Andy Goryachev wrote:
> What threw me off is the way javadoc for show() is currently phrased: "popup
> aspects" implies something else beyond the simple aspect, for example, it
> could be a visible property on a detail pane or selected tab/page.
>
> Should we
On Wed, 12 Feb 2025 23:03:45 GMT, Michael Strauß wrote:
> It's not clear to me that invoking actions on a node should count as
> "modifying"
I agree with this statement.
What threw me off is the way javadoc for `show()` is currently phrased: "popup
aspects" implies something else beyond the s
On Wed, 12 Feb 2025 20:15:03 GMT, Andy Goryachev wrote:
> ## Root Cause
>
> The ContextMenu (PopupWindow) cannot be shown in a background thread.
>
> ## Solution
>
> Bail out of `show()` if in a background thread.
One more reason to disallow show in this case is that ContextMenu is a
descend
On Wed, 12 Feb 2025 23:39:07 GMT, Andy Goryachev wrote:
> > 1. Change the spec and implementation to throw an exception if
> > `ComboBoxBaseSkin::show` is called on a thread other than the FX
> > Application Thread
>
> I like this option!
>
> Does it mean ColorPicker.show() should also throw?
On Wed, 12 Feb 2025 23:11:08 GMT, Kevin Rushforth wrote:
> 1. Change the spec and implementation to throw an exception if
> `ComboBoxBaseSkin::show` is called on a thread other than the FX Application
> Thread
I like this option!
Does it mean ColorPicker.show() should also throw?
---
On Wed, 12 Feb 2025 23:18:37 GMT, Kevin Rushforth wrote:
> Why did you call show in the first place in your NodeInitStressTest (for that
> matter, why directly call _any_ skin methods, since apps generally don't)
1. `show()` javadoc says "display the popup _**aspect**_ of the user
interface",
On Wed, 12 Feb 2025 19:45:32 GMT, Andy Goryachev wrote:
> ## Root Cause
>
> Focus is being requested in show(), even a background thread.
>
> ## Solution
>
> Do not request focus if in a background thread.
Even after considering option 3, I prefer option 1. I can't think of a good
reason to
On Wed, 12 Feb 2025 20:15:03 GMT, Andy Goryachev wrote:
> ## Root Cause
>
> The ContextMenu (PopupWindow) cannot be shown in a background thread.
>
> ## Solution
>
> Bail out of `show()` if in a background thread.
Let's resolve the general question regarding what to do about the various
`*Sk
On Wed, 12 Feb 2025 19:45:32 GMT, Andy Goryachev wrote:
> ## Root Cause
>
> Focus is being requested in show(), even a background thread.
>
> ## Solution
>
> Do not request focus if in a background thread.
I took a quick look at PR #1709 which has a similar problem with its show
method, and
On Wed, 12 Feb 2025 19:45:32 GMT, Andy Goryachev wrote:
> ## Root Cause
>
> Focus is being requested in show(), even a background thread.
>
> ## Solution
>
> Do not request focus if in a background thread.
I'm not sure this fix is sufficient in all cases.
As I mentioned in the bug report, I
On Wed, 12 Feb 2025 20:15:03 GMT, Andy Goryachev wrote:
> ## Root Cause
>
> The ContextMenu (PopupWindow) cannot be shown in a background thread.
>
> ## Solution
>
> Bail out of `show()` if in a background thread.
I'm not convinced that this is the right solution.
`Node` says:
* Node objec
On Wed, 12 Feb 2025 19:45:32 GMT, Andy Goryachev wrote:
> ## Root Cause
>
> Focus is being requested in show(), even a background thread.
>
> ## Solution
>
> Do not request focus if in a background thread.
Reviewers: @kevinrushforth @arapte
-
PR Comment: https://git.openjdk.org/
On Wed, 5 Feb 2025 03:00:17 GMT, Alexander Matveev wrote:
> - Added new class `CMFGSTBuffer` which can allocate memory internally or
> provide GStreamer allocated memory to Media Foundation.
> - Added `GstBufferPool` to limit allocation of output buffers used for
> rendering (memory will not be
## Root Cause
The ContextMenu (PopupWindow) cannot be shown in a background thread.
## Solution
Bail out of `show()` if in a background thread.
-
Commit messages:
- split / menu button fix
Changes: https://git.openjdk.org/jfx/pull/1709/files
Webrev: https://webrevs.openjdk.org/
## Root Cause
Focus is being requested in show(), even a background thread.
## Solution
Do not request focus if in a background thread.
-
Commit messages:
- date picker fix
Changes: https://git.openjdk.org/jfx/pull/1708/files
Webrev: https://webrevs.openjdk.org/?repo=jfx&pr=170
On Wed, 12 Feb 2025 19:07:19 GMT, Andy Goryachev wrote:
> ## Root Cause
>
> Animation was started in the background thread, causing concurrent access.
>
> ## Solution
>
> Disable animation if not the fx app thread.
modules/javafx.graphics/src/main/java/javafx/scene/Node.java line 1442:
> 144
## Root Cause
Animation was started in the background thread, causing concurrent access.
## Solution
Disable animation if not the fx app thread.
-
Commit messages:
- the fix
- Merge branch 'master' into 8349255.thread.safe.titled.pane
- Merge branch 'master' into 8349255.thread.
I would love to be able to do this.
Dirk
> Am 11.02.2025 um 23:47 schrieb John Hendrikx :
>
> Hi list,
>
> I've done a little proof of concept where I've made some minor modifications
> to CssStyleHelper to allow the CSS engine to offer styleable properties on
> children, but defined by the
Maybe we can expand static properties to complete JavaFX properties.
Right now, static properties are implemented with a getter and setter
on the declaring class. We can add an additional property getter like
so:
class HBox {
public static ObjectProperty marginProperty(Node child);
public
On Wed, 12 Feb 2025 17:39:57 GMT, Andy Goryachev wrote:
>> Root Cause:
>> (Multiple) properties are getting bound to the global
>> `Platform.accessibilityActive` property. Binding (and I say, accessing) of
>> properties is not thread-safe.
>>
>> I also changed the design a bit. Originally, ev
> Root Cause:
> (Multiple) properties are getting bound to the global
> `Platform.accessibilityActive` property. Binding (and I say, accessing) of
> properties is not thread-safe.
>
> I also changed the design a bit. Originally, every symbol in a chart had its
> `focusTraversableProperty` boun
On Wed, 12 Feb 2025 09:59:30 GMT, Alexander Zuev wrote:
> I am curious why do we make labels in charts focus traversable when a11y is
> switched on?
I think the reason is to announce the axis values for each data point (that's
what the VoiceOver announces on macOS for me) - you can readily try
On Mon, 10 Feb 2025 15:27:49 GMT, Jay Bhaskar wrote:
> Webkit JavaFx upgrade from 619.1 to 620.1
> Build is verified in mac , windows and linux. Sanity testing looks fine. No
> issues seen, except one observed CanvasPattern test where it works only on
> Linux but failed on Mac/Windows (WIP).
>
Thanks,
I may need some help with the transition part when the time arrives. In
CssStyleHelper these parent defined properties are treated no different
from any other properties, but I think some of the transition logic is
part of the properties themselves and I didn't implement that so far.
How
This looks like a nice enhancement. The syntax is similar to CSS
features like Grid Layout [0] ("grid-column" and "grid-row" are
properties on children of a grid container). We need to figure out how
these extension properties work with transitions. They should follow
the same transition rules as
On Tue, 11 Feb 2025 18:29:08 GMT, Kevin Rushforth wrote:
>> modules/javafx.web/src/main/native/Source/WTF/wtf/java/FileSystemJava.cpp
>> line 1:
>>
>>> 1: /*
>>
>> I would recommend to add "fprintf(stderr, XXX NOT IMPLEMENTED\n");" outputs
>> to the the four changed / new functions stubs, as
On Fri, 7 Feb 2025 18:43:32 GMT, Andy Goryachev wrote:
>> Root Cause:
>> (Multiple) properties are getting bound to the global
>> `Platform.accessibilityActive` property. Binding (and I say, accessing) of
>> properties is not thread-safe.
>>
>> I also changed the design a bit. Originally, eve
On Mon, 10 Feb 2025 15:27:49 GMT, Jay Bhaskar wrote:
> Webkit JavaFx upgrade from 619.1 to 620.1
> Build is verified in mac , windows and linux. Sanity testing looks fine. No
> issues seen, except one observed CanvasPattern test where it works only on
> Linux but failed on Mac/Windows (WIP).
>
On Thu, 16 Jan 2025 14:29:31 GMT, Thiago Milczarek Sayao
wrote:
>> Thiago Milczarek Sayao has updated the pull request with a new target base
>> due to a merge or a rebase. The pull request now contains 120 commits:
>>
>> - Merge branch 'master' into new_ime
>>
>># Conflicts:
>>#
34 matches
Mail list logo
