On Wed, 12 Feb 2025 23:18:37 GMT, Kevin Rushforth <k...@openjdk.org> wrote:

> Why did you call show in the first place in your NodeInitStressTest (for that 
> matter, why directly call _any_ skin methods, since apps generally don't)

1. `show()` javadoc says "display the popup _**aspect**_ of the user 
interface", which I interpreted as something that could in theory be an 
acceptable operation.  For example, ColorPicker does not fail in its `show()`.

2. `show()` is not a skin method (see `ComboBoxBase`).  The reason the skin is 
explicitly set in the test is because (in theory) we ought to support custom 
controls and/or custom skins.  In other words, calling `Control.setSkin()` from 
a background thread is also an acceptable operation.

-------------

PR Comment: https://git.openjdk.org/jfx/pull/1708#issuecomment-2655077467

Reply via email to