Re: RFR: 8335470: [XWayland] JavaFX tests that use AWT Robot fail on Wayland

2024-12-10 Thread Kevin Rushforth
On Tue, 10 Dec 2024 14:10:23 GMT, Alexander Zvegintsev wrote: > This PR enables several previously disabled test cases for Wayland, as the > required fixes are already in the promoted build. > ([JDK-8335469](https://bugs.openjdk.org/browse/JDK-8335469), > [JDK-8335468](https://bugs.openjdk.or

Re: RFR: 8345937: Update JUnit Platform to newest version

2024-12-10 Thread Kevin Rushforth
On Tue, 10 Dec 2024 18:07:44 GMT, Marius Hanl wrote: > The JUnit Platform got some updates over the last years, so it is a good idea > to update it to the newest version. > > That is from `5.8.1` to `5.11.3`. > Affected dependencies: > - `junit.jupiter` > - `junit.platform` > - `opentest4j` >

Re: RFR: 8341670: [Text, TextFlow] Public API for Text Layout Info [v13]

2024-12-10 Thread Andy Goryachev
> Please refer to > > https://github.com/andy-goryachev-oracle/Test/blob/main/doc/Text/LayoutInfo.md > > The RichTextArea control > ([JDK-8301121](https://bugs.openjdk.org/browse/JDK-8301121)), or any custom > control that needs non-trivial navigation within complex or wrapped text > needs a p

Re: RFR: 8277000: Tree-/TableRowSkin: replace listener to fixedCellSize by live lookup [v2]

2024-12-10 Thread Andy Goryachev
On Tue, 10 Dec 2024 22:28:46 GMT, Marius Hanl wrote: >> it's hard to tell (for me): there are just too many conditions: >> isColumnParticallyOrFullVisible(), if parent == null... > > It will be much better after https://github.com/openjdk/jfx/pull/1644 :) can you apply the same treatment as in

Re: RFR: 8277000: Tree-/TableRowSkin: replace listener to fixedCellSize by live lookup [v2]

2024-12-10 Thread Marius Hanl
On Tue, 10 Dec 2024 22:03:04 GMT, Andy Goryachev wrote: >> Yes, IntelliJ actually gave me the hint. >> `isVisible` can only be `false`, when a `fixedCellSize` is set. So the else >> branch can only ever be executed when `fixedCellSize > 0` > > it's hard to tell (for me): there are just too many

Re: RFR: 8313424: JavaFX controls in the title bar [v36]

2024-12-10 Thread Michael Strauß
> Implementation of [`EXTENDED` stage > style](https://gist.github.com/mstr2/0befc541ee7297b6db2865cc5e4dbd09). Michael Strauß has updated the pull request incrementally with one additional commit since the last revision: fix resizable states for GTK windows - Changes: - all:

Re: RFR: 8277000: Tree-/TableRowSkin: replace listener to fixedCellSize by live lookup [v2]

2024-12-10 Thread Marius Hanl
On Tue, 10 Dec 2024 21:10:54 GMT, Andy Goryachev wrote: >> Marius Hanl has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains three additional >> commi

Re: RFR: 8277000: Tree-/TableRowSkin: replace listener to fixedCellSize by live lookup [v2]

2024-12-10 Thread Andy Goryachev
On Tue, 10 Dec 2024 21:56:07 GMT, Marius Hanl wrote: >> modules/javafx.controls/src/main/java/javafx/scene/control/skin/TableRowSkinBase.java >> line 421: >> >>> 419: } else { >>> 420: width = tableCell.prefWidth(height); >>> 421: // we only add/remov

Re: RFR: 8277000: Tree-/TableRowSkin: replace listener to fixedCellSize by live lookup [v2]

2024-12-10 Thread Andy Goryachev
On Mon, 9 Dec 2024 23:55:01 GMT, Marius Hanl wrote: >> This PR improves the `Tree-/TableRowSkin` code by doing a normal live lookup >> for the `fixedCellSize` instead of adding listener just to update >> variables(`fixedCellSizeEnabled` and `fixedCellSize`) which can otherwise be >> also just

Re: RFR: 8301121: RichTextArea Control (Incubator) [v60]

2024-12-10 Thread Kevin Rushforth
On Tue, 10 Dec 2024 20:41:19 GMT, Andy Goryachev wrote: >> Incubating a new feature - rich text control, **RichTextArea**, intended to >> bridge the functional gap with Swing and its StyledEditorKit/JEditorPane. >> The main design goal is to provide a control that is complete enough to be >> u

Re: RFR: 8185887: TableRowSkinBase fails to correctly virtualize cells in horizontal direction [v3]

2024-12-10 Thread Andy Goryachev
On Mon, 9 Dec 2024 23:23:59 GMT, Marius Hanl wrote: >> This PR fixes the horizontal virtualization performed in the >> `TableRowSkinBase`, which significantly improves performance with many >> columns (and thus many cells). Scrolling up and down as well as scrolling >> left and right feels muc

Re: RFR: 8301121: RichTextArea Control (Incubator) [v60]

2024-12-10 Thread Andy Goryachev
> Incubating a new feature - rich text control, **RichTextArea**, intended to > bridge the functional gap with Swing and its StyledEditorKit/JEditorPane. The > main design goal is to provide a control that is complete enough to be useful > out-of-the box, as well as open to extension by the appl

Re: RFR: 8301121: RichTextArea Control (Incubator) [v59]

2024-12-10 Thread Andy Goryachev
> Incubating a new feature - rich text control, **RichTextArea**, intended to > bridge the functional gap with Swing and its StyledEditorKit/JEditorPane. The > main design goal is to provide a control that is complete enough to be useful > out-of-the box, as well as open to extension by the appl

Re: RFR: 8301121: RichTextArea Control (Incubator) [v58]

2024-12-10 Thread Andy Goryachev
> Incubating a new feature - rich text control, **RichTextArea**, intended to > bridge the functional gap with Swing and its StyledEditorKit/JEditorPane. The > main design goal is to provide a control that is complete enough to be useful > out-of-the box, as well as open to extension by the appl

Re: RFR: 8313424: JavaFX controls in the title bar [v35]

2024-12-10 Thread Michael Strauß
> Implementation of [`EXTENDED` stage > style](https://gist.github.com/mstr2/0befc541ee7297b6db2865cc5e4dbd09). Michael Strauß has updated the pull request incrementally with one additional commit since the last revision: add StageStyle.EXTENDED_UTILITY - Changes: - all: https

Re: RFR: 8301121: RichTextArea Control (Incubator) [v57]

2024-12-10 Thread Andy Goryachev
> Incubating a new feature - rich text control, **RichTextArea**, intended to > bridge the functional gap with Swing and its StyledEditorKit/JEditorPane. The > main design goal is to provide a control that is complete enough to be useful > out-of-the box, as well as open to extension by the appl

Re: RFR: 8313424: JavaFX controls in the title bar [v34]

2024-12-10 Thread Michael Strauß
> Implementation of [`EXTENDED` stage > style](https://gist.github.com/mstr2/0befc541ee7297b6db2865cc5e4dbd09). Michael Strauß has updated the pull request incrementally with one additional commit since the last revision: fix system menu for non-resizeable extended window - Chan

Re: RFR: 8301121: RichTextArea Control (Incubator) [v56]

2024-12-10 Thread Kevin Rushforth
On Thu, 5 Dec 2024 21:02:35 GMT, Andy Goryachev wrote: >> Incubating a new feature - rich text control, **RichTextArea**, intended to >> bridge the functional gap with Swing and its StyledEditorKit/JEditorPane. >> The main design goal is to provide a control that is complete enough to be >> us

RFR: 8345937: Update JUnit Platform to newest version

2024-12-10 Thread Marius Hanl
The JUnit Platform got some updates over the last years, so it is a good idea to update it to the newest version. That is from `5.8.1` to `5.11.3`. Affected dependencies: - `junit.jupiter` - `junit.platform` - `opentest4j` Release notes: https://junit.org/junit5/docs/5.11.3/release-notes/ Note:

Re: RFR: 8313424: JavaFX controls in the title bar [v33]

2024-12-10 Thread Michael Strauß
> Implementation of [`EXTENDED` stage > style](https://gist.github.com/mstr2/0befc541ee7297b6db2865cc5e4dbd09). Michael Strauß has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 42 commits: - Merge branch 'master' into feature/extended

Re: [External] : Re: Focus delegation API

2024-12-10 Thread Andy Goryachev
Michael: Please help me understand. How does the idea of focus delegation works with multiple inner nodes that are supposed to handle different aspects of a complex control? For example, a custom combo box-like control may contain an editor (possibly created dynamically), may be a couple of b

Re: RFR: 8335470: [XWayland] JavaFX tests that use AWT Robot fail on Wayland

2024-12-10 Thread Alexander Zvegintsev
On Tue, 10 Dec 2024 14:49:34 GMT, Kevin Rushforth wrote: >> This PR enables several previously disabled test cases for Wayland, as the >> required fixes are already in the promoted build. >> ([JDK-8335469](https://bugs.openjdk.org/browse/JDK-8335469), >> [JDK-8335468](https://bugs.openjdk.org/

Re: RFR: 8335470: [XWayland] JavaFX tests that use AWT Robot fail on Wayland

2024-12-10 Thread Kevin Rushforth
On Tue, 10 Dec 2024 14:10:23 GMT, Alexander Zvegintsev wrote: > This PR enables several previously disabled test cases for Wayland, as the > required fixes are already in the promoted build. > ([JDK-8335469](https://bugs.openjdk.org/browse/JDK-8335469), > [JDK-8335468](https://bugs.openjdk.or

RFR: 8335470: [XWayland] JavaFX tests that use AWT Robot fail on Wayland

2024-12-10 Thread Alexander Zvegintsev
This PR enables several previously disabled test cases for Wayland, as the required fixes are already in the promoted build. ([JDK-8335469](https://bugs.openjdk.org/browse/JDK-8335469), [JDK-8335468](https://bugs.openjdk.org/browse/JDK-8335468)) - Commit messages: - check JDK vers

Re: [External] : Re: Focus delegation API

2024-12-10 Thread Kevin Rushforth
On 12/9/2024 6:16 PM, Michael Strauß wrote: Yep, this seems unnecessary and counterproductive to me. All we need is to drop the target field from the event. I can't image that we would ever do this, considering that events have been there almost from the beginning. We'd break half of the J

Re: RFR: 8305418: [Linux] Replace obsolete XIM as Input Method Editor [v31]

2024-12-10 Thread Helly Guo
On Mon, 9 Dec 2024 17:25:58 GMT, Martin Fox wrote: >> modules/javafx.graphics/src/main/native-glass/gtk/glass_window_ime.cpp line >> 100: >> >>> 98: >>> 99: void WindowContextBase::commitIME(gchar *str) { >>> 100: if (im_ctx.on_preedit) { >> >> Through `LOG0`/`LOG1`, I found that the valu

[jfx17u] RFR: 8345870: Failed to compile test/javafx/scene/web/CSSRoundingTest.java after 8336798

2024-12-10 Thread Sergey Chernyshev
Hi, this PR fixes the build failure after backporting JDK-8336798 [1]. The test CSSRoundingTest.java uses multiline string literals, that are not supported with -source 11. [1] https://bugs.openjdk.org/browse/JDK-8336798 - Commit messages: - 8345870: Failed to compile test/javafx

Integrated: 8344111: Remove obsolete permission check methods from javafx.graphics

2024-12-10 Thread Lukasz Kostyra
On Fri, 6 Dec 2024 16:38:14 GMT, Lukasz Kostyra wrote: > This PR removes obsolete permission checks from javafx.graphics _minus_ Font > classes (handled by a separate PR). > > The only part I did not remove from methods/fields listed in the issue is > `WindowStage.fullScreenFromUserEvent`. Thi

Integrated: 8344114: Remove obsolete permission check methods from Font classes

2024-12-10 Thread Lukasz Kostyra
On Fri, 6 Dec 2024 16:40:14 GMT, Lukasz Kostyra wrote: > This PR removes obsolete permission check methods and fields from > Font-related classes. > > Verified the changes on Windows, did not see any regressions. This pull request has now been integrated. Changeset: ebeee751 Author:Lukasz