On Tue, 10 Dec 2024 18:07:44 GMT, Marius Hanl <mh...@openjdk.org> wrote:
> The JUnit Platform got some updates over the last years, so it is a good idea > to update it to the newest version. > > That is from `5.8.1` to `5.11.3`. > Affected dependencies: > - `junit.jupiter` > - `junit.platform` > - `opentest4j` > > Release notes: https://junit.org/junit5/docs/5.11.3/release-notes/ > > Note: > I did a handful of CI runs and got a test failure once in > `ServiceLifecycleTest`. Not sure yet if related to the update or not. Because this has third-party and build implications, I need to review it. Since it is a test-only usage (we don't distribute anything from it), we don't need to get new approval as long as the license is unchanged (I'll double-check). Reviewers: @kevinrushforth @arapte > got a test failure once in ServiceLifecycleTest. Not sure yet if related to > the update or not. I doubt it. There is at least one test there that is prone to intermittent failures on some (usually slower) systems. ------------- PR Comment: https://git.openjdk.org/jfx/pull/1662#issuecomment-2533343033 PR Comment: https://git.openjdk.org/jfx/pull/1662#issuecomment-2533343804
