Re: RFR: 8342461: Remove calls to doPrivileged in javafx.web/{android,ios}

2024-11-27 Thread Johan Vos
On Wed, 27 Nov 2024 22:54:01 GMT, Jose Pereda wrote: > Removes `doPrivileged` remaining calls in the `javafx.web` module included in > {android,ios} code. Looks good. There is much more cleanup work to do, but that is clearly not in scope for this PR. - Marked as reviewed by jvos

Re: RFR: 8342461: Remove calls to doPrivileged in javafx.web/{android,ios}

2024-11-27 Thread Kevin Rushforth
On Wed, 27 Nov 2024 22:54:01 GMT, Jose Pereda wrote: > Removes `doPrivileged` remaining calls in the `javafx.web` module included in > {android,ios} code. Looks good. Since I can't test it, @johanvos might want to review. - Marked as reviewed by kcr (Lead). PR Review: https://git

RFR: 8342461: Remove calls to doPrivileged in javafx.web/{android, ios}

2024-11-27 Thread Jose Pereda
Removes `doPrivileged` remaining calls in the `javafx.web` module included in {android,ios} code. - Commit messages: - Remove calls to doPrivileged in javafx.web for android and ios Changes: https://git.openjdk.org/jfx/pull/1651/files Webrev: https://webrevs.openjdk.org/?repo=jfx

Integrated: 8345063: Centralize version number of the Gradle build file

2024-11-27 Thread Nir Lisker
On Tue, 26 Nov 2024 16:03:38 GMT, Nir Lisker wrote: > Centralizes version numbers in a single place. This is not the best way of > doing it in Gradle, but it's an improvement that will simplify other changes. > I used the `build.properties` file because other versions are already written > the

Re: RFR: 8309381: Support JavaFX incubator modules [v2]

2024-11-27 Thread Nir Lisker
On Fri, 22 Nov 2024 16:36:02 GMT, Kevin Rushforth wrote: >> This PR add the necessary support for [JavaFX Incubator >> Modules](https://github.com/kevinrushforth/jfx/blob/jfx.incubator/INCUBATOR-MODULES.md). >> It includes the following: >> >> 1. Changes to the build scripts `build.gradle` and

Re: RFR: 8344899: Map RT-nnnn bug IDs to JDK-mmmmmmm in JavaFX sources [v2]

2024-11-27 Thread Kevin Rushforth
On Tue, 26 Nov 2024 08:59:10 GMT, Marius Hanl wrote: >> This PR changes all `RT-` references to `JDK-XXX`. >> It also removes all `http://javafx-jira.kenai.com/browse/` occurrences. >> >> As discussed, this will help a lot when looking up old issues, especially >> since not everybody kn

Integrated: 8344906: Simplify Java version parsing in the build file

2024-11-27 Thread Nir Lisker
On Sat, 23 Nov 2024 09:22:36 GMT, Nir Lisker wrote: > Replaces the manual versions handling with > [Version](https://docs.oracle.com/en/java/javase/23/docs/api/java.base/java/lang/Runtime.Version.html). > > Changes: > * Removed the methods `parseJavaVersion(String)`, `parseJdkVersion(String)`

Re: RFR: 8342233: Regression: TextInputControl selection is backwards in RTL mode

2024-11-27 Thread Lukasz Kostyra
On Fri, 25 Oct 2024 22:00:37 GMT, Andy Goryachev wrote: > A fix for [JDK-8319844](https://bugs.openjdk.org/browse/JDK-8319844) > Text/TextFlow.hitTest() introduced a regression in the > `TextArea`/`TextField`/`PasswordField` in the RTL mode. > > The fix is to flip the x coordinates when needed

Re: RFR: 8343336: Add persistentScrollBars preference [v6]

2024-11-27 Thread Kevin Rushforth
On Wed, 27 Nov 2024 13:50:11 GMT, Michael Strauß wrote: >> modules/javafx.graphics/src/main/native-glass/gtk/PlatformSupport.cpp line >> 125: >> >>> 123: putBoolean(env, prefs, "GTK.enable_animations", >>> enableAnimations); >>> 124: >>> 125: if (g_object_class_find_property(G

Re: RFR: 8343336: Add persistentScrollBars preference [v6]

2024-11-27 Thread Michael Strauß
On Wed, 27 Nov 2024 13:09:23 GMT, Kevin Rushforth wrote: >> Michael Strauß has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains six additional >> com

Re: RFR: 8344906: Simplify Java version parsing in the build file [v2]

2024-11-27 Thread Ambarish Rapte
On Wed, 27 Nov 2024 10:35:18 GMT, Nir Lisker wrote: >> Replaces the manual versions handling with >> [Version](https://docs.oracle.com/en/java/javase/23/docs/api/java.base/java/lang/Runtime.Version.html). >> >> Changes: >> * Removed the methods `parseJavaVersion(String)`, `parseJdkVersion(Strin

Re: RFR: 8344906: Simplify Java version parsing in the build file [v2]

2024-11-27 Thread Kevin Rushforth
On Wed, 27 Nov 2024 10:35:18 GMT, Nir Lisker wrote: >> Replaces the manual versions handling with >> [Version](https://docs.oracle.com/en/java/javase/23/docs/api/java.base/java/lang/Runtime.Version.html). >> >> Changes: >> * Removed the methods `parseJavaVersion(String)`, `parseJdkVersion(Strin

Re: RFR: 8343336: Add persistentScrollBars preference [v6]

2024-11-27 Thread Kevin Rushforth
On Wed, 27 Nov 2024 00:26:16 GMT, Michael Strauß wrote: >> This PR adds another accessibility preference that is available on all >> supported desktop platforms: >> >> 1. **Windows**: Settings -> Accessibility -> Visual Effects -> Always show >> scroll bars >> 2. **macOS**: System Settings ->

Re: RFR: 8339603: Seal the class hierarchy of Node, Camera, LightBase, Shape, Shape3D [v8]

2024-11-27 Thread Michael Strauß
On Tue, 26 Nov 2024 21:29:38 GMT, Kevin Rushforth wrote: >> Michael Strauß has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains eight commits: >> >> - Merge branch 'master' into feature/sealed-classes >> - Merge branch 'master' into

Re: RFR: 8344906: Simplify Java version parsing in the build file [v2]

2024-11-27 Thread Nir Lisker
> Replaces the manual versions handling with > [Version](https://docs.oracle.com/en/java/javase/23/docs/api/java.base/java/lang/Runtime.Version.html). > > Changes: > * Removed the methods `parseJavaVersion(String)`, `parseJdkVersion(String)` > and `compareJdkVersion(String, String)`, and replace