On Fri, 22 Nov 2024 16:36:02 GMT, Kevin Rushforth wrote:
>> This PR add the necessary support for [JavaFX Incubator
>> Modules](https://github.com/kevinrushforth/jfx/blob/jfx.incubator/INCUBATOR-MODULES.md).
>> It includes the following:
>>
>> 1. Changes to the build scripts `build.gradle` and
A fix for [JDK-8319844](https://bugs.openjdk.org/browse/JDK-8319844)
Text/TextFlow.hitTest() introduced a regression in the
`TextArea`/`TextField`/`PasswordField` in the RTL mode.
The fix is to flip the x coordinates when needed in the
`TextAreaSkin`/`TextFieldSkin`.
The RTL node orientation a
On Fri, 25 Oct 2024 22:00:37 GMT, Andy Goryachev wrote:
> A fix for [JDK-8319844](https://bugs.openjdk.org/browse/JDK-8319844)
> Text/TextFlow.hitTest() introduced a regression in the
> `TextArea`/`TextField`/`PasswordField` in the RTL mode.
>
> The fix is to flip the x coordinates when needed
On Fri, 22 Nov 2024 19:51:18 GMT, Andy Goryachev wrote:
>> Martin Fox has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Tweak to satisfy system test.
>
> I'll take a look at it after Thanksgiving.
>
> Somewhat related questions (sorry if
On Fri, 22 Nov 2024 16:19:50 GMT, Andy Goryachev wrote:
>> Please refer to
>>
>> https://github.com/andy-goryachev-oracle/Test/blob/main/doc/Text/LayoutInfo.md
>>
>> The RichTextArea control
>> ([JDK-8301121](https://bugs.openjdk.org/browse/JDK-8301121)), or any custom
>> control that needs n
On Fri, 22 Nov 2024 21:21:34 GMT, Andy Goryachev wrote:
>> That is correct. I still think it's worth it, especially since not everyone
>> knows the 'trick' of pasting the `RT-` entry into the bug tracker to get the
>> corresponding `JDK-` entry (in fact, I only learned that this year 😄)
>
> I'd
All,
If you have backports that you want to get into jfx23u for JavaFX
23.0.2, please do so by Monday, December 2nd. Note that approval from
one of the project leads is needed as outlined in this message [1].
Thanks.
-- Kevin
[1] https://mail.openjdk.org/pipermail/openjfx-dev/2024-July/0480
On Fri, 22 Nov 2024 21:13:42 GMT, Marius Hanl wrote:
>> and maybe fix the RT- references as well, though it might be a bit harder
>> because a lookup is required.
>
> That is correct. I still think it's worth it, especially since not everyone
> knows the 'trick' of pasting the `RT-` entry into
On Fri, 22 Nov 2024 18:09:07 GMT, Andy Goryachev wrote:
>> maybe we we should do a small cleanup ticket where we replace all `JBS-` and
>> `RT-` references with the `JDK-` one? A quick check led to around 120
>> occurrences.
>
> and maybe fix the RT- references as well, though it might be a bit
On Fri, 22 Nov 2024 20:55:27 GMT, Kevin Rushforth wrote:
> We will need to check that this doesn't impact accessibility, since there are
> some "interesting" cases where cells are requested and a layout pass is done
> even when they aren't visible.
Good point! Checking `getPrivateCell`, I wond
On Fri, 22 Nov 2024 16:45:36 GMT, Marius Hanl wrote:
>> This PR fixes the horizontal virtualization performed in the
>> `TableRowSkinBase`, which significantly improves performance with many
>> columns (and thus many cells). Scrolling up and down as well as scrolling
>> left and right feels mu
On Fri, 22 Nov 2024 20:31:08 GMT, Marius Hanl wrote:
> This PR improves the `Tree-/TableRowSkin` code by doing a normal live lookup
> for the `fixedCellSize` instead of adding listener just to update
> variables(`fixedCellSizeEnabled` and `fixedCellSize`) which can otherwise be
> also just loo
This PR improves the `Tree-/TableRowSkin` code by doing a normal live lookup
for the `fixedCellSize` instead of adding listener just to update
variables(`fixedCellSizeEnabled` and `fixedCellSize`) which can otherwise be
also just lookup'd without the hassle of listeners.
While this is mostly a
On Fri, 22 Nov 2024 19:57:15 GMT, Andy Goryachev wrote:
> could you create a draft PR for v2, so we can leave comments?
Done. I created Draft PR #1646
-
PR Comment: https://git.openjdk.org/jfx/pull/1616#issuecomment-2494748813
On Tue, 5 Nov 2024 22:38:52 GMT, Andy Goryachev wrote:
>> Kevin Rushforth has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains three additional
>> co
On Tue, 12 Nov 2024 15:08:11 GMT, Martin Fox wrote:
>> Input methods don’t work for text controls inside Popups. This PR fixes that.
>>
>> Some background:
>>
>> A PopupWindow always has an owner. The owner of the first Popup is a
>> standard Window; I’ll refer to that as the root window. But
On Fri, 22 Nov 2024 16:36:02 GMT, Kevin Rushforth wrote:
>> This PR add the necessary support for [JavaFX Incubator
>> Modules](https://github.com/kevinrushforth/jfx/blob/jfx.incubator/INCUBATOR-MODULES.md).
>> It includes the following:
>>
>> 1. Changes to the build scripts `build.gradle` and
> I don't see how these problems are at all related.
I failed to explain it clearly then. I'll try to write up a more detailed
explanation after Thanksgiving.
-andy
From: openjfx-dev on behalf of Michael Strauß
Date: Wednesday, November 20, 2024 at 14:42
To:
Cc: openjfx-dev
Subject: Re: F
On Fri, 22 Nov 2024 18:05:36 GMT, Marius Hanl wrote:
>> modules/javafx.controls/src/main/java/javafx/scene/control/skin/TableHeaderRow.java
>> line 641:
>>
>>> 639:
>>> 640: final CheckMenuItem _item = item;
>>> 641: // fake bidrectional binding (a real one was used her
On Mon, 18 Nov 2024 16:13:35 GMT, Andy Goryachev wrote:
>> Marius Hanl has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> 8341687: Add more tests
>
> modules/javafx.controls/src/main/java/javafx/scene/control/skin/TableHeaderRow.java
> lin
> Incubating a new feature - rich text control, **RichTextArea**, intended to
> bridge the functional gap with Swing and its StyledEditorKit/JEditorPane. The
> main design goal is to provide a control that is complete enough to be useful
> out-of-the box, as well as open to extension by the appl
> Incubating a new feature - rich text control, **RichTextArea**, intended to
> bridge the functional gap with Swing and its StyledEditorKit/JEditorPane. The
> main design goal is to provide a control that is complete enough to be useful
> out-of-the box, as well as open to extension by the appl
So I tried to catch the issue with the property enabled, but it only
occurred at times when it was not enabled. And when I enabled the
property after that, the issue didn't show up again ... It's still very
rare, but I think I have narrowed it down to it only occuring when the
main memory of th
On Fri, 22 Nov 2024 17:10:32 GMT, Marius Hanl wrote:
>> There are multiple issues in the `TableMenu` logic that result in a memory
>> leak.
>>
>> The following problems are now fixed with this PR:
>> - The listener, that is registered to the `col.visibleProperty()` was not
>> weak nor was it e
On Mon, 18 Nov 2024 20:21:29 GMT, Andy Goryachev wrote:
>> I tried, but it isn't that easy - since the memory is not leaked because we
>> keep some references we should not keep - rather we are adding listener
>> again and again and again. So we can not assert things to be collectable, as
>> t
> There are multiple issues in the `TableMenu` logic that result in a memory
> leak.
>
> The following problems are now fixed with this PR:
> - The listener, that is registered to the `col.visibleProperty()` was not
> weak nor was it ever unregistered
>- The fix is to do pretty much the same
So I tried to catch the issue with the property enabled, but it only
occurred at times when it was not enabled. And when I enabled the
property after that, the issue didn't show up again ... It's still very
rare, but I think I have narrowed it down to it only occuring when the
main memory of th
> This PR fixes the horizontal virtualization performed in the
> `TableRowSkinBase`, which significantly improves performance with many
> columns (and thus many cells). Scrolling up and down as well as scrolling
> left and right feels much more snappy.
>
> In order to do that, there are multipl
This PR fixes the horizontal virtualization performed in the
`TableRowSkinBase`, which significantly improves performance with many columns
(and thus many cells). Scrolling up and down as well as scrolling left and
right feels much more snappy.
In order to do that, there are multiple things nee
> This PR add the necessary support for [JavaFX Incubator
> Modules](https://github.com/kevinrushforth/jfx/blob/jfx.incubator/INCUBATOR-MODULES.md).
> It includes the following:
>
> 1. Changes to the build scripts `build.gradle` and `settings.gradle` to
> document where to add your incubator mo
> Please refer to
>
> https://github.com/andy-goryachev-oracle/Test/blob/main/doc/Text/LayoutInfo.md
>
> The RichTextArea control
> ([JDK-8301121](https://bugs.openjdk.org/browse/JDK-8301121)), or any custom
> control that needs non-trivial navigation within complex or wrapped text
> needs a p
So I tried to catch the issue with the property enabled, but it only
occurred at times when it was not enabled. And when I enabled the
property after that, the issue didn't show up again ...
It's still very rare, but I think I have narrowed it down to it only
occuring when the main memory of t
Congratulations, Jayathirth D V!
-andy
From: openjfx-dev on behalf of Kevin Rushforth
Date: Friday, November 22, 2024 at 06:49
To: registrar , Jayathirth Rao Daarapuram Venkatesh
Murthy
Cc: openjfx-dev
Subject: Result: New OpenJFX Committer: Jayathirth D V
Voting for Jayathirth D V [1] to O
Voting for Jayathirth D V [1] to OpenJFX Committer [2] is now closed.
Yes: 9
Veto: 0
Abstain: 0
According to the Bylaws definition of Lazy Consensus, this is sufficient
to approve the nomination.
-- Kevin
[1] https://openjdk.org/census#jdv
[2] https://mail.openjdk.org/pipermail/openjfx-dev/
2024/11/19 12:16:56 -0500, kevin.rushfo...@oracle.com:
> Voting for Michael Strauß [1] to OpenJFX Reviewer [2] is now closed.
>
> Yes: 8
> Veto: 0
> Abstain: 0
>
> According to the Bylaws definition of Three-Vote Consensus, this is
> sufficient to approve the nomination.
So recorded.
- Mark
Hi Michael,
Thank you for the explanation. I was confused to see focused still set to true
on cells,
which is more prominent now with the introduction of `focusWithin`.
Deprecating `Note.setFocused` would need a major update across controls,
whereas an update in Cell to use cell-specific focus p
This was an unfortunate decision. The reason for this seems to be that
cell-based controls use the `focused` property in a non-standard way,
to remember the focused cell even when the input focus was moved to a
different control. There's no reason to do that, and can be fixed by
introducing a cell-
Hi,
Controls like ListView, TreeView, etc. always have one of the cells with
focused property set to true.
This causes the focusWithin property [1] (introduced in 19) on these controls
to be set to true even when the actual focus is neither on them nor its
children.
I wonder if there is a rea
38 matches
Mail list logo
