Hi Andy,
1. What happened to this proposal?
I've come to the conclusion that we need something like that, but
probably in a different form. My current thinking is that we don't
need prioritized handlers, but merely a way for interested listeners
to say "I'll take this event, but only if no one el
I agree with this analysis, and I've taken the liberty to steal parts
of your code for this PR:
https://github.com/openjdk/jfx/pull/1632
On Thu, Nov 7, 2024 at 3:06 PM John Hendrikx wrote:
> [...]
> I now think Behaviors should always be doing their event handling in filters,
> for the simple re
Hi everyone,
here is a proposal to finally solve the focus delegation problem that
has recently been discussed in the "Prioritized event handlers"
thread.
Proposal: https://gist.github.com/mstr2/44d94f0bd5b5c030e26a47103063aa29
Draft PR: https://github.com/openjdk/jfx/pull/1632
On Sat, 9 Nov 2024 00:22:42 GMT, John Hendrikx wrote:
> I checked the events that are copied, and it is basically making the copy to
> adjust the source (target remains constant). That's really odd; I'd expect
> the source to remain the same as well (ie. the Scene or Window, not the
> "previou
On Fri, 8 Nov 2024 22:05:15 GMT, Martin Fox wrote:
> FWIW, checking the isConsumed flag will only work if the action is consumed
> by a handler registered directly with the TextField. If there's a filter or
> handler attached to some other part of the scene graph a copy of the event
> will be
On Fri, 8 Nov 2024 21:46:38 GMT, Kevin Rushforth wrote:
> Ths PR removes all remaining calls to `System::getSecurityManager` and the
> `SecurityManager` class along with the `System.getGecurityManager() != null`
> code paths.
>
> As part of doing this, the last uses of `PermissionHelper` and
On Fri, 8 Nov 2024 20:44:17 GMT, John Hendrikx wrote:
>> @kleopatra Your explanation makes sense to me. Thank you for taking the time
>> to write it up.
>>
>> If so, the proposed fix, including adjusting the comment, would be:
>>
>>
>> ---
>> a/modules/javafx.controls/src/main/java/com/sun/j
Ths PR removes all remaining calls to `System::getSecurityManager` and the
`SecurityManager` class along with the `System.getGecurityManager() != null`
code paths.
As part of doing this, the last uses of `PermissionHelper` and `FXPermissions`
were eliminated, so I deleted those two classes. Sin
On Thu, 7 Nov 2024 18:44:23 GMT, Andy Goryachev wrote:
>> Public focus traversal API for use in custom controls.
>>
>> https://github.com/andy-goryachev-oracle/Test/blob/main/doc/FocusTraversal/FocusTraversal-v3.md
>>
>> This is a lightweight change that only adds the public API for focus
>> t
On Fri, 8 Nov 2024 18:44:22 GMT, Kevin Rushforth wrote:
>> Michael Strauß has updated the pull request incrementally with two
>> additional commits since the last revision:
>>
>> - move automatically added imports
>> - rename test...javax -> test...java2d
>
> modules/javafx.graphics/src/main/
On Thu, 7 Nov 2024 19:04:07 GMT, Michael Strauß wrote:
>> This PR is an improved version of #1093.
>>
>> JavaFX can load BMP, GIF, PNG, and JPEG images with its built-in image
>> loaders. It has been a long-standing request to support more image formats,
>> most notably (but not limited to) SV
Thanks, very interesting!
The first thing that popped up is that FX does expose the Skin's implementation
via Node.lookup() and CSS.
-andy
From: openjfx-dev on behalf of Tobias Oelgarte
Date: Friday, November 8, 2024 at 12:47
To: openjfx-dev@openjdk.org
Subject: Re: Prioritized event handl
On Fri, 8 Nov 2024 16:28:17 GMT, Kevin Rushforth wrote:
>> @hjohn @kevinrushforth @aghaisas
>>
>> hmm .. it's been a while but you might be on to something.
>>
>> Let's recap:
>>
>> - the first issue to get fixed was JDK-8207774: the problem was that the
>> isConsumed always was false (due
This whole situation reminds me very much of Shadow DOM [1], an approach
for components (controls/skins) with a complex internal structure that
should not be visible from the outside. The handling of events could
serve as a template here. [2]
[1]
https://developer.mozilla.org/en-US/docs/Web/A
On Thu, 7 Nov 2024 19:29:38 GMT, Kevin Rushforth wrote:
> Fix the GHA build on macOS / aarch64, which uses a macOS 14 GitHub Actions
> runner, by using the default Xcode 15 rather than explicitly selecting Xcode
> 14.
>
> GitHub has announced the removal of Xcode 14 from their macOS 14 images.
On Thu, 7 Nov 2024 18:44:23 GMT, Andy Goryachev wrote:
>> Public focus traversal API for use in custom controls.
>>
>> https://github.com/andy-goryachev-oracle/Test/blob/main/doc/FocusTraversal/FocusTraversal-v3.md
>>
>> This is a lightweight change that only adds the public API for focus
>> t
On Tue, 5 Nov 2024 17:57:19 GMT, Kevin Rushforth wrote:
> This PR modifies the signature of four methods -- 3 `native` JNI methods and
> 1 Java method that is called from native code using JNI -- changing the type
> of one of the arguments from `AccessControlContext` to `Object`.
>
> As a foll
On Tue, 5 Nov 2024 19:37:05 GMT, Kevin Rushforth wrote:
> As specified in the security manager removal CSR,
> [JDK-8341858](https://bugs.openjdk.org/browse/JDK-8341858), JavaFX now checks
> at startup whether the security manager is enabled and fails fast with an
> `UnsupportedOperationExcepti
On Tue, 5 Nov 2024 17:57:19 GMT, Kevin Rushforth wrote:
> This PR modifies the signature of four methods -- 3 `native` JNI methods and
> 1 Java method that is called from native code using JNI -- changing the type
> of one of the arguments from `AccessControlContext` to `Object`.
>
> As a foll
On Fri, 8 Nov 2024 15:39:57 GMT, Jeanette Winzenburg
wrote:
>> modules/javafx.controls/src/main/java/com/sun/javafx/scene/control/behavior/TextFieldBehavior.java
>> line 190:
>>
>>> 188: if (onAction != null || actionEvent.isConsumed()) {
>>> 189: event.consume();
>>> 190:
On Thu, 7 Nov 2024 13:17:33 GMT, Kevin Rushforth wrote:
>> As specified in the security manager removal CSR,
>> [JDK-8341858](https://bugs.openjdk.org/browse/JDK-8341858), JavaFX now
>> checks at startup whether the security manager is enabled and fails fast
>> with an `UnsupportedOperationExc
On Fri, 8 Nov 2024 15:31:04 GMT, Andy Goryachev wrote:
>> modules/javafx.controls/src/main/java/com/sun/javafx/scene/control/behavior/TextFieldBehavior.java
>> line 190:
>>
>>> 188: if (onAction != null || actionEvent.isConsumed()) {
>>> 189: event.consume();
>>> 190:
On Fri, 8 Nov 2024 12:48:45 GMT, John Hendrikx wrote:
>> Jeanette Winzenburg has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> added tests to guard against JDK-8145515
>
> modules/javafx.controls/src/main/java/com/sun/javafx/scene/control/
Vote: YES
Lukasz
On 11/8/2024 5:46 AM, Kevin Rushforth wrote:
> I hereby nominate Jayathirth D V [1] to OpenJFX Committer.
Vote: YES
-andy
From: openjfx-dev on behalf of Kevin Rushforth
Date: Friday, November 8, 2024 at 05:47
To: openjfx-dev , Jayathirth Rao Daarapuram Venkatesh
Murthy
Subject: CFV: New OpenJFX Committer: Jayathirth D V
I hereby nominate Jayathirth D V [1] to OpenJFX Committer.
Jay is a member
Vote: YES
John
On 11/8/24 5:46 AM, Kevin Rushforth wrote:
I hereby nominate Jayathirth D V [1] to OpenJFX Committer.
Vote: YES
On Fri, Nov 8, 2024 at 3:48 PM Kevin Rushforth
wrote:
> Vote: YES
>
> -- Kevin
>
> On 11/8/2024 5:46 AM, Kevin Rushforth wrote:
> > I hereby nominate Jayathirth D V [1] to OpenJFX Committer.
>
>
On Tue, 12 Sep 2023 23:28:37 GMT, John Hendrikx wrote:
>> This fix introduces immutable sets of `PseudoClass` almost everywhere, as
>> they are rarely modified. These are re-used by caching them in a new class
>> `ImmutablePseudoClassSetsCache`.
>>
>> In order to make this work, `BitSet` had
I hereby nominate Jayathirth D V [1] to OpenJFX Committer.
Jay is a member of the JavaFX team at Oracle who has contributed 12
commits [2] to OpenJFX. He has contributed an additional 5 commits to
the OpenJFX jfx-tests repo [3].
Votes are due by November 22, 2024 at 14:00 UTC.
Only current O
Vote: YES
-- Kevin
On 11/8/2024 5:46 AM, Kevin Rushforth wrote:
I hereby nominate Jayathirth D V [1] to OpenJFX Committer.
On Wed, 11 Dec 2019 12:26:27 GMT, Jeanette Winzenburg
wrote:
>> This is a fix for https://bugs.openjdk.java.net/browse/JDK-8207759
>>
>> The issue is that default/cancel button on a scene are triggered even though
>> a onKeyPressed handler for ENTER/CANCEL consumes the keyEvent. See the bug
>
On Tue, 5 Nov 2024 06:12:20 GMT, Jayathirth D V wrote:
> This PR removes AccessController.doPrivileged() calls in
> javafx.graphics/com.sun.glass. It is part of umbrella task
> [JDK-8342441](https://bugs.openjdk.org/browse/JDK-8342441).
>
> Also wherever classes are implementing PrivilegedActi
On Thu, 7 Nov 2024 13:17:33 GMT, Kevin Rushforth wrote:
>> As specified in the security manager removal CSR,
>> [JDK-8341858](https://bugs.openjdk.org/browse/JDK-8341858), JavaFX now
>> checks at startup whether the security manager is enabled and fails fast
>> with an `UnsupportedOperationExc
On Thu, 7 Nov 2024 14:13:16 GMT, Kevin Rushforth wrote:
>> modules/javafx.base/src/main/java/com/sun/javafx/SecurityUtil.java line 48:
>>
>>> 46: * @throws UnsupportedOperationException if the security manager is
>>> enabled
>>> 47: */
>>> 48: public static void checkSecurityManag
34 matches
Mail list logo
