On Thu, 31 Oct 2024 14:15:49 GMT, John Hendrikx wrote:
> Yeah, I was planning to write the release note first, but I guess we don't
> need to wait for that.
Right. Which reminds me that I have a backlog of 4 release notes to write.
-
PR Comment: https://git.openjdk.org/jfx/pull/15
On Thu, 31 Oct 2024 23:32:50 GMT, Andy Goryachev wrote:
>> https://github.com/openjdk/jfx/blob/master/modules/javafx.web/src/main/native/Source/WebCore/bridge/jni/jsc/JNIUtilityPrivate.cpp#L325-L330
>>
>> All Java methods in `javafx.web` that are named `fwk*` are called by native
>> WebKit code
On Thu, 31 Oct 2024 23:30:03 GMT, Kevin Rushforth wrote:
>> I don't see this private method being called...
>
> https://github.com/openjdk/jfx/blob/master/modules/javafx.web/src/main/native/Source/WebCore/bridge/jni/jsc/JNIUtilityPrivate.cpp#L325-L330
>
> All Java methods in `javafx.web` that ar
On Thu, 31 Oct 2024 23:26:12 GMT, Andy Goryachev wrote:
>> Very unlikely, but I'll take a look when fixing
>> [JDK-8342993](https://bugs.openjdk.org/browse/JDK-8342993), since this
>> method is on my list to be modified.
>
> I don't see this private method being called...
https://github.com/op
On Thu, 31 Oct 2024 23:22:32 GMT, Kevin Rushforth wrote:
>> modules/javafx.web/src/main/java/com/sun/webkit/Utilities.java line 119:
>>
>>> 117: }
>>> 118:
>>> 119: return MethodHelper.invoke(method, instance, args);
>>
>> I think the whole `fwkInvokeWithContext` method and ass
On Thu, 31 Oct 2024 22:51:24 GMT, Andy Goryachev wrote:
> Removes `doPrivileged` calls in the javafx.web module, excluding the code in
> `{android,ios}`.
modules/javafx.web/src/main/java/com/sun/webkit/Utilities.java line 119:
> 117: }
> 118:
> 119: return MethodHelper.invoke(
Removes `doPrivileged` calls in the javafx.web module, excluding the code in
`{android,ios}`.
-
Commit messages:
- web
Changes: https://git.openjdk.org/jfx/pull/1620/files
Webrev: https://webrevs.openjdk.org/?repo=jfx&pr=1620&range=00
Issue: https://bugs.openjdk.org/browse/JDK-
On Thu, 31 Oct 2024 22:52:21 GMT, Andy Goryachev wrote:
>> Removes `doPrivileged` calls in the javafx.web module, excluding the code in
>> `{android,ios}`.
>
> modules/javafx.web/src/main/java/com/sun/webkit/Utilities.java line 119:
>
>> 117: }
>> 118:
>> 119: return MethodHelp
On Thu, 31 Oct 2024 22:55:25 GMT, Andy Goryachev wrote:
> Added eclipse project files.
>
> The project is named `jsobject` instead of jdk.jsobject, similarly to how the
> other projects are named "base", "controls", ... instead of their full module
> names.
@hjohn would you like to review thi
Added eclipse project files.
The project is named `jsobject` instead of jdk.jsobject, similarly to how the
other projects are named "base", "controls", ... instead of their full module
names.
-
Commit messages:
- eclipse files
Changes: https://git.openjdk.org/jfx/pull/1621/files
On Thu, 31 Oct 2024 18:37:14 GMT, Andy Goryachev wrote:
>> Since this is preexisting, do you think it is worth a follow-up issue? Worth
>> noting is that the prints only happen when a debug system property is set.
>>
>> I have a separate question: Is the `finally` statement really needed? Given
On Thu, 31 Oct 2024 19:52:17 GMT, Phil Race wrote:
>> I would suggest to remove the variable `lineSeparator` and simply use
>> `System.lineSeparator()`.
>
> I agree. That has been available since 1.7. But possibly this code is old
> enough to pre-date that ..
This code possibly dates from JDK
On Thu, 31 Oct 2024 03:56:30 GMT, Michael Strauß wrote:
> This PR adds another accessibility preference that is available on all
> supported desktop platforms:
>
> 1. **Windows**: Settings -> Accessibility -> Visual Effects -> Always show
> scroll bars
> 2. **macOS**: System Settings -> Appear
> This PR adds another accessibility preference that is available on all
> supported desktop platforms:
>
> 1. **Windows**: Settings -> Accessibility -> Visual Effects -> Always show
> scroll bars
> 2. **macOS**: System Settings -> Appearance -> Show scroll bars
> 3. **Ubuntu**: Settings -> Acce
On Thu, 31 Oct 2024 19:44:22 GMT, Anirvan Sarkar wrote:
>> modules/javafx.graphics/src/main/java/javafx/application/Preloader.java line
>> 107:
>>
>>> 105:
>>> 106: // Too bad this isn't already available in a Java core class
>>> 107: private static final String lineSeparator;
>>
>> S
On Thu, 31 Oct 2024 15:21:01 GMT, Glavo wrote:
>> Lukasz Kostyra has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Scene: Remove missed doPrivileged use
>
> modules/javafx.graphics/src/main/java/javafx/application/Preloader.java line
> 10
On Thu, 31 Oct 2024 16:30:46 GMT, Andy Goryachev wrote:
>> Lukasz Kostyra has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Scene: Remove missed doPrivileged use
>
> modules/javafx.graphics/src/main/java/com/sun/javafx/util/Utils.java line
On Thu, 31 Oct 2024 17:42:04 GMT, Kevin Rushforth wrote:
>> modules/javafx.graphics/src/main/java/com/sun/javafx/font/PrismFontFile.java
>> line 137:
>>
>>> 135: isCopy = isDecoded = false;
>>> 136: } catch (Exception e) {
>>> 137: } finally {
>>
>> even
On Thu, 31 Oct 2024 14:09:52 GMT, Lukasz Kostyra wrote:
>> This PR removes uses of `AccessControler.doPrivileged()` from
>> `javafx.graphics` package. All uses of `doPrivileged()` were removed
>> _excluding_ `com.sun.javafx.tk` and `com.sun.ui.glass` subpackages - those
>> are handled by [JDK-
On Thu, 31 Oct 2024 17:44:59 GMT, Andy Goryachev wrote:
>> modules/javafx.graphics/src/main/java/com/sun/javafx/util/Utils.java line
>> 684:
>>
>>> 682: public static boolean hasFullScreenStage(final Screen screen) {
>>> 683: @SuppressWarnings("removal")
>>> 684: final List
On Thu, 31 Oct 2024 16:25:39 GMT, Andy Goryachev wrote:
>> Lukasz Kostyra has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Scene: Remove missed doPrivileged use
>
> modules/javafx.graphics/src/main/java/com/sun/javafx/font/PrismFontFile.j
On Thu, 31 Oct 2024 03:56:30 GMT, Michael Strauß wrote:
> This PR adds another accessibility preference that is available on all
> supported desktop platforms:
>
> 1. **Windows**: Settings -> Accessibility -> Visual Effects -> Always show
> scroll bars
> 2. **macOS**: System Settings -> Appear
On Thu, 31 Oct 2024 03:56:30 GMT, Michael Strauß wrote:
> This PR adds another accessibility preference that is available on all
> supported desktop platforms:
>
> 1. **Windows**: Settings -> Accessibility -> Visual Effects -> Always show
> scroll bars
> 2. **macOS**: System Settings -> Appear
On Thu, 31 Oct 2024 17:17:36 GMT, Kevin Rushforth wrote:
>> modules/javafx.graphics/src/main/java/com/sun/javafx/css/StyleManager.java
>> line 1063:
>>
>>> 1061: ** That way there in no information leaked.
>>> 1062: */
>>> 1063: catch (java.net.URISyntaxExcep
On Thu, 31 Oct 2024 16:49:28 GMT, Kevin Rushforth wrote:
>> Lukasz Kostyra has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Scene: Remove missed doPrivileged use
>
> modules/javafx.graphics/src/main/java/com/sun/javafx/util/Utils.java lin
On Thu, 31 Oct 2024 15:20:47 GMT, Andy Goryachev wrote:
>> Lukasz Kostyra has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Scene: Remove missed doPrivileged use
>
> modules/javafx.graphics/src/main/java/com/sun/javafx/css/StyleManager.jav
On Thu, 31 Oct 2024 16:31:41 GMT, Andy Goryachev wrote:
>> Lukasz Kostyra has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Scene: Remove missed doPrivileged use
>
> modules/javafx.graphics/src/main/java/com/sun/marlin/MarlinProperties.jav
On Thu, 31 Oct 2024 14:09:52 GMT, Lukasz Kostyra wrote:
>> This PR removes uses of `AccessControler.doPrivileged()` from
>> `javafx.graphics` package. All uses of `doPrivileged()` were removed
>> _excluding_ `com.sun.javafx.tk` and `com.sun.ui.glass` subpackages - those
>> are handled by [JDK-
> This PR is an improved version of #1093.
>
> JavaFX can load BMP, GIF, PNG, and JPEG images with its built-in image
> loaders. It has been a long-standing request to support more image formats,
> most notably (but not limited to) SVG. However, adding more built-in image
> loaders is a signifi
On Thu, 31 Oct 2024 14:09:52 GMT, Lukasz Kostyra wrote:
>> This PR removes uses of `AccessControler.doPrivileged()` from
>> `javafx.graphics` package. All uses of `doPrivileged()` were removed
>> _excluding_ `com.sun.javafx.tk` and `com.sun.ui.glass` subpackages - those
>> are handled by [JDK-
On Mon, 28 Oct 2024 23:46:16 GMT, Andy Goryachev wrote:
> no flicker on win11, thanks!
>
> the height of the title bar is slightly off. I think it should be the same as
> the native title bar of DECORATED window.
This seems to be an artifact of different JavaFX/Windows rendering. If I make
th
> This PR is a new take on a highly requested feature: JavaFX controls in the
> header bar (see also #594 for an earlier iteration).
>
> This is a feature with many possible ways to skin the cat, and it has taken
> quite a bit of effort to come up with a good user model. In contrast to the
> pr
On Thu, 31 Oct 2024 15:57:59 GMT, Michael Strauß wrote:
>> This PR is a new take on a highly requested feature: JavaFX controls in the
>> header bar (see also #594 for an earlier iteration).
>>
>> This is a feature with many possible ways to skin the cat, and it has taken
>> quite a bit of eff
On Thu, 31 Oct 2024 14:09:52 GMT, Lukasz Kostyra wrote:
>> This PR removes uses of `AccessControler.doPrivileged()` from
>> `javafx.graphics` package. All uses of `doPrivileged()` were removed
>> _excluding_ `com.sun.javafx.tk` and `com.sun.ui.glass` subpackages - those
>> are handled by [JDK-
On Mon, 28 Oct 2024 14:48:42 GMT, Andy Goryachev wrote:
> Removes `doPrivileged` in the following module:
>
> * javafx.fxml
>
> See JDK-8342441 for details.
>
> As a helpful hint for reviewers, I recommend reviewing this using the "Hide
> whitespace" option.
This pull request has now been in
On Thu, 31 Oct 2024 14:09:52 GMT, Lukasz Kostyra wrote:
>> This PR removes uses of `AccessControler.doPrivileged()` from
>> `javafx.graphics` package. All uses of `doPrivileged()` were removed
>> _excluding_ `com.sun.javafx.tk` and `com.sun.ui.glass` subpackages - those
>> are handled by [JDK-
On Thu, 31 Oct 2024 15:01:41 GMT, Glavo wrote:
>> Kevin Rushforth has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Review comments
>
> modules/javafx.graphics/src/main/java/com/sun/javafx/tk/quantum/GlassViewEventHandler.java
> line 69:
On Wed, 30 Oct 2024 20:43:07 GMT, Kevin Rushforth wrote:
>> This PR removes all doPrivileged calls from `com.sun.javafx.tk**` in the
>> `javafx.graphics` module.
>>
>> Here is a quick overview of what I did for this fix:
>>
>> 1. Changed all simple cases of `doPrivileged((PrivilegedAction) ()
> Public focus traversal API for use in custom controls
>
> https://github.com/andy-goryachev-oracle/Test/blob/main/doc/FocusTraversal/FocusTraversal-v3.md
>
> This work is loosely based on the patch
> https://cr.openjdk.org/~jgiles/8061673/
>
> And is a scaled down version (with the public trav
On Mon, 28 Oct 2024 14:57:17 GMT, Andy Goryachev wrote:
> Removes doPrivileged in the following module:
>
> - javafx.media
>
> See JDK-8342441 for details.
>
> As a helpful hint for reviewers, I recommend reviewing this using the "Hide
> whitespace" option.
This pull request has now been int
> Incubating a new feature - rich text control, **RichTextArea**, intended to
> bridge the functional gap with Swing and its StyledEditorKit/JEditorPane. The
> main design goal is to provide a control that is complete enough to be useful
> out-of-the box, as well as open to extension by the appl
On Thu, 26 Sep 2024 21:17:55 GMT, John Hendrikx wrote:
> This change modifies `ScrollPaneBehavior` to only consume keys that are
> targetted at it. As `KeyEvent`s are in almost all cases only intended for
> the targetted node (as visually that's where the user expects the keyboard
> input to
On Tue, 22 Oct 2024 05:21:47 GMT, John Hendrikx wrote:
>> This change modifies `ScrollPaneBehavior` to only consume keys that are
>> targetted at it. As `KeyEvent`s are in almost all cases only intended for
>> the targetted node (as visually that's where the user expects the keyboard
>> input
> This PR removes uses of `AccessControler.doPrivileged()` from
> `javafx.graphics` package. All uses of `doPrivileged()` were removed
> _excluding_ `com.sun.javafx.tk` and `com.sun.ui.glass` subpackages - those
> are handled by [JDK-8342453](https://bugs.openjdk.org/browse/JDK-8342453)
> (alre
On Mon, 28 Oct 2024 14:48:42 GMT, Andy Goryachev wrote:
> Removes `doPrivileged` in the following module:
>
> * javafx.fxml
>
> See JDK-8342441 for details.
>
> As a helpful hint for reviewers, I recommend reviewing this using the "Hide
> whitespace" option.
LGTM
-
Marked as re
On Wed, 23 Oct 2024 20:10:02 GMT, Kevin Rushforth wrote:
> This PR removes all doPrivileged calls from `com.sun.javafx.tk**` in the
> `javafx.graphics` module.
>
> Here is a quick overview of what I did for this fix:
>
> 1. Changed all simple cases of `doPrivileged((PrivilegedAction) () ->
>
46 matches
Mail list logo
