On Thu, 31 Oct 2024 15:21:01 GMT, Glavo <d...@openjdk.org> wrote:
>> Lukasz Kostyra has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Scene: Remove missed doPrivileged use
>
> modules/javafx.graphics/src/main/java/javafx/application/Preloader.java line
> 107:
>
>> 105:
>> 106: // Too bad this isn't already available in a Java core class
>> 107: private static final String lineSeparator;
>
> Suggestion:
>
> private static final String lineSeparator =
> System.getProperty("line.separator", "\n");
I would suggest to remove the variable `lineSeparator` and simply use
`System.lineSeparator()`.
-------------
PR Review Comment: https://git.openjdk.org/jfx/pull/1619#discussion_r1825082335
