Re: RFR: 8313424: JavaFX controls in the title bar [v8]

2024-10-25 Thread Michael Strauß
> This PR is a new take on a highly requested feature: JavaFX controls in the > header bar (see also #594 for an earlier iteration). > > This is a feature with many possible ways to skin the cat, and it has taken > quite a bit of effort to come up with a good user model. In contrast to the > pr

Re: JEP: JavaFX controls in the title bar

2024-10-25 Thread Michael Strauß
> Right-click system menu: I think it should work rather well: on any platform, > setting the context menu on the header works as expected (the FX menu > appears), and on Windows, when the app does not set the context menu, the > system menu appears as expected, unless the app sets its own (the

Re: RFR: 8313424: JavaFX controls in the title bar [v7]

2024-10-25 Thread Michael Strauß
> This PR is a new take on a highly requested feature: JavaFX controls in the > header bar (see also #594 for an earlier iteration). > > This is a feature with many possible ways to skin the cat, and it has taken > quite a bit of effort to come up with a good user model. In contrast to the > pr

Re: RFR: 8341670: [Text, TextFlow] Public API for Text Layout Info [v9]

2024-10-25 Thread Andy Goryachev
> Please refer to > > https://github.com/andy-goryachev-oracle/Test/blob/main/doc/Text/LayoutInfo.md > > The RichTextArea control > ([JDK-8301121](https://bugs.openjdk.org/browse/JDK-8301121)), or any custom > control that needs non-trivial navigation within complex or wrapped text > needs a p

Re: RFR: 8341670: [Text, TextFlow] Public API for Text Layout Info [v8]

2024-10-25 Thread Andy Goryachev
On Fri, 25 Oct 2024 14:14:08 GMT, Kevin Rushforth wrote: >> Andy Goryachev has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains 14 additional >> comm

Re: RFR: 8341670: [Text, TextFlow] Public API for Text Layout Info [v8]

2024-10-25 Thread Andy Goryachev
On Fri, 25 Oct 2024 14:27:25 GMT, Kevin Rushforth wrote: >> Andy Goryachev has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains 14 additional >> comm

Re: RFR: 8341670: [Text, TextFlow] Public API for Text Layout Info [v8]

2024-10-25 Thread Andy Goryachev
On Fri, 25 Oct 2024 14:08:40 GMT, Kevin Rushforth wrote: >> Andy Goryachev has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains 14 additional >> comm

Re: RFR: JDK-8199216: Quadratic layout time with nested nodes and pseudo-class in style sheet [v10]

2024-10-25 Thread Daniel Godino
On Tue, 12 Sep 2023 23:28:37 GMT, John Hendrikx wrote: >> This fix introduces immutable sets of `PseudoClass` almost everywhere, as >> they are rarely modified. These are re-used by caching them in a new class >> `ImmutablePseudoClassSetsCache`. >> >> In order to make this work, `BitSet` had

Proposed schedule for JavaFX 24

2024-10-25 Thread Kevin Rushforth
Here is the proposed schedule for JavaFX 24: RDP1: Jan 16, 2025 (aka “feature freeze”) RDP2: Feb 6, 2025 Freeze: Feb 27, 2025 GA: Mar 18, 2025 We plan to fork a jfx24 stabilization branch at RDP1. The start of RDP1, the start of RDP2, and the code freeze will be 16:00 UTC on the respective dat

Re: RFR: 8341090: Remove support for security manager from JavaFX [v2]

2024-10-25 Thread Kevin Rushforth
On Fri, 18 Oct 2024 10:13:13 GMT, Johan Vos wrote: >> Kevin Rushforth has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains five additional >> commits

Re: RFR: 8301121: RichTextArea Control (Incubator) [v28]

2024-10-25 Thread Kevin Rushforth
On Mon, 21 Oct 2024 18:53:20 GMT, Andy Goryachev wrote: >> Incubating a new feature - rich text control, **RichTextArea**, intended to >> bridge the functional gap with Swing and its StyledEditorKit/JEditorPane. >> The main design goal is to provide a control that is complete enough to be >> u

Re: JEP: JavaFX controls in the title bar

2024-10-25 Thread Andy Goryachev
Right-click system menu: I think it should work rather well: on any platform, setting the context menu on the header works as expected (the FX menu appears), and on Windows, when the app does not set the context menu, the system menu appears as expected, unless the app sets its own (the first ca

Re: JEP: JavaFX controls in the title bar

2024-10-25 Thread Michael Strauß
> - Right-click system menu: you are right, we probably should not add an API > to control the system menu. However, it might make sense to have the > HeaderBar show the system menu on Windows by default, unless the > onContextMenuRequestedProperty is set. What do you think? Shouldn't the >

Re: RFR: 8091673: Public focus traversal API for use in custom controls [v2]

2024-10-25 Thread John Hendrikx
On Fri, 25 Oct 2024 15:00:21 GMT, Kevin Rushforth wrote: >> modules/javafx.graphics/src/main/java/javafx/scene/Node.java line 10449: >> >>> 10447: * @since 24 >>> 10448: */ >>> 10449: public final boolean requestFocusTraversal(TraversalDirection >>> direction) { >> >> possible al

Re: RFR: 8091673: Public focus traversal API for use in custom controls [v3]

2024-10-25 Thread Andy Goryachev
On Fri, 25 Oct 2024 16:22:01 GMT, Andy Goryachev wrote: >> Public focus traversal API for use in custom controls >> >> https://github.com/andy-goryachev-oracle/Test/blob/main/doc/FocusTraversal/FocusTraversal-v3.md >> >> This work is loosely based on the patch >> https://cr.openjdk.org/~jgiles/

Re: JEP: JavaFX controls in the title bar

2024-10-25 Thread Andy Goryachev
- Right-click system menu: you are right, we probably should not add an API to control the system menu. However, it might make sense to have the HeaderBar show the system menu on Windows by default, unless the onContextMenuRequestedProperty is set. What do you think? Shouldn't the HeaderBar

Re: JEP: JavaFX controls in the title bar

2024-10-25 Thread Michael Strauß
> - Right-click system menu: is there any way to provide this functionality > somehow? May be as a method in the HeaderBar? This is probably more a question of whether we want to have this, not of whether it is possible. The right-click system menu is a Windows-only thing, it's not available on

Re: RFR: 8313424: JavaFX controls in the title bar [v6]

2024-10-25 Thread Michael Strauß
> This PR is a new take on a highly requested feature: JavaFX controls in the > header bar (see also #594 for an earlier iteration). > > This is a feature with many possible ways to skin the cat, and it has taken > quite a bit of effort to come up with a good user model. In contrast to the > pr

Re: RFR: 8091673: Public focus traversal API for use in custom controls [v3]

2024-10-25 Thread Andy Goryachev
> Public focus traversal API for use in custom controls > > https://github.com/andy-goryachev-oracle/Test/blob/main/doc/FocusTraversal/FocusTraversal-v3.md > > This work is loosely based on the patch > https://cr.openjdk.org/~jgiles/8061673/ > > And is a scaled down version (with the public trav

Re: JEP: JavaFX controls in the title bar

2024-10-25 Thread Andy Goryachev
Dear Michael: Thank you for adding clarifications to the JEP! More questions: - Right-click system menu: is there any way to provide this functionality somehow? May be as a method in the HeaderBar? - iOS/Android: while the existing PR does not provide support for iOS/Android, does Gluon have

Re: RFR: 8091673: Public focus traversal API for use in custom controls [v2]

2024-10-25 Thread Kevin Rushforth
On Wed, 23 Oct 2024 22:14:20 GMT, Andy Goryachev wrote: >> Andy Goryachev has updated the pull request incrementally with one >> additional commit since the last revision: >> >> request focus traversal > > modules/javafx.graphics/src/main/java/javafx/scene/Node.java line 10449: > >> 10447:

Re: RFR: 8091673: Public focus traversal API for use in custom controls [v2]

2024-10-25 Thread Kevin Rushforth
On Wed, 23 Oct 2024 18:37:03 GMT, Andy Goryachev wrote: >> Public focus traversal API for use in custom controls >> >> https://github.com/andy-goryachev-oracle/Test/blob/main/doc/FocusTraversal/FocusTraversal-v3.md >> >> This work is loosely based on the patch >> https://cr.openjdk.org/~jgiles/

Re: RFR: 8341670: [Text, TextFlow] Public API for Text Layout Info [v8]

2024-10-25 Thread Kevin Rushforth
On Thu, 24 Oct 2024 22:45:28 GMT, Andy Goryachev wrote: >> The RichTextArea control >> ([JDK-8301121](https://bugs.openjdk.org/browse/JDK-8301121)), or any custom >> control that needs non-trivial navigation within complex or wrapped text >> needs a public API to get information about text lay

Re: RFR: 8341670: [Text, TextFlow] Public API for Text Layout Info [v7]

2024-10-25 Thread Kevin Rushforth
On Wed, 23 Oct 2024 22:52:34 GMT, Andy Goryachev wrote: >> modules/javafx.graphics/src/main/java/javafx/scene/text/CaretInfo.java line >> 34: >> >>> 32: * @since 24 >>> 33: */ >>> 34: public sealed abstract class CaretInfo permits PrismCaretInfo { >> >> Given the API you define, is there a r

Re: Bugfix JDK-8229902

2024-10-25 Thread dani-kurmann
Ok, the flush() function and its business in WCRenderQueue definitively deserve a closer look: I tried to do a proof-of-concept of how to test for this bug: https://github.com/CodeMonkeyIsland/Bugtest-JDK-8229902 Its in a "its not pretty, but it works... sometimes"-state. Not ready for anything

Re: [External] : Re: JEP: JavaFX controls in the title bar

2024-10-25 Thread Michael Strauß
> Perhaps the header bar should be a part of a new top-level container? This would then be the first and only top-level container of JavaFX. What would happen if you tried to add it to another container? It would also make it harder to create certain UIs. Right now it is pretty easy to place cont

Re: JEP: JavaFX controls in the title bar

2024-10-25 Thread Andy Goryachev
Thank you. One suggestion: in the "what is the EXTENDED stage style?" section, is it possible to provide a table showing which elements are provided by the OS and which are provided by FX, and which are not provided, per platform? That is, columns: Feature | Linux | macOS | Windows | iOS | Andr