On Tue, 15 Oct 2024 03:18:09 GMT, Prasanta Sadhukhan
wrote:
> While implementing [JDK-8339517](https://bugs.openjdk.org/browse/JDK-8339517)
> to eliminate native access warnings by passing "--enable-native-access" for
> the three JavaFX modules with native code (javafx.graphics, javafx.media,
Update Copyright year in these 3 doc files to 2025.
-
Commit messages:
- doc copyright year update
Changes: https://git.openjdk.org/jfx/pull/1602/files
Webrev: https://webrevs.openjdk.org/?repo=jfx&pr=1602&range=00
Issue: https://bugs.openjdk.org/browse/JDK-8341686
Stats: 3 li
After having started making the changes, I realize that this method breaks
the existing specification of VertexFormat.java.
VertexFormat.java defines getVertexIndexSize() as "the number of component
indices that represents a vertex."
So, for VertexFormat.POINT_TEXCOORD, that number will be 2, and
On Mon, 7 Oct 2024 16:25:22 GMT, Loay Ghreeb wrote:
>> Fix an issue in `SortedList` where the sorting became incorrect when adding
>> new items that are equal to existing items according to the comparator. The
>> `SortedList` should consider the insertion index of these items to maintain
>> th
On Wed, 16 Oct 2024 10:10:04 GMT, Alexander Zuev wrote:
>> Initial implementation of the protocol.
>
> Alexander Zuev has updated the pull request with a new target base due to a
> merge or a rebase. The incremental webrev excludes the unrelated changes
> brought in by the merge/rebase. The pul
On Fri, 4 Oct 2024 07:48:50 GMT, Ambarish Rapte wrote:
>>> I observed an NPE with RichTextAreaDemoApp:
>>
>> I can't reproduce this...
>>
>> Are you on mac or windows? Are you testing the latest code (can you tell me
>> the git commit hash?)
>> Also, could you take a screenshot when this happ
> Incubating a new feature - rich text control, **RichTextArea**, intended to
> bridge the functional gap with Swing and its StyledEditorKit/JEditorPane. The
> main design goal is to provide a control that is complete enough to be useful
> out-of-the box, as well as open to extension by the appl
On Wed, 16 Oct 2024 14:30:12 GMT, Michael Strauß wrote:
>> modules/javafx.graphics/src/main/java/com/sun/javafx/iio/javax/XImageLoader.java
>> line 203:
>>
>>> 201: case TYPE_BYTE_INDEXED -> "TYPE_BYTE_INDEXED";
>>> 202: default -> Integer.toString(image.
On Wed, 16 Oct 2024 02:25:53 GMT, Prasanta Sadhukhan
wrote:
>> While implementing
>> [JDK-8339517](https://bugs.openjdk.org/browse/JDK-8339517) to eliminate
>> native access warnings by passing "--enable-native-access" for the three
>> JavaFX modules with native code (javafx.graphics, javafx.
On Tue, 15 Oct 2024 22:04:42 GMT, John Hendrikx wrote:
>> Michael Strauß has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> review changes
>
> modules/javafx.graphics/src/main/java/com/sun/javafx/iio/javax/XImageLoader.java
> line 203:
>
On Wed, 16 Oct 2024 14:15:42 GMT, Michael Strauß wrote:
>> This PR is an improved version of #1093.
>>
>> JavaFX can load BMP, GIF, PNG, and JPEG images with its built-in image
>> loaders. It has been a long-standing request to support more image formats,
>> most notably (but not limited to) S
On Tue, 15 Oct 2024 20:26:29 GMT, John Hendrikx wrote:
> With the restructuring to make the dependency optional at runtime, this seems
> like a reasonable approach to consider. I also want to make sure that we
> don't initialize the AWT toolkit unless an application tries to load an image
> fi
On Tue, 15 Oct 2024 22:47:38 GMT, John Hendrikx wrote:
>> Michael Strauß has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> review changes
>
> modules/javafx.graphics/src/main/java/com/sun/javafx/image/impl/IntBgr.java
> line 68:
>
>> 66:
> This PR is an improved version of #1093.
>
> JavaFX can load BMP, GIF, PNG, and JPEG images with its built-in image
> loaders. It has been a long-standing request to support more image formats,
> most notably (but not limited to) SVG. However, adding more built-in image
> loaders is a signifi
On Tue, 15 Oct 2024 22:55:45 GMT, John Hendrikx wrote:
>> modules/javafx.graphics/src/main/java/com/sun/javafx/image/impl/BaseByteToByteConverter.java
>> line 296:
>>
>>> 294: {
>>> 295: srcscanbytes -= w * 3;
>>> 296: srcscanbytes -= w * 4;
>>
>> This really do
On Thu, 1 Aug 2024 11:40:06 GMT, Florian Kirmaier wrote:
> Fixing WebView on iOS
> (I couldn't compile it because I don't know how to build it for iOS, but the
> code should be correct.)
>
> @johanvos
> If this looks reasonable to you, can you provide a test build for
> @dlemmermann ?
> Then
On Tue, 15 Oct 2024 21:35:14 GMT, John Hendrikx wrote:
>> Michael Strauß has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> review changes
>
> modules/javafx.graphics/src/main/java/com/sun/javafx/iio/ImageStorage.java
> line 201:
>
>> 199
> This PR is an improved version of #1093.
>
> JavaFX can load BMP, GIF, PNG, and JPEG images with its built-in image
> loaders. It has been a long-standing request to support more image formats,
> most notably (but not limited to) SVG. However, adding more built-in image
> loaders is a signifi
On Wed, 16 Oct 2024 11:30:26 GMT, Lukasz Kostyra wrote:
>> This PR adds a title-mentioned fallback to `ImageStorage.java` and a test
>> for that specific scenario.
>>
>> In `ImageStorage.loadAll()` we still prefer the Image path that was provided
>> by the user, but if it is missing we will no
On Thu, 15 Aug 2024 09:30:51 GMT, Dirk Lemmermann wrote:
>> Fixing WebView on iOS
>> (I couldn't compile it because I don't know how to build it for iOS, but the
>> code should be correct.)
>>
>> @johanvos
>> If this looks reasonable to you, can you provide a test build for
>> @dlemmermann ?
On Wed, 16 Oct 2024 11:30:26 GMT, Lukasz Kostyra wrote:
>> This PR adds a title-mentioned fallback to `ImageStorage.java` and a test
>> for that specific scenario.
>>
>> In `ImageStorage.loadAll()` we still prefer the Image path that was provided
>> by the user, but if it is missing we will no
On Wed, 16 Oct 2024 02:25:53 GMT, Prasanta Sadhukhan
wrote:
>> While implementing
>> [JDK-8339517](https://bugs.openjdk.org/browse/JDK-8339517) to eliminate
>> native access warnings by passing "--enable-native-access" for the three
>> JavaFX modules with native code (javafx.graphics, javafx.
> This PR adds a title-mentioned fallback to `ImageStorage.java` and a test for
> that specific scenario.
>
> In `ImageStorage.loadAll()` we still prefer the Image path that was provided
> by the user, but if it is missing we will now try to add a `@1x` suffix to
> Image name and give it one la
On Mon, 14 Oct 2024 23:58:46 GMT, Kevin Rushforth wrote:
>> Lukasz Kostyra has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Review fixes
>>
>> - Change exception message in loadAll() to include original resource
>> path
>> - Ad
On Fri, 11 Oct 2024 18:52:37 GMT, Kevin Rushforth wrote:
>> Add the `jdk.jsobject` module to JavaFX. This module is currently delivered
>> by the JDK, but will be terminally-deprecated in JDK 24 by
>> [JDK-8311530](https://bugs.openjdk.org/browse/JDK-8311530), which is out for
>> review at op
On Tue, 4 Jun 2024 12:33:06 GMT, Marius Hanl wrote:
>> you are right: I see the focus rectangle jitter at 175% scale on win 11 (w/o
>> the fix), so it must be a different issue. At this scale, it merely shows a
>> thinner line, perhaps that's why I did not notice it earlier.
>
>> you are right
On Mon, 14 Oct 2024 23:48:32 GMT, Kevin Rushforth wrote:
>> This PR adds a title-mentioned fallback to `ImageStorage.java` and a test
>> for that specific scenario.
>>
>> In `ImageStorage.loadAll()` we still prefer the Image path that was provided
>> by the user, but if it is missing we will n
> Initial implementation of the protocol.
Alexander Zuev has updated the pull request with a new target base due to a
merge or a rebase. The incremental webrev excludes the unrelated changes
brought in by the merge/rebase. The pull request contains five additional
commits since the last revisio
On Mon, 7 Oct 2024 20:03:49 GMT, Kevin Rushforth wrote:
> This PR removes support for running JavaFX applications with the Java
> Security Manager.
>
> The initial work was done in 4 separate commits as follows:
>
> * Fail fast at startup if the Security Manager is enabled
> * Remove `-Djava.s
{
"emoji": "👍",
"version": 1
}
>
> I've got no objections on refactoring the validateXyz() methods in
> TriangleMesh to better reflect their names, I had been following the
> previous pattern, and considered doing this change myself, but decided
> against it since the contribution guide discourages refactoring.
>
That's true. I
I've got no objections on refactoring the validateXyz() methods in
TriangleMesh to better reflect their names, I had been following the
previous pattern, and considered doing this change myself, but decided
against it since the contribution guide discourages refactoring.
Regarding not changing the
32 matches
Mail list logo
