Re: RFR: 8328828: Monkey Tester Application Part 4 [v2]

2024-09-15 Thread Ambarish Rapte
On Fri, 13 Sep 2024 19:35:26 GMT, Andy Goryachev wrote: >> Further additions to the MonkeyTester application: >> >> - tree/table view column property sheets ✔ >> - new pages: button, checkbox, hyperlink, menu bar, radio button, toggle >> button, canvas, split menu button, dnd ✔ >> - properties.

Re: RFR: 8339515: [TestBug] Convert web tests to JUnit 5 [v4]

2024-09-15 Thread Jay Bhaskar
> Successfully converted web tests from JUnit 4 to JUnit 5, ensuring all tests > are fully compliant with the JUnit 5 framework. Jay Bhaskar has updated the pull request incrementally with one additional commit since the last revision: converting newly added tests to JUNIT5 - Ch

Re: RFR: 8339515: [TestBug] Convert web tests to JUnit 5 [v3]

2024-09-15 Thread Jay Bhaskar
> Successfully converted web tests from JUnit 4 to JUnit 5, ensuring all tests > are fully compliant with the JUnit 5 framework. Jay Bhaskar has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains three commits: - resolve conflict - copyri

Re: RFR: 8339515: [TestBug] Convert web tests to JUnit 5 [v2]

2024-09-15 Thread Jay Bhaskar
On Sun, 15 Sep 2024 12:50:25 GMT, Marius Hanl wrote: >> Jay Bhaskar has updated the pull request incrementally with one additional >> commit since the last revision: >> >> copyright year updated along with minor spcae related review > > modules/javafx.web/src/test/java/test/javafx/scene/web/S

Re: RFR: 8339515: [TestBug] Convert web tests to JUnit 5 [v2]

2024-09-15 Thread Jay Bhaskar
> Successfully converted web tests from JUnit 4 to JUnit 5, ensuring all tests > are fully compliant with the JUnit 5 framework. Jay Bhaskar has updated the pull request incrementally with one additional commit since the last revision: copyright year updated along with minor spcae related rev

Re: RFR: 8338468: [TestBug] Convert controls tests to JUnit 5

2024-09-15 Thread Marius Hanl
On Tue, 10 Sep 2024 18:25:40 GMT, Andy Goryachev wrote: > Converting control module tests to junit5. > > The following notes might help reviewers and people migrating other parts of > https://bugs.openjdk.org/browse/JDK-8339170. The direct link to the notes: > https://github.com/andy-goryachev

Re: RFR: 8339515: [TestBug] Convert web tests to JUnit 5

2024-09-15 Thread Marius Hanl
On Sun, 15 Sep 2024 12:31:03 GMT, Jay Bhaskar wrote: > Successfully converted web tests from JUnit 4 to JUnit 5, ensuring all tests > are fully compliant with the JUnit 5 framework. Also one note: The copyright year was not updated, but this could also be done by the script afterwards I guess.

Re: RFR: 8339513: [TestBug] Convert fxml tests to JUnit 5

2024-09-15 Thread Marius Hanl
On Fri, 13 Sep 2024 10:45:33 GMT, Ajit Ghaisas wrote: > This converts FXML module tests to junit5. > > All changes are trivial API replacements from junit4 to junit5. > There are no parameterized tests in this module. Looks good to me too, just some formatting is off (as Andy also noticed) mod

Re: RFR: 8339515: [TestBug] Convert web tests to JUnit 5

2024-09-15 Thread Marius Hanl
On Sun, 15 Sep 2024 12:31:03 GMT, Jay Bhaskar wrote: > Successfully converted web tests from JUnit 4 to JUnit 5, ensuring all tests > are fully compliant with the JUnit 5 framework. There is one major issue with the parameterized test as far as I can see. Some minor style guide things, looks g

RFR: 8339515: [TestBug] Convert web tests to JUnit 5

2024-09-15 Thread Jay Bhaskar
Successfully converted web tests from JUnit 4 to JUnit 5, ensuring all tests are fully compliant with the JUnit 5 framework. - Commit messages: - 8339515: [TestBug] Convert web tests to JUnit 5 Changes: https://git.openjdk.org/jfx/pull/1567/files Webrev: https://webrevs.openjdk.o