> Fix an issue in `SortedList` where the sorting became incorrect when adding
> new items that are equal to existing items according to the comparator. The
> `SortedList` should consider the insertion index of these items to maintain
> the correct order.
Loay Ghreeb has updated the pull request
On Fri, 2 Aug 2024 21:29:15 GMT, Kevin Rushforth wrote:
> Add the `jdk.jsobject` module to JavaFX. This module is currently delivered
> by the JDK, but will be terminally-deprecated in JDK 24 by
> [JDK-8311530](https://bugs.openjdk.org/browse/JDK-8311530), which is out for
> review at openjdk
Thanks everyone who has commented and given feedback.
With no further discussion points brought up, I'd like to move this
proposal along for review, and hopefully CSR creation.
Is there anything I need to do besides say I'm ready to move forward? @Kevin
Rushforth
On Wed, Sep 4, 2024, 12:24 PM
On Thu, 11 Jul 2024 17:15:14 GMT, Marius Hanl wrote:
>> Alternative PR to https://github.com/openjdk/jfx/pull/1330 which does not
>> modify the layout of `VirtualFlow`.
>>
>> This PR fixes the glitching by removing the code in `NGNode.renderRectClip`,
>> which made many calculations leading to
On Fri, 2 Aug 2024 21:29:15 GMT, Kevin Rushforth wrote:
> Add the `jdk.jsobject` module to JavaFX. This module is currently delivered
> by the JDK, but will be terminally-deprecated in JDK 24 by
> [JDK-8311530](https://bugs.openjdk.org/browse/JDK-8311530), which is out for
> review at openjdk
On Thu, 23 May 2024 21:51:55 GMT, Marius Hanl wrote:
> Alternative PR to https://github.com/openjdk/jfx/pull/1330 which does not
> modify the layout of `VirtualFlow`.
>
> This PR fixes the glitching by removing the code in `NGNode.renderRectClip`,
> which made many calculations leading to floa
> Incubating a new feature - rich text control, **RichTextArea**, intended to
> bridge the functional gap with Swing and its StyledEditorKit/JEditorPane. The
> main design goal is to provide a control that is complete enough to be useful
> out-of-the box, as well as open to extension by the appl
On Fri, 2 Aug 2024 21:29:15 GMT, Kevin Rushforth wrote:
> Add the `jdk.jsobject` module to JavaFX. This module is currently delivered
> by the JDK, but will be terminally-deprecated in JDK 24 by
> [JDK-8311530](https://bugs.openjdk.org/browse/JDK-8311530), which is out for
> review at openjdk
Add the `jdk.jsobject` module to JavaFX. This module is currently delivered by
the JDK, but will be terminally-deprecated in JDK 24 by
[JDK-8311530](https://bugs.openjdk.org/browse/JDK-8311530), which is out for
review at openjdk/jdk#20555. We therefore plan to start delivering it with
JavaFX
On Thu, 5 Sep 2024 20:29:17 GMT, Andy Goryachev wrote:
>> I've added tests for a `null` argument, as well as for an unsupported type
>> for the `BORDER_IMAGE_SOURCE` and `BACKGROUND_IMAGE` mappings.
>>
>> As for your third bullet point, I think you mean `convert` and not
>> `convertBack`. You
> This PR completes the CSS Transitions story (see #870) by adding
> interpolation support for backgrounds and borders, making them targetable by
> transitions.
>
> `Background` and `Border` objects are deeply immutable, but not
> interpolatable. Consider the following `Background`, which descr
On Thu, 5 Sep 2024 19:57:35 GMT, Michael Strauß wrote:
>> - does `convertBack` need a failing scenario?
>> - does `convertBack` accept null argument?
>> - since we are dealing with type erasure and possible quirks of `CssParser`,
>> would it make sense to test the case when a wrong type is being
On Thu, 5 Sep 2024 19:26:01 GMT, Andy Goryachev wrote:
>> I agree when there's added value, but in this particular case I don't know
>> what to add...
>> Note that `convertBack()` is exercised in `reconstructedObjectMustBeEqual()`.
>
> - does `convertBack` need a failing scenario?
> - does `conv
> This PR completes the CSS Transitions story (see #870) by adding
> interpolation support for backgrounds and borders, making them targetable by
> transitions.
>
> `Background` and `Border` objects are deeply immutable, but not
> interpolatable. Consider the following `Background`, which descr
On Thu, 5 Sep 2024 19:18:09 GMT, Michael Strauß wrote:
>> modules/javafx.graphics/src/test/java/test/javafx/scene/layout/BackgroundConverterTest.java
>> line 51:
>>
>>> 49: import static org.junit.jupiter.api.Assertions.*;
>>> 50:
>>> 51: public class BackgroundConverterTest {
>>
>> this is m
On Thu, 5 Sep 2024 16:22:58 GMT, Andy Goryachev wrote:
>> Michael Strauß has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> changes per review
>
> modules/javafx.graphics/src/test/java/test/javafx/scene/layout/BackgroundConverterTest.java
>
> This PR completes the CSS Transitions story (see #870) by adding
> interpolation support for backgrounds and borders, making them targetable by
> transitions.
>
> `Background` and `Border` objects are deeply immutable, but not
> interpolatable. Consider the following `Background`, which descr
On Thu, 5 Sep 2024 18:54:11 GMT, Michael Strauß wrote:
>> modules/javafx.graphics/src/test/java/test/javafx/css/StyleableProperty_transition_Test.java
>> line 198:
>>
>>> 196: void setup() {
>>> 197: toolkit = (StubToolkit)Toolkit.getToolkit();
>>> 198: scene = new Scene(new
On Thu, 5 Sep 2024 16:53:23 GMT, Andy Goryachev wrote:
>> Michael Strauß has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> changes per review
>
> modules/javafx.graphics/src/main/java/javafx/scene/Node.java line 9043:
>
>> 9041:
On Thu, 5 Sep 2024 18:42:48 GMT, Michael Strauß wrote:
>> modules/javafx.graphics/src/main/java/javafx/scene/layout/Border.java line
>> 418:
>>
>>> 416: * {@inheritDoc}
>>> 417: *
>>> 418: * @throws NullPointerException {@inheritDoc}
>>
>> @kevinrushforth : is there a bug in jav
> This PR completes the CSS Transitions story (see #870) by adding
> interpolation support for backgrounds and borders, making them targetable by
> transitions.
>
> `Background` and `Border` objects are deeply immutable, but not
> interpolatable. Consider the following `Background`, which descr
On Thu, 5 Sep 2024 16:18:34 GMT, Andy Goryachev wrote:
>> Michael Strauß has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> changes per review
>
> modules/javafx.graphics/src/test/java/test/javafx/css/StyleableProperty_transition_Test.java
On Thu, 5 Sep 2024 16:42:38 GMT, Andy Goryachev wrote:
>> Michael Strauß has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> changes per review
>
> modules/javafx.graphics/src/main/java/javafx/scene/Node.java line 639:
>
>> 637:
On Thu, 5 Sep 2024 15:38:20 GMT, Andy Goryachev wrote:
>> Michael Strauß has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> changes per review
>
> modules/javafx.graphics/src/main/java/javafx/scene/layout/Border.java line
> 418:
>
>> 416:
On Thu, 5 Sep 2024 17:24:50 GMT, Andy Goryachev wrote:
> What is the benefit of this change?
It enforces a system invariant at compile-time instead of run-time.
> Also, this change is breaking. One can currently create a Node:
>
> ```
> public class CanCreateNode extends Application {
> @O
On Thu, 5 Sep 2024 12:01:23 GMT, Michael Strauß wrote:
> None of these classes can be extended by user code, and any attempt to do so
> will fail at runtime with an exception. For this reason, we can seal the
> class hierarchy and remove the run-time checks to turn this into a
> compile-time e
On Thu, 5 Sep 2024 00:42:30 GMT, Michael Strauß wrote:
>> This PR completes the CSS Transitions story (see #870) by adding
>> interpolation support for backgrounds and borders, making them targetable by
>> transitions.
>>
>> `Background` and `Border` objects are deeply immutable, but not
>> i
None of these classes can be extended by user code, and any attempt to do so
will fail at runtime with an exception. For this reason, we can seal the class
hierarchy and remove the run-time checks to turn this into a compile-time error
instead.
In some cases, `Node` and `Shape` are extended by
28 matches
Mail list logo
