On Thu, 5 Sep 2024 16:22:58 GMT, Andy Goryachev <ango...@openjdk.org> wrote:
>> Michael Strauß has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> changes per review
>
> modules/javafx.graphics/src/test/java/test/javafx/scene/layout/BackgroundConverterTest.java
> line 51:
>
>> 49: import static org.junit.jupiter.api.Assertions.*;
>> 50:
>> 51: public class BackgroundConverterTest {
>
> this is minor, but applicable to other tests:
>
> it would be nice to have a short basic description of the test, for human
> consumption.
>
> Example:
> Tests BackgroundConverter functions
> - from url
> - convert from image
> - equality of reconstructed objects
> (this is just an example)
>
> Also, should it also test `convertBack()` ?
I agree when there's added value, but in this particular case I don't know what
to add...
Note that `convertBack()` is exercised in `reconstructedObjectMustBeEqual()`.
-------------
PR Review Comment: https://git.openjdk.org/jfx/pull/1522#discussion_r1746050295
