Re: RFR: 8325445: [macOS] Colors are not displayed in sRGB color space [v3]

2024-07-29 Thread Andy Goryachev
On Sat, 27 Jul 2024 20:18:11 GMT, Martin Fox wrote: >> When drawing to the screen JavaFX is producing sRGB colors but on macOS >> that’s not necessarily what the user is seeing. Since the pixels are not >> tagged as sRGB the OS is copying them unmodified to the frame buffer to be >> displayed

Re: RFR: 8337281: build.gradle assumes all modules are named "javafx.$project" [v2]

2024-07-29 Thread Andy Goryachev
On Fri, 26 Jul 2024 23:00:33 GMT, Kevin Rushforth wrote: >> This PR fixes a bad assumption in a few places in `build.gradle`, which >> assumes that the module name can be derived from the name of the gradle >> project name by prepending `"javafx."` to the name rather than using the >> `moduleN

Re: RFR: 8320232: Cells duplicated when table collapsed and expanded

2024-07-29 Thread Andy Goryachev
On Mon, 29 Jul 2024 18:45:23 GMT, Marius Hanl wrote: > This PR fixes a bug where a `TableView` inside a `TitledPane` may 'duplicate' > the cells. This actually has nothing to do with the `TitledPane`, but it > triggered the bug easily due to its nature to change the size of his content > when

Re: RFR: 8329820: [Linux] Prefer EGL over GLX [v15]

2024-07-29 Thread Thiago Milczarek Sayao
On Mon, 29 Jul 2024 17:14:54 GMT, Thiago Milczarek Sayao wrote: >> Wayland implementation will require EGL. >> >> EGL works with Xorg as well. The idea is to be EGL first and if it fails, >> fallback to GLX. A force flag `prism.es2.forceGLX=true` is available. >> >> >> See: >> [Switching th

Re: RFR: 8320232: Cells duplicated when table collapsed and expanded

2024-07-29 Thread Marius Hanl
On Mon, 29 Jul 2024 19:21:03 GMT, Andy Goryachev wrote: > Does this change affect `TreeView`? All components that use the `VirtualFlow`, but it might be more noticeable for some than others. In fact, I first noticed this behavior in `Dialog`s. I will add a reproducer for that one ticket as we

Re: RFR: 8320232: Cells duplicated when table collapsed and expanded

2024-07-29 Thread Andy Goryachev
On Mon, 29 Jul 2024 18:45:23 GMT, Marius Hanl wrote: > This PR fixes a bug where a `TableView` inside a `TitledPane` may 'duplicate' > the cells. This actually has nothing to do with the `TitledPane`, but it > triggered the bug easily due to its nature to change the size of his content > when

RFR: 8320232: Cells duplicated when table collapsed and expanded

2024-07-29 Thread Marius Hanl
This PR fixes a bug where a `TableView` inside a `TitledPane` may 'duplicate' the cells. This actually has nothing to do with the `TitledPane`, but it triggered the bug easily due to its nature to change the size of his content when collapsing. The expansion change of a `TitledPane` triggered a

RFR: 8337400: [Linux] Initial window position is not centered on Ubuntu 24.04 / Xorg

2024-07-29 Thread Thiago Milczarek Sayao
On Ubuntu 24.04 with Xorg windows are not shown centered. This is due a configure event being received with position 0,0 which is wrong. The fix ignores the configure events until the window is mapped. - Commit messages: - 8337400: [Linux] Initial window position is not centered on

Re: RFR: 8329820: [Linux] Prefer EGL over GLX [v15]

2024-07-29 Thread Thiago Milczarek Sayao
> Wayland implementation will require EGL. > > EGL works with Xorg as well. The idea is to be EGL first and if it fails, > fallback to GLX. A force flag `prism.es2.forceGLX=true` is available. > > > See: > [Switching the Linux graphics stack from GLX to > EGL](https://mozillagfx.wordpress.com

Re: RFR: 8332222: Linux Debian: Maximized stage shrinks when opening another stage [v5]

2024-07-29 Thread Jose Pereda
On Mon, 29 Jul 2024 14:29:17 GMT, Thiago Milczarek Sayao wrote: >> Specific to KDE, in the case of the example provided, when an MODAL window >> pops, it calls `set_enabled` `false` on the child (or all other windows if >> APPLICATION_MODAL) which causes it to update the window constraints. Wh

Integrated: 8337229: Missing @Overrides in GlassSystemMenuShim

2024-07-29 Thread Andy Goryachev
On Thu, 25 Jul 2024 19:07:01 GMT, Andy Goryachev wrote: > Added missing @Overrides > > We need to turn this warning into error in the gradle build. This pull request has now been integrated. Changeset: cb7127d4 Author:Andy Goryachev URL: https://git.openjdk.org/jfx/commit/cb7127d4b

Integrated: 8337228: Eclipse: missing dependencies in systemTests-test project

2024-07-29 Thread Andy Goryachev
On Thu, 25 Jul 2024 19:03:14 GMT, Andy Goryachev wrote: > Fixed Eclipse .classpath in the systemTests-test project. This pull request has now been integrated. Changeset: 686a396c Author:Andy Goryachev URL: https://git.openjdk.org/jfx/commit/686a396c6f1a5ee0733a69a046d2131f4649eca8 S

Re: RFR: 8332222: Linux Debian: Maximized stage shrinks when opening another stage [v5]

2024-07-29 Thread Thiago Milczarek Sayao
On Mon, 29 Jul 2024 14:29:17 GMT, Thiago Milczarek Sayao wrote: >> Specific to KDE, in the case of the example provided, when an MODAL window >> pops, it calls `set_enabled` `false` on the child (or all other windows if >> APPLICATION_MODAL) which causes it to update the window constraints. Wh

Re: RFR: 8332222: Linux Debian: Maximized stage shrinks when opening another stage [v3]

2024-07-29 Thread Thiago Milczarek Sayao
On Mon, 17 Jun 2024 23:34:06 GMT, Andy Goryachev wrote: > I've tested a bit more on linux mint (not a KDE desktop), see no ill effects. > > There were a couple of warnings opening modal and regular windows, but the > same warnings are present in the master branch. > > For completeness sake, he

Re: RFR: 8332222: Linux Debian: Maximized stage shrinks when opening another stage [v5]

2024-07-29 Thread Thiago Milczarek Sayao
On Mon, 29 Jul 2024 14:29:17 GMT, Thiago Milczarek Sayao wrote: >> Specific to KDE, in the case of the example provided, when an MODAL window >> pops, it calls `set_enabled` `false` on the child (or all other windows if >> APPLICATION_MODAL) which causes it to update the window constraints. Wh

Re: RFR: 8332222: Linux Debian: Maximized stage shrinks when opening another stage [v5]

2024-07-29 Thread Thiago Milczarek Sayao
> This fixes two bugs appointed on the JBS issue: > > 1) Sometimes window was moving to the top left corner - seems to be a bug > somewhere in `gdk_window_get_origin` when used before map (a X concept when > the window appears). The change is to ignore the configure events (happens > when locat

Re: RFR: 8332222: Linux Debian: Maximized stage shrinks when opening another stage [v4]

2024-07-29 Thread Thiago Milczarek Sayao
> This fixes two bugs appointed on the JBS issue: > > 1) Sometimes window was moving to the top left corner - seems to be a bug > somewhere in `gdk_window_get_origin` when used before map (a X concept when > the window appears). The change is to ignore the configure events (happens > when locat