Re: RFR: 8334713: WebKit build failed on LoongArch64 because currentStackPointer is undefined

2024-06-26 Thread Hima Bindu Meda
On Fri, 21 Jun 2024 09:02:43 GMT, Ao Qi wrote: > This problem has been fixed > [upstream](https://github.com/WebKit/WebKit/pull/23282). This patch merges > the fix in advance. > > Error log: > > > /some_dir/jfx/modules/javafx.web/src/main/native/Source/WTF/wtf/StackPointer.cpp:140:2: > erro

Re: RFR: 8335218: Eclipse Config: Remove Gradle Integration

2024-06-26 Thread Kevin Rushforth
On Wed, 26 Jun 2024 21:23:34 GMT, Andy Goryachev wrote: > This might be controversial. I am proposing to remove the Gradle integration > in the Eclipse config files. > > Problem > === > Eclipse Gradle integration (Buildship) cannot import the OpenJFX build.gradle > cleanly. Every time the

RFR: 8335218: Eclipse Config: Remove Gradle Integration

2024-06-26 Thread Andy Goryachev
This might be controversial. I am proposing to remove the Gradle integration in the Eclipse config files. Problem === Eclipse Gradle integration (Buildship) cannot import the OpenJFX build.gradle cleanly. Every time the project is imported into a new workspace (or re-opened after being clos

Re: RFR: 8326619: Stage.sizeToScene() on maximized/fullscreen Stage breaks the Window [v3]

2024-06-26 Thread Kevin Rushforth
On Tue, 2 Apr 2024 14:20:14 GMT, Lukasz Kostyra wrote: >> Marius Hanl has updated the pull request incrementally with one additional >> commit since the last revision: >> >> improve tests > > LGTM, tests also seem to be fine on my end (checked on Windows and Ubuntu > 22.04 LTS) @lukostyra P

Re: RFR: 8326619: Stage.sizeToScene() on maximized/fullscreen Stage breaks the Window [v8]

2024-06-26 Thread Kevin Rushforth
On Tue, 25 Jun 2024 08:01:49 GMT, Marius Hanl wrote: >> This PR fixes the problem that maximizing/fullscreen a `Stage` or `Dialog` >> is broken when `sizeToScene()` was called before or after. >> >> The approach here is to ignore the `sizeToScene()` request when the `Stage` >> is maximized or

Re: RFR: 8334713: WebKit build failed on LoongArch64 because currentStackPointer is undefined

2024-06-26 Thread Kevin Rushforth
On Fri, 21 Jun 2024 09:02:43 GMT, Ao Qi wrote: > This problem has been fixed > [upstream](https://github.com/WebKit/WebKit/pull/23282). This patch merges > the fix in advance. > > Error log: > > > /some_dir/jfx/modules/javafx.web/src/main/native/Source/WTF/wtf/StackPointer.cpp:140:2: > erro

Re: RFR: 8334161: Enable -Werror for javac tasks to fail on any warnings

2024-06-26 Thread Kevin Rushforth
On Wed, 12 Jun 2024 21:57:32 GMT, Kevin Rushforth wrote: > This PR is a follow-on to #1474. > > Enable `javac -Werror` so that javac warnings, including but not limited to > javac lint warnings, will cause the build to fail. As with the fix for > [JDK-8327255](https://bugs.openjdk.org/browse/J

Integrated: 8334161: Enable -Werror for javac tasks to fail on any warnings

2024-06-26 Thread Kevin Rushforth
On Wed, 12 Jun 2024 21:57:32 GMT, Kevin Rushforth wrote: > This PR is a follow-on to #1474. > > Enable `javac -Werror` so that javac warnings, including but not limited to > javac lint warnings, will cause the build to fail. As with the fix for > [JDK-8327255](https://bugs.openjdk.org/browse/J

Integrated: 8314754: Minor ticks are not getting updated both the axes in LineChart

2024-06-26 Thread Markus Mack
On Tue, 25 Jun 2024 15:14:14 GMT, Markus Mack wrote: > This PR ensures the `tickMarksUpdated()` method (overriden with minor tick > mark layout code in subclasses) is called during `Chart` `Axis` layout when > needed. > Previously, it was only called when tick mark length or range was changed,

Integrated: 8311124: [Windows] User installed font 8281327 fix does not work for all cases

2024-06-26 Thread Phil Race
On Mon, 24 Jun 2024 22:01:09 GMT, Phil Race wrote: > The problem is due to per-user install fonts on windows having full paths so > they may be too long. > This is identical to the JDK fix that was done some time ago > https://github.com/openjdk/jdk/pull/13359 > I've tested that per-user fonts

Re: RFR: 8334161: Enable -Werror for javac tasks to fail on any warnings

2024-06-26 Thread Ambarish Rapte
On Wed, 12 Jun 2024 21:57:32 GMT, Kevin Rushforth wrote: > This PR is a follow-on to #1474. > > Enable `javac -Werror` so that javac warnings, including but not limited to > javac lint warnings, will cause the build to fail. As with the fix for > [JDK-8327255](https://bugs.openjdk.org/browse/J

Re: RFR: 8311124: [Windows] User installed font 8281327 fix does not work for all cases

2024-06-26 Thread Kevin Rushforth
On Mon, 24 Jun 2024 22:01:09 GMT, Phil Race wrote: > The problem is due to per-user install fonts on windows having full paths so > they may be too long. > This is identical to the JDK fix that was done some time ago > https://github.com/openjdk/jdk/pull/13359 > I've tested that per-user fonts

Re: RFR: 8299753: Tree/TableView: Column Resizing With Fractional Scale [v15]

2024-06-26 Thread Andy Goryachev
> Modified the resize algorithm to work well with fractional scale, thanks for > deeper understanding of the problem thanks to @hjohn and @mstr2 . > > Removed earlier manual tester in favor of the monkey tester. > > It is important to note that even though the constraints are given by the > us

Re: RFR: 8299753: Tree/TableView: Column Resizing With Fractional Scale [v14]

2024-06-26 Thread Andy Goryachev
On Mon, 10 Jun 2024 15:06:30 GMT, Andy Goryachev wrote: >> Modified the resize algorithm to work well with fractional scale, thanks for >> deeper understanding of the problem thanks to @hjohn and @mstr2 . >> >> Removed earlier manual tester in favor of the monkey tester. >> >> It is important

Re: RFR: 8314754: Minor ticks are not getting updated both the axes in LineChart [v3]

2024-06-26 Thread Andy Goryachev
On Wed, 26 Jun 2024 06:33:43 GMT, Markus Mack wrote: >> This PR ensures the `tickMarksUpdated()` method (overriden with minor tick >> mark layout code in subclasses) is called during `Chart` `Axis` layout when >> needed. >> Previously, it was only called when tick mark length or range was chang

Re: RFR: 8296387: [Tooltip, CSS] -fx-show-delay is only applied to the first tooltip that is shown before it is displayed [v8]

2024-06-26 Thread Andy Goryachev
On Wed, 26 Jun 2024 10:43:30 GMT, Marius Hanl wrote: >> This PR fixes a long standing issue where the `Tooltip` will always wait one >> second until it appears the very first time, even if the >> `-fx-show-delay` was set to another value. >> >> The culprit is, that the `cssForced` flag is not

Re: RFR: 8311124: [Windows] User installed font 8281327 fix does not work for all cases

2024-06-26 Thread Lukasz Kostyra
On Mon, 24 Jun 2024 22:01:09 GMT, Phil Race wrote: > The problem is due to per-user install fonts on windows having full paths so > they may be too long. > This is identical to the JDK fix that was done some time ago > https://github.com/openjdk/jdk/pull/13359 > I've tested that per-user fonts

Re: RFR: 8296387: [Tooltip, CSS] -fx-show-delay is only applied to the first tooltip that is shown before it is displayed [v8]

2024-06-26 Thread Marius Hanl
> This PR fixes a long standing issue where the `Tooltip` will always wait one > second until it appears the very first time, even if the > `-fx-show-delay` was set to another value. > > The culprit is, that the `cssForced` flag is not inside `Tooltip`, but inside > the `TooltipBehaviour`. So t

Re: RFR: 8296387: [Tooltip, CSS] -fx-show-delay is only applied to the first tooltip that is shown before it is displayed [v6]

2024-06-26 Thread Marius Hanl
On Tue, 25 Jun 2024 23:13:01 GMT, Andy Goryachev wrote: > question is - do we really need to expose this method (for custom popup > windows, for example), or not? I can not really see why this is needed, other than maybe to not copy any style from the owner. It is hard to guess a usecase, so

Re: RFR: 8322619: Parts of SG no longer update during rendering - overlapping - culling - dirty [v5]

2024-06-26 Thread eduardsdv
On Fri, 3 May 2024 10:23:27 GMT, Florian Kirmaier wrote: >> In some situations, a part of the SG is no longer rendered. >> I created a test program that showcases this problem. >> >> Explanation: >> >> This can happen, when a part of the SG, is covered by another Node. >> In this part, one node

Re: RFR: 8322619: Parts of SG no longer update during rendering - overlapping - culling - dirty

2024-06-26 Thread eduardsdv
On Mon, 6 May 2024 14:14:05 GMT, eduardsdv wrote: > This is an alternative solution to the PR: > https://github.com/openjdk/jfx/pull/1310. > > This solution is based on the invariant that if a node is marked as dirty, > all ancestors must also be marked as dirty and that if an ancestor is mark

Re: RFR: 8314754: Minor ticks are not getting updated both the axes in LineChart [v3]

2024-06-26 Thread Marius Hanl
On Wed, 26 Jun 2024 06:33:43 GMT, Markus Mack wrote: >> This PR ensures the `tickMarksUpdated()` method (overriden with minor tick >> mark layout code in subclasses) is called during `Chart` `Axis` layout when >> needed. >> Previously, it was only called when tick mark length or range was chang