On Fri, 21 Jun 2024 09:02:43 GMT, Ao Qi <a...@openjdk.org> wrote: > This problem has been fixed > [upstream](https://github.com/WebKit/WebKit/pull/23282). This patch merges > the fix in advance. > > Error log: > > > /some_dir/jfx/modules/javafx.web/src/main/native/Source/WTF/wtf/StackPointer.cpp:140:2: > error: #error "Unsupported platform: need implementation of > currentStackPointer." > 140 | #error "Unsupported platform: need implementation of > currentStackPointer." > | ^~~~~ > make[2]: *** [Source/WTF/wtf/CMakeFiles/WTF.dir/build.make:1098: > Source/WTF/wtf/CMakeFiles/WTF.dir/StackPointer.cpp.o] Error 1 > make[2]: *** Waiting for unfinished jobs.... > make[1]: *** [CMakeFiles/Makefile2:360: > Source/WTF/wtf/CMakeFiles/WTF.dir/all] Error 2
Looks fine. @HimaBinduMeda said she will also review it. ------------- Marked as reviewed by kcr (Lead). PR Review: https://git.openjdk.org/jfx/pull/1482#pullrequestreview-2142936019
