Re: RFR: 8332222: Linux Debian: Maximized stage shrinks when opening another stage

2024-05-22 Thread Karthik P K
On Wed, 22 May 2024 21:28:47 GMT, Thiago Milczarek Sayao wrote: > This fixes two bugs appointed on the JBS issue: > > 1) Sometimes window was moving to the top left corner - seems to be a bug > somewhere in `gdk_window_get_origin` when used before map (a X concept when > the window appears).

Withdrawn: 8327179: Update the 3D lighting application

2024-05-22 Thread duke
On Sun, 3 Mar 2024 22:29:02 GMT, Nir Lisker wrote: > Update for the 3D lighting test tool as described in the JBS issue. This pull request has been closed without being integrated. - PR: https://git.openjdk.org/jfx/pull/1387

Re: CFV: New OpenJFX Reviewer: John Hendrikx

2024-05-22 Thread Andy Goryachev
Vote: YES -andy From: openjfx-dev on behalf of Kevin Rushforth Date: Wednesday, May 22, 2024 at 16:24 To: openjfx-dev , John Hendrikx Subject: CFV: New OpenJFX Reviewer: John Hendrikx I hereby nominate John Hendrikx [1] to OpenJFX Reviewer. John is an OpenJFX community member, who has co

Re: CFV: New OpenJFX Reviewer: John Hendrikx

2024-05-22 Thread Kevin Rushforth
Vote: YES -- Kevin On 5/22/2024 4:24 PM, Kevin Rushforth wrote: I hereby nominate John Hendrikx [1] to OpenJFX Reviewer.

CFV: New OpenJFX Reviewer: John Hendrikx

2024-05-22 Thread Kevin Rushforth
I hereby nominate John Hendrikx [1] to OpenJFX Reviewer. John is an OpenJFX community member, who has contributed 39 commits [2] to OpenJFX. John regularly participates in code reviews, especially in the areas of JavaFX properties, scene graph and UI controls, offering valuable feedback. Vot

Re: RFR: 8329820: [Linux] Prefer EGL over GLX [v12]

2024-05-22 Thread Thiago Milczarek Sayao
On Wed, 22 May 2024 22:02:33 GMT, Thiago Milczarek Sayao wrote: >> Wayland implementation will require EGL. >> >> EGL works with Xorg as well. The idea is to be EGL first and if it fails, >> fallback to GLX. A force flag `prism.es2.forceGLX=true` is available. >> >> >> See: >> [Switching th

Re: RFR: 8329820: [Linux] Prefer EGL over GLX [v12]

2024-05-22 Thread Thiago Milczarek Sayao
> Wayland implementation will require EGL. > > EGL works with Xorg as well. The idea is to be EGL first and if it fails, > fallback to GLX. A force flag `prism.es2.forceGLX=true` is available. > > > See: > [Switching the Linux graphics stack from GLX to > EGL](https://mozillagfx.wordpress.com

Re: RFR: 8329820: [Linux] Prefer EGL over GLX [v11]

2024-05-22 Thread Thiago Milczarek Sayao
On Sun, 12 May 2024 11:03:36 GMT, Thiago Milczarek Sayao wrote: >> Wayland implementation will require EGL. >> >> EGL works with Xorg as well. The idea is to be EGL first and if it fails, >> fallback to GLX. A force flag `prism.es2.forceGLX=true` is available. >> >> >> See: >> [Switching th

RFR: 8332222: Linux Debian: Maximized stage shrinks when opening another stage

2024-05-22 Thread Thiago Milczarek Sayao
This fixes two bugs appointed on the JBS issue: 1) Sometimes window was moving to the top left corner - seems to be a bug somewhere in `gdk_window_get_origin` when used before map (a X concept when the window appears). The change is to ignore the configure events (happens when location or size

PLEASE READ: Updates Code Review Policies

2024-05-22 Thread Kevin Rushforth
To: All jfx contributors, particularly those with a Reviewer or Committer role in the OpenJFX project on OpenJDK [1] As some of you are already aware, we have modified the JavaFX Code Review policies, including additional requirements for Reviewers, PR authors, and sponsoring Committers. The u

Integrated: 8332313: Update code review guidelines

2024-05-22 Thread Kevin Rushforth
On Wed, 15 May 2024 17:45:56 GMT, Kevin Rushforth wrote: > Update the code review guidelines for JavaFX. > > The JavaFX > [CONTRIBUTING](https://github.com/kevinrushforth/jfx/blob/8332313-contributing/CONTRIBUTING.md) > guidelines includes guidance for creating, reviewing, and integrating > c

Re: RFR: 8323511: Scrollbar Click jumps inconsistent amount of pixels [v9]

2024-05-22 Thread Florian Kirmaier
> As seen in the unit test of the PR, when we click on the area above/below the > scrollbar the position jumps - but the jump is now not always consistent. > In the current version on the last cell - the UI always jumps to the top. In > the other cases, the assumed default cell height is used. >

Re: RFR: 8332313: Update code review guidelines [v4]

2024-05-22 Thread Johan Vos
On Tue, 21 May 2024 22:32:21 GMT, Kevin Rushforth wrote: >> Update the code review guidelines for JavaFX. >> >> The JavaFX >> [CONTRIBUTING](https://github.com/kevinrushforth/jfx/blob/8332313-contributing/CONTRIBUTING.md) >> guidelines includes guidance for creating, reviewing, and integrating

Integrated: 8313138: Scrollbar Keyboard enhancement

2024-05-22 Thread Andy Goryachev
On Wed, 6 Mar 2024 19:55:54 GMT, Andy Goryachev wrote: > Adding alt-ctrl-LEFT/RIGHT/UP/DOWN (option-command-LEFT/RIGHT/UP/DOWN) key > bindings to > > - ListView > - TreeView > - TableView > - TreeTableView > > to support keyboard-only horizontal and vertical scrolling. The main reason > for

Re: RFR: 8323511: Scrollbar Click jumps inconsistent amount of pixels [v8]

2024-05-22 Thread Kevin Rushforth
On Wed, 22 May 2024 08:36:22 GMT, eduardsdv wrote: >>> @johanvos added a question in the CSR about this last part: >>> >>> > I understand and agree with the goal behind this. >>> > I'm a bit confused though about the following: "...but it does not >>> > necessarily have to be the same value." -

Re: RFR: 8289115: Touch events is not dispatched after upgrade to JAVAFX17+

2024-05-22 Thread Kevin Rushforth
On Wed, 22 May 2024 08:10:16 GMT, Jose Pereda wrote: >> This PR fixes a bug >> ([JDK-8289115](https://bugs.openjdk.org/browse/JDK-8289115)) that was >> introduced with #394, which changed the following line in the >> `NotifyTouchInput` function (ViewContainer.cpp): >> >> - const bool isDirect

Re: RFR: 8332313: Update code review guidelines [v4]

2024-05-22 Thread Kevin Rushforth
On Tue, 21 May 2024 22:32:21 GMT, Kevin Rushforth wrote: >> Update the code review guidelines for JavaFX. >> >> The JavaFX >> [CONTRIBUTING](https://github.com/kevinrushforth/jfx/blob/8332313-contributing/CONTRIBUTING.md) >> guidelines includes guidance for creating, reviewing, and integrating

Re: RFR: 8332313: Update code review guidelines [v4]

2024-05-22 Thread John Hendrikx
On Tue, 21 May 2024 22:32:21 GMT, Kevin Rushforth wrote: >> Update the code review guidelines for JavaFX. >> >> The JavaFX >> [CONTRIBUTING](https://github.com/kevinrushforth/jfx/blob/8332313-contributing/CONTRIBUTING.md) >> guidelines includes guidance for creating, reviewing, and integrating

Re: RFR: 8323511: Scrollbar Click jumps inconsistent amount of pixels [v8]

2024-05-22 Thread eduardsdv
On Wed, 22 May 2024 06:39:18 GMT, Johan Vos wrote: >> modules/javafx.controls/src/main/java/javafx/scene/control/skin/VirtualFlow.java >> line 1918: >> >>> 1916: * Returns the length of the viewport portion of the {@code >>> VirtualFlow} as computed during the layout pass. >>> 1917:

Re: RFR: 8289115: Touch events is not dispatched after upgrade to JAVAFX17+

2024-05-22 Thread Jose Pereda
On Tue, 21 May 2024 14:25:51 GMT, Michael Strauß wrote: > This PR fixes a bug > ([JDK-8289115](https://bugs.openjdk.org/browse/JDK-8289115)) that was > introduced with #394, which changed the following line in the > `NotifyTouchInput` function (ViewContainer.cpp): > > - const bool isDirect =

Re: RFR: 8289115: Touch events is not dispatched after upgrade to JAVAFX17+

2024-05-22 Thread Michael Strauß
On Tue, 21 May 2024 14:25:51 GMT, Michael Strauß wrote: > This PR fixes a bug > ([JDK-8289115](https://bugs.openjdk.org/browse/JDK-8289115)) that was > introduced with #394, which changed the following line in the > `NotifyTouchInput` function (ViewContainer.cpp): > > - const bool isDirect =