The javadoc for `Region.getPrefHeight() / getPrefWidth()` incorrectly refers to
`getPrefHeight(forWidth) / getPrefWidth(forHeight)`
should be
`prefHeight(forWidth) / prefWidth(forHeight)`
- also converted these references to `{@link}`s.
-
Commit messages:
- 8332251: javadoc: inco
Dear John:
Thank you for a thoughtful response!
I am a bit surprised - the point #1 you are trying to make is explicitly
supported by the new API. The new API introduces a (fixed) number of
priorities to the Controls' event handling specifically to address the issue
you've raised earlier. Ye
On Wed, 15 May 2024 20:18:05 GMT, Phil Race wrote:
>> This is out of scope for this PR, but it might be something to consider
>> addressing in a follow-on enhancement.
>
> It should be made clear (somewhere, at some point) that it would be rare for
> a CSR to be completed and approved before st
On Wed, 15 May 2024 20:08:05 GMT, John Hendrikx wrote:
>> Update the code review guidelines for JavaFX.
>>
>> The JavaFX
>> [CONTRIBUTING](https://github.com/kevinrushforth/jfx/blob/8332313-contributing/CONTRIBUTING.md)
>> guidelines includes guidance for creating, reviewing, and integrating
On Wed, 15 May 2024 19:50:32 GMT, Andy Goryachev wrote:
>> README-code-reviews.md line 60:
>>
>>> 58: * If you want an area expert to review a PR, indicate this in a comment
>>> of the form: `Reviewers: @PERSON1 @PERSON2`; the requested reviewers can
>>> indicate whether or not they plan to re
On Wed, 15 May 2024 20:23:37 GMT, Nir Lisker wrote:
>> Isn't this automatic? Seems weird you could integrate without these passing.
>
>> or is it? :-)
>
> 
>
> Looks to me like it is...
A passing GHA t
On Wed, 15 May 2024 20:12:09 GMT, Phil Race wrote:
>> README-code-reviews.md line 48:
>>
>>> 46: All code reviews must be done via a pull request submitted against this
>>> GitHub repo, [openjdk/jfx](https://github.com/openjdk/jfx). A JBS bug ID
>>> must exist before the pull request will be r
On Wed, 15 May 2024 19:04:19 GMT, Nir Lisker wrote:
>> Update the code review guidelines for JavaFX.
>>
>> The JavaFX
>> [CONTRIBUTING](https://github.com/kevinrushforth/jfx/blob/8332313-contributing/CONTRIBUTING.md)
>> guidelines includes guidance for creating, reviewing, and integrating
>>
On Wed, 15 May 2024 20:33:37 GMT, Andy Goryachev wrote:
>> He means people reading reviews are usually on github and your github ID is
>> kevinrusforth,
>> so they might be confused by "kcr" which is your openjdk id.
>>
>> Since the context is identifying OpenJDK Project leads, I think the Open
On Wed, 15 May 2024 20:07:06 GMT, Phil Race wrote:
>> Update the code review guidelines for JavaFX.
>>
>> The JavaFX
>> [CONTRIBUTING](https://github.com/kevinrushforth/jfx/blob/8332313-contributing/CONTRIBUTING.md)
>> guidelines includes guidance for creating, reviewing, and integrating
>> c
On Wed, 15 May 2024 17:45:56 GMT, Kevin Rushforth wrote:
> Update the code review guidelines for JavaFX.
>
> The JavaFX
> [CONTRIBUTING](https://github.com/kevinrushforth/jfx/blob/8332313-contributing/CONTRIBUTING.md)
> guidelines includes guidance for creating, reviewing, and integrating
> c
I can only second this.
If anything, the proposal highlights several fundamental problems in
current JavaFX by how it is trying to work around them. The work around
works for one area (key events) but does not address similar problems
for other events. The work around will also further cement
On Tue, 14 May 2024 22:29:18 GMT, Martin Fox wrote:
>> On Linux getKeyCodeForChar does not consult the current keyboard layout. For
>> example, it assumes the “+” character is on KeyCode.PLUS even on layouts
>> which don’t generate KeyCode.PLUS. The result is that most
>> KeyCharacterCombinati
On Wed, 15 May 2024 20:03:01 GMT, Phil Race wrote:
>> Not sure what you mean, but it doesn't seem related to this PR.
>
> He means people reading reviews are usually on github and your github ID is
> kevinrusforth,
> so they might be confused by "kcr" which is your openjdk id.
>
> Since the con
On Wed, 15 May 2024 20:08:10 GMT, John Hendrikx wrote:
>> or is it? :-)
>
> Isn't this automatic? Seems weird you could integrate without these passing.
> or is it? :-)
Looks to me like it is...
---
On Wed, 15 May 2024 19:00:57 GMT, Nir Lisker wrote:
>> Update the code review guidelines for JavaFX.
>>
>> The JavaFX
>> [CONTRIBUTING](https://github.com/kevinrushforth/jfx/blob/8332313-contributing/CONTRIBUTING.md)
>> guidelines includes guidance for creating, reviewing, and integrating
>>
On Wed, 15 May 2024 19:32:04 GMT, Kevin Rushforth wrote:
>> README-code-reviews.md line 103:
>>
>>> 101: To ensure that new features are consistent with the rest of the API
>>> and the desired direction of the Project, a CSR is required for a new
>>> Feature, API addition, or behavioral change
On Wed, 15 May 2024 17:45:56 GMT, Kevin Rushforth wrote:
> Update the code review guidelines for JavaFX.
>
> The JavaFX
> [CONTRIBUTING](https://github.com/kevinrushforth/jfx/blob/8332313-contributing/CONTRIBUTING.md)
> guidelines includes guidance for creating, reviewing, and integrating
> c
On Wed, 15 May 2024 17:45:56 GMT, Kevin Rushforth wrote:
> Update the code review guidelines for JavaFX.
>
> The JavaFX
> [CONTRIBUTING](https://github.com/kevinrushforth/jfx/blob/8332313-contributing/CONTRIBUTING.md)
> guidelines includes guidance for creating, reviewing, and integrating
> c
On Wed, 15 May 2024 19:53:43 GMT, Andy Goryachev wrote:
>> README-code-reviews.md line 68:
>>
>>> 66: * Consider any compatibility concerns
>>> 67: * Check whether there is an automated test; if not, ask for one, if it
>>> is feasible
>>> 68: * Make sure that the PR has executed the GHA tests a
On Wed, 15 May 2024 16:20:04 GMT, Jose Pereda wrote:
> Hi all,
>
> This pull request contains a backport of commit
> [d3da033a](https://github.com/openjdk/jfx/commit/d3da033a2dd5c287733545935242a8d1f71c0554)
> from the [openjdk/jfx](https://git.openjdk.org/jfx) repository.
>
> The commit bein
On Wed, 15 May 2024 18:56:29 GMT, Kevin Rushforth wrote:
>> README-code-reviews.md line 10:
>>
>>> 8:
>>> 9: __Project Co-Lead__: Kevin Rushforth (kcr)
>>> 10: __Project Co-Lead__: Johan Vos (jvos)
>>
>> There are two sets of ids - one for OpenJFX/JBS and one for Github. This
>> might be co
On Wed, 15 May 2024 19:23:25 GMT, Nir Lisker wrote:
>> Update the code review guidelines for JavaFX.
>>
>> The JavaFX
>> [CONTRIBUTING](https://github.com/kevinrushforth/jfx/blob/8332313-contributing/CONTRIBUTING.md)
>> guidelines includes guidance for creating, reviewing, and integrating
>>
On Wed, 15 May 2024 19:16:31 GMT, Nir Lisker wrote:
>> Update the code review guidelines for JavaFX.
>>
>> The JavaFX
>> [CONTRIBUTING](https://github.com/kevinrushforth/jfx/blob/8332313-contributing/CONTRIBUTING.md)
>> guidelines includes guidance for creating, reviewing, and integrating
>>
On Wed, 15 May 2024 17:45:56 GMT, Kevin Rushforth wrote:
> Update the code review guidelines for JavaFX.
>
> The JavaFX
> [CONTRIBUTING](https://github.com/kevinrushforth/jfx/blob/8332313-contributing/CONTRIBUTING.md)
> guidelines includes guidance for creating, reviewing, and integrating
> c
On Wed, 15 May 2024 18:20:22 GMT, Andy Goryachev wrote:
>> Update the code review guidelines for JavaFX.
>>
>> The JavaFX
>> [CONTRIBUTING](https://github.com/kevinrushforth/jfx/blob/8332313-contributing/CONTRIBUTING.md)
>> guidelines includes guidance for creating, reviewing, and integrating
On Wed, 15 May 2024 17:45:56 GMT, Kevin Rushforth wrote:
> Update the code review guidelines for JavaFX.
>
> The JavaFX
> [CONTRIBUTING](https://github.com/kevinrushforth/jfx/blob/8332313-contributing/CONTRIBUTING.md)
> guidelines includes guidance for creating, reviewing, and integrating
> c
On Wed, 15 May 2024 18:05:10 GMT, Andy Goryachev wrote:
>> Update the code review guidelines for JavaFX.
>>
>> The JavaFX
>> [CONTRIBUTING](https://github.com/kevinrushforth/jfx/blob/8332313-contributing/CONTRIBUTING.md)
>> guidelines includes guidance for creating, reviewing, and integrating
On Wed, 15 May 2024 17:45:56 GMT, Kevin Rushforth wrote:
> Update the code review guidelines for JavaFX.
>
> The JavaFX
> [CONTRIBUTING](https://github.com/kevinrushforth/jfx/blob/8332313-contributing/CONTRIBUTING.md)
> guidelines includes guidance for creating, reviewing, and integrating
> c
On Wed, 15 May 2024 17:45:56 GMT, Kevin Rushforth wrote:
> Update the code review guidelines for JavaFX.
>
> The JavaFX
> [CONTRIBUTING](https://github.com/kevinrushforth/jfx/blob/8332313-contributing/CONTRIBUTING.md)
> guidelines includes guidance for creating, reviewing, and integrating
> c
Update the code review guidelines for JavaFX.
The JavaFX
[CONTRIBUTING](https://github.com/kevinrushforth/jfx/blob/8332313-contributing/CONTRIBUTING.md)
guidelines includes guidance for creating, reviewing, and integrating changes
to JavaFX, along with a pointer to a [Code Review
Policies](htt
On Sat, 6 Apr 2024 17:34:06 GMT, Thiago Milczarek Sayao
wrote:
> Simple fix to only request `_NET_FRAME_EXTENTS` if window has decoration.
>
> It seems i3 replies with decorated sizes, even if window is not decorated.
>
> Won't hurt other WMs.
This pull request has now been integrated.
Chang
On Sat, 6 Apr 2024 17:34:06 GMT, Thiago Milczarek Sayao
wrote:
> Simple fix to only request `_NET_FRAME_EXTENTS` if window has decoration.
>
> It seems i3 replies with decorated sizes, even if window is not decorated.
>
> Won't hurt other WMs.
LGTM, tested with and without fix, with and witho
On Wed, 15 May 2024 16:20:04 GMT, Jose Pereda wrote:
> Hi all,
>
> This pull request contains a backport of commit
> [d3da033a](https://github.com/openjdk/jfx/commit/d3da033a2dd5c287733545935242a8d1f71c0554)
> from the [openjdk/jfx](https://git.openjdk.org/jfx) repository.
>
> The commit bein
Hi all,
This pull request contains a backport of commit
[d3da033a](https://github.com/openjdk/jfx/commit/d3da033a2dd5c287733545935242a8d1f71c0554)
from the [openjdk/jfx](https://git.openjdk.org/jfx) repository.
The commit being backported was authored by Oliver Kopp on 8 May 2024 and was
revie
On Tue, 7 May 2024 10:10:23 GMT, Karthik P K wrote:
> The `ComboBox` value was not set to previously selected value in the item
> list change listener when `setAll` method is used to change the items. Fixed
> the issue by restoring the selection in this case.
>
> Added a unit test to validate
On Tue, 14 May 2024 22:27:25 GMT, Andy Goryachev wrote:
>> Karthik P K has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Fix JDK-8279139
>
> It looks like we have quite a few bugs related to different aspects of
> ComboBox. This change i
On Thu, 9 May 2024 19:48:19 GMT, Johan Vos wrote:
>> A listener was added but never removed.
>> This patch removes the listener when the menu it links to is cleared. Fix
>> for https://bugs.openjdk.org/browse/JDK-8319779
>
> Johan Vos has updated the pull request incrementally with one additiona
On Tue, 14 May 2024 05:21:37 GMT, Hima Bindu Meda wrote:
> Updated libxml to v2.12.6. Verified build and sanity testing on all
> platforms. No issue seen
This pull request has now been integrated.
Changeset: 97b14025
Author:Hima Bindu Meda
URL:
https://git.openjdk.org/jfx/commit/97
On Tue, 14 May 2024 11:45:06 GMT, Hima Bindu Meda wrote:
> Update SQLite to v3.45.3.Verified build on all platforms. Sanity testing
> looks fine.
This pull request has now been integrated.
Changeset: 581e3a70
Author:Hima Bindu Meda
URL:
https://git.openjdk.org/jfx/commit/581e3a70a4
On Sat, 6 Apr 2024 17:34:06 GMT, Thiago Milczarek Sayao
wrote:
> Simple fix to only request `_NET_FRAME_EXTENTS` if window has decoration.
>
> It seems i3 replies with decorated sizes, even if window is not decorated.
>
> Won't hurt other WMs.
I could verify that this change fixes the issue w
On Thu, 9 May 2024 09:38:31 GMT, Karthik P K wrote:
>> The `ComboBox` value was not set to previously selected value in the item
>> list change listener when `setAll` method is used to change the items. Fixed
>> the issue by restoring the selection in this case.
>>
>> Added a unit test to vali
Mark,
You may already know this but before JavaFX 21 the Mac and Windows Robot code
had some long-standing bugs with non-US keyboards. Linux is in better shape but
you can encounter problems if the user has installed multiple layouts (I have a
PR pending to fix that). That might explain some of
On Tue, 14 May 2024 05:21:37 GMT, Hima Bindu Meda wrote:
> Updated libxml to v2.12.6. Verified build and sanity testing on all
> platforms. No issue seen
All tests are green here too.
-
Marked as reviewed by sykora (Author).
PR Review: https://git.openjdk.org/jfx/pull/1453#pullre
44 matches
Mail list logo
