Integrated: 8282999: Add support for EXT-X-MEDIA tag in HTTP Live Streaming

2024-05-09 Thread Alexander Matveev
On Tue, 2 Apr 2024 00:18:04 GMT, Alexander Matveev wrote: > - Added support for #EXT-X-MEDIA tag to HTTP Live Streaming. > - Following audio renditions via #EXT-X-MEDIA tag will be supported (see CSR > for more details): > - MP2T streams with one H.264/AVC video track and elementary AAC audio

Re: RFR: 8319779: SystemMenu: memory leak due to listener never being removed [v16]

2024-05-09 Thread Johan Vos
> A listener was added but never removed. > This patch removes the listener when the menu it links to is cleared. Fix for > https://bugs.openjdk.org/browse/JDK-8319779 Johan Vos has updated the pull request incrementally with one additional commit since the last revision: Add more type info

Integrated: 8328603: HLS video stream fails to render consistently

2024-05-09 Thread Alexander Matveev
On Sat, 13 Apr 2024 01:36:01 GMT, Alexander Matveev wrote: > - When video fails to render AVFoundation outputs frame in > `kCVPixelFormatType_420YpCbCr8BiPlanarVideoRange` format which is not > supported. We do force format change after that to > `kCVPixelFormatType_422YpCbCr8`, but AVFoundat

Re: RFR: 8319779: SystemMenu: memory leak due to listener never being removed [v15]

2024-05-09 Thread Johan Vos
> A listener was added but never removed. > This patch removes the listener when the menu it links to is cleared. Fix for > https://bugs.openjdk.org/browse/JDK-8319779 Johan Vos has updated the pull request incrementally with one additional commit since the last revision: Add type info Fix

Re: RFR: 8319779: SystemMenu: memory leak due to listener never being removed [v14]

2024-05-09 Thread Johan Vos
> A listener was added but never removed. > This patch removes the listener when the menu it links to is cleared. Fix for > https://bugs.openjdk.org/browse/JDK-8319779 Johan Vos has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 15 commi

Re: RFR: 8323511: Scrollbar Click jumps inconsistent amount of pixels [v6]

2024-05-09 Thread Andy Goryachev
On Thu, 9 May 2024 17:34:11 GMT, Johan Vos wrote: > the idea about mapping scroll events to the top/bottom of a cell is hinted in > the code though could you please point to these places? I think this change is inline with the modern UIs, at least macOS and Windows. As Eduard correctly point

Re: RFR: 8323511: Scrollbar Click jumps inconsistent amount of pixels [v6]

2024-05-09 Thread Johan Vos
On Thu, 9 May 2024 14:49:26 GMT, Florian Kirmaier wrote: >> As seen in the unit test of the PR, when we click on the area above/below >> the scrollbar the position jumps - but the jump is now not always consistent. >> In the current version on the last cell - the UI always jumps to the top. In

Re: There is no workaround for JDK-8324327

2024-05-09 Thread PavelTurk
Thank you for your answer and explanation. As I understand the problem is not in using the type of the consructor, but in the initial color (from palette or not):     ColorPicker picker = new ColorPicker();     picker.setValue(Color.YELLOW);//this works OK, the color from palette   

Re: There is no workaround for JDK-8324327

2024-05-09 Thread Andy Goryachev
Perhaps I should have left a clearer note. The bug is still there, no one worked on it yet. Changing to the default constructor at least works as expected - the large white square (selected color) appears over the right spot. In the original example, the Color.CORAL is apparently not a part o

There is no workaround for JDK-8324327

2024-05-09 Thread PavelTurk
Hello all. This is about https://bugs.openjdk.org/browse/JDK-8324327 . Andy Goryachev wrote in comment "Change to the default constructor and the issue disappears". I don't see that using default constructor solves the problem. I tried the following code : public class JavaFxTest7 extends App

Re: RFR: 8323511: Scrollbar Click jumps inconsistent amount of pixels [v5]

2024-05-09 Thread eduardsdv
On Thu, 9 May 2024 14:31:56 GMT, Kevin Rushforth wrote: >> Florian Kirmaier has updated the pull request incrementally with one >> additional commit since the last revision: >> >> JDK-8323511: Mage getViewportLength() public and use it instead of >> getBlockIncrement() > > modules/javafx.con

Re: RFR: 8323511: Scrollbar Click jumps inconsistent amount of pixels [v2]

2024-05-09 Thread eduardsdv
On Wed, 13 Mar 2024 08:55:14 GMT, Florian Kirmaier wrote: >> @FlorianKirmaier I still think this would be a good addition. I believe >> there is only one open question (from Marius) so it would be great if you >> can answer that. > > @johanvos > Great to see you would like to see it merged! >

Re: RFR: 8323511: Scrollbar Click jumps inconsistent amount of pixels [v6]

2024-05-09 Thread Florian Kirmaier
> As seen in the unit test of the PR, when we click on the area above/below the > scrollbar the position jumps - but the jump is now not always consistent. > In the current version on the last cell - the UI always jumps to the top. In > the other cases, the assumed default cell height is used. >

Re: RFR: 8323511: Scrollbar Click jumps inconsistent amount of pixels [v5]

2024-05-09 Thread Kevin Rushforth
On Thu, 9 May 2024 10:01:34 GMT, Florian Kirmaier wrote: >> As seen in the unit test of the PR, when we click on the area above/below >> the scrollbar the position jumps - but the jump is now not always consistent. >> In the current version on the last cell - the UI always jumps to the top. In

Re: RFR: 8282999: Add support for EXT-X-MEDIA tag in HTTP Live Streaming [v4]

2024-05-09 Thread Ambarish Rapte
On Wed, 8 May 2024 22:02:21 GMT, Alexander Matveev wrote: >> - Added support for #EXT-X-MEDIA tag to HTTP Live Streaming. >> - Following audio renditions via #EXT-X-MEDIA tag will be supported (see CSR >> for more details): >> - MP2T streams with one H.264/AVC video track and elementary AAC au

Re: RFR: 8282999: Add support for EXT-X-MEDIA tag in HTTP Live Streaming [v4]

2024-05-09 Thread Kevin Rushforth
On Wed, 8 May 2024 22:02:21 GMT, Alexander Matveev wrote: >> - Added support for #EXT-X-MEDIA tag to HTTP Live Streaming. >> - Following audio renditions via #EXT-X-MEDIA tag will be supported (see CSR >> for more details): >> - MP2T streams with one H.264/AVC video track and elementary AAC au

Re: RFR: 8323511: Scrollbar Click jumps inconsistent amount of pixels [v4]

2024-05-09 Thread eduardsdv
On Thu, 9 May 2024 09:04:54 GMT, Johan Vos wrote: >> Florian Kirmaier has updated the pull request incrementally with one >> additional commit since the last revision: >> >> JDK-8323511: Use viewport length as block increment > > modules/javafx.controls/src/main/java/javafx/scene/control/skin

Re: RFR: 8323511: Scrollbar Click jumps inconsistent amount of pixels [v5]

2024-05-09 Thread Florian Kirmaier
> As seen in the unit test of the PR, when we click on the area above/below the > scrollbar the position jumps - but the jump is now not always consistent. > In the current version on the last cell - the UI always jumps to the top. In > the other cases, the assumed default cell height is used. >

Re: RFR: 8279140: ComboBox can lose selected value on item change via setAll [v2]

2024-05-09 Thread Karthik P K
> The `ComboBox` value was not set to previously selected value in the item > list change listener when `setAll` method is used to change the items. Fixed > the issue by restoring the selection in this case. > > Added a unit test to validate the fix. > [JDK-8279139](https://bugs.openjdk.org/brow

Re: RFR: 8323511: Scrollbar Click jumps inconsistent amount of pixels [v4]

2024-05-09 Thread Johan Vos
On Tue, 7 May 2024 09:39:23 GMT, Florian Kirmaier wrote: >> As seen in the unit test of the PR, when we click on the area above/below >> the scrollbar the position jumps - but the jump is now not always consistent. >> In the current version on the last cell - the UI always jumps to the top. In

Re: RFR: 8328603: HLS video stream fails to render consistently

2024-05-09 Thread Ambarish Rapte
On Sat, 13 Apr 2024 01:36:01 GMT, Alexander Matveev wrote: > - When video fails to render AVFoundation outputs frame in > `kCVPixelFormatType_420YpCbCr8BiPlanarVideoRange` format which is not > supported. We do force format change after that to > `kCVPixelFormatType_422YpCbCr8`, but AVFoundat