I've had a look into the proposal and I like it a lot.
I've had numerous encounters with "little tweaks" to keyboard handling
and/or behaviour that I had to work around, all of which would (as far
as I can tell) have been avoidable, if this API were in existence.
So while there is quite some
Since I see multiple discussions about the behaviour API and the RichTextControl, I want to ask another, still important question:
What is about the Skin cleanup ListenerHelper?
We now have 2 implementations of such utility - the
LambdaMultiplePropertyChangeListenerHandler
and the
Listen
I think this can still be implemented for cells without any special handling.
It is rather unexpected that a cell does not give the correct pref width, so we need to think about how to improve the current situation.
In my opinion, it should not be the concern of the Cell to give the actual width
On Fri, 8 Mar 2024 21:08:25 GMT, Andy Goryachev wrote:
>> Adds **Labeled.textTruncated** property which indicates when the text is
>> visually truncated (and the ellipsis string is inserted) in order to fit the
>> available width.
>>
>> The new property reacts to changes in the following prope
On Mon, 11 Mar 2024 17:25:26 GMT, John Hendrikx wrote:
>> John Hendrikx has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Move getStyleClassNames to location it was introduced to reduce diff
>
> I think its /csroff or something...
@hjohn
On Sat, 10 Feb 2024 17:24:17 GMT, John Hendrikx wrote:
>> There are a number of tickets open related to text rendering:
>>
>> https://bugs.openjdk.org/browse/JDK-8314215
>>
>> https://bugs.openjdk.org/browse/JDK-8145496
>>
>> https://bugs.openjdk.org/browse/JDK-8129014
>>
>> They have in comm
On Mon, 11 Mar 2024 16:54:25 GMT, John Hendrikx wrote:
>> Improves performance of selector matching in the CSS subsystem. This is done
>> by using custom set implementation which are highly optimized for the most
>> common cases where the number of selectors is small (most commonly 1 or 2).
>>
On Mon, 11 Mar 2024 16:54:25 GMT, John Hendrikx wrote:
>> Improves performance of selector matching in the CSS subsystem. This is done
>> by using custom set implementation which are highly optimized for the most
>> common cases where the number of selectors is small (most commonly 1 or 2).
>>
On Sat, 9 Mar 2024 06:08:34 GMT, John Hendrikx wrote:
>> modules/javafx.graphics/src/main/java/com/sun/javafx/css/FixedCapacitySet.java
>> line 96:
>>
>>> 94: : maximumCapacity == 2 ? new Duo<>()
>>> 95: : maximumCapacity < 10 ? new Hashless<>(maximumCapacity)
>>> //
On Mon, 11 Mar 2024 16:54:25 GMT, John Hendrikx wrote:
>> Improves performance of selector matching in the CSS subsystem. This is done
>> by using custom set implementation which are highly optimized for the most
>> common cases where the number of selectors is small (most commonly 1 or 2).
>>
On Mon, 11 Mar 2024 16:47:14 GMT, John Hendrikx wrote:
>> Improves performance of selector matching in the CSS subsystem. This is done
>> by using custom set implementation which are highly optimized for the most
>> common cases where the number of selectors is small (most commonly 1 or 2).
>>
> Improves performance of selector matching in the CSS subsystem. This is done
> by using custom set implementation which are highly optimized for the most
> common cases where the number of selectors is small (most commonly 1 or 2).
> It also should be more memory efficient for medium sized and
> Improves performance of selector matching in the CSS subsystem. This is done
> by using custom set implementation which are highly optimized for the most
> common cases where the number of selectors is small (most commonly 1 or 2).
> It also should be more memory efficient for medium sized and
On Mon, 11 Mar 2024 16:23:46 GMT, Andy Goryachev wrote:
>> I'd like someone else to weigh in on this. If this were a `Set` that
>> eventually would be publicly accessible somewhere (by normal FX users) I'd
>> definitely not want this. In this case however, it is (for now at least)
>> only used
On Sat, 9 Mar 2024 13:46:08 GMT, John Hendrikx wrote:
>> Improves performance of selector matching in the CSS subsystem. This is done
>> by using custom set implementation which are highly optimized for the most
>> common cases where the number of selectors is small (most commonly 1 or 2).
>>
On Sat, 9 Mar 2024 13:42:55 GMT, John Hendrikx wrote:
>> modules/javafx.graphics/src/main/java/javafx/css/StyleClass.java line 32:
>>
>>> 30: * @deprecated for removal
>>> 31: */
>>> 32: public final class StyleClass {
>>
>> Needs the `@Deprecated(forRemoval = true)` annotation on the class,
On Mon, 11 Mar 2024 16:01:13 GMT, John Hendrikx wrote:
>> But it is somewhat visible: **public** `void freeze();` (although it cannot
>> be invoked directly).
>>
>> Edit: While I accept your reasoning that the functionality is effectively
>> hidden from the user, I still think that the excepti
On Mon, 11 Mar 2024 14:54:45 GMT, Andy Goryachev wrote:
>> I'm not against adding an explanation, but it's not needed as this is part
>> of the `Set` contract (sets that can't be modified are specified to throw
>> `UnsupportedOperationException`), for example for `add` in `Set`:
>>
>> * @
On Sat, 9 Mar 2024 05:26:33 GMT, John Hendrikx wrote:
>> modules/javafx.graphics/src/main/java/com/sun/javafx/css/FixedCapacitySet.java
>> line 135:
>>
>>> 133: protected final void ensureNotFrozen() {
>>> 134: if (frozen) {
>>> 135: throw new UnsupportedOperationExcepti
On Mon, 5 Feb 2024 09:53:23 GMT, Marius Hanl wrote:
>> Florian Kirmaier has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> JDK-8323511
>> reverted accidental indentation chang
>
> modules/javafx.controls/src/main/java/javafx/scene/control
Dear JavaFX developers:
Thank you all for your feedback on my earlier Behavior/InputMap proposal [6],
[7]. There was some positive reaction to the idea of allowing for easy
customization of JavaFX controls behavior, as well as some push back. Some of
the objections were:
* desire for so
On Wed, 3 Jan 2024 01:14:13 GMT, John Hendrikx wrote:
> The regression is caused by the `Collections.unmodifiableSet` wrapper not
> being recognized by `BitSet`, and a fall back is done to a less optimized
> version of `containsAll`.
>
> As this is a regression fix, I've kept the fix as small
22 matches
Mail list logo
