Aw: Re: [External] : Re: Q: Labeled.textTruncated Property (RFE)

[Marius Hanl]

I think this can still be implemented for cells without any special handling.

It is rather unexpected that a cell does not give the correct pref width, so we need to think about how to improve the current situation.

In my opinion, it should not be the concern of the Cell to give the actual width of the column it belongs to, but the pref width, as we would expect.

We need to check where this is called.

 

-- Marius

 

 

Gesendet: Donnerstag, 07. März 2024 um 16:07 Uhr
Von: "Daniel Peintner" <daniel.peint...@gmail.com>
An: "Andy Goryachev" <andy.goryac...@oracle.com>
Cc: "openjfx-dev@openjdk.org" <openjfx-dev@openjdk.org>
Betreff: Re: [External] : Re: Q: Labeled.textTruncated Property (RFE)

Andy, all,

Some comments below:
 

1. Even if it is possible to do the same with public means I think it is useful. Anyhow we need to promote the solutions better (e.g., on StackOverflow)
    
2. I tried to achieve what you did in JavaFX core for my use-case, TableView cells.
   1. In my real application I tried and failed since the boolean condition in https://github.com/openjdk/jfx/blob/8a5cb17ed6525b0a218595865ead3e399e3b29dd/modules/javafx.controls/src/main/java/javafx/scene/control/Labeled.java#L838-L841 always reports false
   2. Hence I tried to create a short self-contained TableView example to explore it further, see Gist https://gist.github.com/danielpeintner/9b561eb57261e8c5bc608f1346df74cf
      It still fails :-(
   3. The Email field in the table ideally should report "true" once the text entered exceeds the visible view. Somehow it fails... getWidth() and  prefWidth(-1) always return the same double value. Please try the Gist above to confirm.
      e.g., edit cell and extend the email text to longer than column width --> results in System.out "Table-Email-Cell !isWrapText: 182.0 < 182.0 --> false"
   4. Hence I also added a *normal* MyLabel example which does work as intended

Maybe I miss something obvious but TableCells seem to be special Labeled instances and behave differently.

 

Thanks,

 

-- Daniel

 

[1] https://stackoverflow.com/a/52432862

 

 

On Wed, Mar 6, 2024 at 6:10 PM Andy Goryachev <andy.goryac...@oracle.com> wrote:

Dear Daniel:

 

Thank you for confirming the need for this enhancement.  Your case is covered by this ticket (I included a wrong ticket in my previous message by mistake, sorry):

 

JDK-8327483 TreeView: Allow for tooltip when cell text is truncated

 

My only concern is that this functionality theoretically can be achieved by the application code just as easy, since the solution does not use any internal APIs, as can be seen here: https://github.com/openjdk/jfx/pull/1389

 

-andy

 

 

From: Daniel Peintner <daniel.peint...@gmail.com>
Date: Tuesday, March 5, 2024 at 23:53
To: Andy Goryachev <andy.goryac...@oracle.com>
Cc: openjfx-dev@openjdk.org <openjfx-dev@openjdk.org>
Subject: [External] : Re: Q: Labeled.textTruncated Property (RFE)

Hi Andy, all,

 

Thank you for the effort which I very much appreciate.

We have a similar use-case as the one mentioned in JDK-8205211.

 

We would like to show a Tooltip with the corresponding text once the text is shown with ellipsis for a TableCell. The *hacky* solution we are using is sketched in [1] and requires us to calculate the width again. Moreover, once different fonts come into the game it becomes even more brittle.

 

Having an easy (easier?) way to detect and observe whether a label is truncated is of importance for us and definitely improves the usability of JavaFX.

 

Thanks,

 

-- Daniel

 

[1] https://stackoverflow.com/a/52432862

 

On Tue, Mar 5, 2024 at 10:15 PM Andy Goryachev <andy.goryac...@oracle.com> wrote:

Dear colleagues:

 

Do you think a new property, ReadOnlyBooleanProperty textTruncated, should be added to the Labeled control?

 

 

On one hand, we do have a couple of tickets in JBS requesting that:

 

• JDK-8091891 TreeView: There is no tooltip available on truncated node
• JDK-8205211 Ability to show Tooltip only when text is shown with ellipsis (...)

 

On the other hand, this functionality can in theory be implemented at the application level, although the number of changes required might be uncomfortably large in the case of Tree/TreeTable/TableView.

 

JBS:

• JDK-8092102 Labeled: truncated property

 

Pull Request: https://github.com/openjdk/jfx/pull/1389

 

What do you think?

 

-andy