On Mon, 8 Jan 2024 21:24:43 GMT, Kevin Rushforth wrote:
> Bump the version number of JavaFX to 23. I will integrate this to master as
> part of forking the jfx22 stabilization branch, which is scheduled for
> Thursday, January 11, 2024 at 16:00 UTC.
Marked as reviewed by arapte (Reviewer).
--
In the `getHitInfo()` method of PrismTextLayout, RTL node orientation
conditions were not considered, hence hit test values such as character index
and insertion index values were incorrect.
Added checks for RTL orientation of nodes and fixed the issue in
`getHitInfo()` to calculate correct hi
On Wed, 27 Dec 2023 00:01:10 GMT, Martin Fox wrote:
> The Mac screen coordinate system is inverted on the y-axis compared to JavaFX
> so glass needs to flip the y coordinate. IM coordinates are relative to the
> primary screen which is NSScreen.screens[0], not NSScreen.mainScreen
> (mainScreen
On Wed, 27 Dec 2023 00:01:10 GMT, Martin Fox wrote:
> The Mac screen coordinate system is inverted on the y-axis compared to JavaFX
> so glass needs to flip the y coordinate. IM coordinates are relative to the
> primary screen which is NSScreen.screens[0], not NSScreen.mainScreen
> (mainScreen
On Tue, 9 Jan 2024 00:23:23 GMT, Andy Goryachev wrote:
>> The Mac screen coordinate system is inverted on the y-axis compared to
>> JavaFX so glass needs to flip the y coordinate. IM coordinates are relative
>> to the primary screen which is NSScreen.screens[0], not NSScreen.mainScreen
>> (mai
On Tue, 9 Jan 2024 00:17:33 GMT, Andy Goryachev wrote:
>> The Mac screen coordinate system is inverted on the y-axis compared to
>> JavaFX so glass needs to flip the y coordinate. IM coordinates are relative
>> to the primary screen which is NSScreen.screens[0], not NSScreen.mainScreen
>> (mai
On Wed, 27 Dec 2023 00:01:10 GMT, Martin Fox wrote:
> The Mac screen coordinate system is inverted on the y-axis compared to JavaFX
> so glass needs to flip the y coordinate. IM coordinates are relative to the
> primary screen which is NSScreen.screens[0], not NSScreen.mainScreen
> (mainScreen
On Mon, 8 Jan 2024 21:24:43 GMT, Kevin Rushforth wrote:
> Bump the version number of JavaFX to 23. I will integrate this to master as
> part of forking the jfx22 stabilization branch, which is scheduled for
> Thursday, January 11, 2024 at 16:00 UTC.
looks good
-
Marked as reviewe
Bump the version number of JavaFX to 23. I will integrate this to master as
part of forking the jfx22 stabilization branch, which is scheduled for
Thursday, January 11, 2024 at 16:00 UTC.
-
Commit messages:
- 8323209: Change JavaFX release version to 23
Changes: https://git.openjd
On Mon, 8 Jan 2024 19:15:31 GMT, John Hendrikx wrote:
>> these lines discard about 4.5 bits of information on each step, surely that
>> will affect performance, no?
>
> I am confused, and maybe I am missing something. As far as I know, this
> method is not called anywhere. I put a breakpoint in
On Mon, 8 Jan 2024 16:22:42 GMT, Andy Goryachev wrote:
>> I agree that it is not nice :) However, changing this seems out of scope
>> for this PR as my changes are unrelated to this, and I didn't even touch
>> `CompoundSelector`. As selectors are never stored in sets/maps, it is hard
>> to j
On Fri, 5 Jan 2024 17:52:03 GMT, Florian Weimer wrote:
> 8323078: Incorrect length argument to g_utf8_strlen in pango.c
This pull request has now been integrated.
Changeset: 366b062c
Author:Florian Weimer
Committer: Kevin Rushforth
URL:
https://git.openjdk.org/jfx/commit/366b062c2f
On Mon, 8 Jan 2024 10:16:45 GMT, Florian Weimer wrote:
>> 8323078: Incorrect length argument to g_utf8_strlen in pango.c
>
> Florian Weimer has refreshed the contents of this pull request, and previous
> commits have been removed. The incremental views will show differences
> compared to the pr
On Fri, 5 Jan 2024 17:01:25 GMT, Florian Weimer wrote:
> 8323077: C type error (incompatible function pointer) in X11GLContext.c
This pull request has now been integrated.
Changeset: e3f2e968
Author:Florian Weimer
Committer: Kevin Rushforth
URL:
https://git.openjdk.org/jfx/commit/e
On Mon, 8 Jan 2024 17:15:39 GMT, Kevin Rushforth wrote:
> Thanks for addressing it as well. `glXGetProcAddress` is defined in
> `glxext.h`, which we include in our sources. See [glxext.h line
> 155](https://github.com/openjdk/jfx/blob/master/modules/javafx.graphics/src/main/native-prism-es2/GL/
On Mon, 8 Jan 2024 10:19:08 GMT, Florian Weimer wrote:
>> 8323077: C type error (incompatible function pointer) in X11GLContext.c
>
> Florian Weimer has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Suppress -Wpointer-sign warning
> I wanted
On Mon, 8 Jan 2024 16:19:05 GMT, John Hendrikx wrote:
>> modules/javafx.graphics/src/main/java/javafx/css/SimpleSelector.java line
>> 382:
>>
>>> 380: hash = 31 * (hash + name.hashCode());
>>> 381: hash = 31 * (hash + selectorStyleClassNames.hashCode());
>>> 382: hash =
On Mon, 8 Jan 2024 16:01:01 GMT, Andy Goryachev wrote:
>> John Hendrikx has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains eight additional
>> comm
On Fri, 5 Jan 2024 01:45:56 GMT, John Hendrikx wrote:
>> Improves performance of selector matching in the CSS subsystem. This is done
>> by using custom set implementation which are highly optimized for the most
>> common cases where the number of selectors is small (most commonly 1 or 2).
>>
> 8323077: C type error (incompatible function pointer) in X11GLContext.c
Florian Weimer has updated the pull request incrementally with one additional
commit since the last revision:
Suppress -Wpointer-sign warning
-
Changes:
- all: https://git.openjdk.org/jfx/pull/1319/files
On Fri, 5 Jan 2024 18:48:25 GMT, Kevin Rushforth wrote:
>> Florian Weimer has refreshed the contents of this pull request, and previous
>> commits have been removed. The incremental views will show differences
>> compared to the previous content of the PR. The pull request contains one
>> new
> 8323078: Incorrect length argument to g_utf8_strlen in pango.c
Florian Weimer has refreshed the contents of this pull request, and previous
commits have been removed. The incremental views will show differences compared
to the previous content of the PR. The pull request contains one new commi
On Sat, 6 Jan 2024 16:42:19 GMT, Kevin Rushforth wrote:
> Looks good. In looking at the logs from the GHA run I can see that the
> warning is gone.
>
> I note that there is an additional warning on that same line:
>
> ```
> 2024-01-05T23:04:38.0399339Z
> /home/runner/work/jfx/jfx/jfx/modules/
23 matches
Mail list logo
