On Thu, 4 Jan 2024 13:38:31 GMT, Nir Lisker wrote:
>> John Hendrikx has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains eight additional
>> commits
> Improves performance of selector matching in the CSS subsystem. This is done
> by using custom set implementation which are highly optimized for the most
> common cases where the number of selectors is small (most commonly 1 or 2).
> It also should be more memory efficient for medium sized and
On Thu, 4 Jan 2024 15:28:45 GMT, Michael Strauß wrote:
>> Improves performance of selector matching in the CSS subsystem. This is done
>> by using custom set implementation which are highly optimized for the most
>> common cases where the number of selectors is small (most commonly 1 or 2).
>>
> When reporting input method candidate position the code in
> GlassViewEventHandler is not applying the platform scale factors. This is
> causing incorrect IM positions to be reported to glass on hi-dpi monitors.
>
> This PR a no-op on Mac since the platform scale factors are always 1.0. I
> d
On Thu, 4 Jan 2024 14:23:14 GMT, Nir Lisker wrote:
>> Improves performance of selector matching in the CSS subsystem. This is done
>> by using custom set implementation which are highly optimized for the most
>> common cases where the number of selectors is small (most commonly 1 or 2).
>> It
In a new PR (https://github.com/openjdk/jfx/pull/1316) I've deprecated
two methods for removal.
SimpleSelector#getStyleClasses
SimpleSelector#getStyleClassSet
I think these are safe to remove because even though they are public,
and part of public API, the only way to reach them is
> When reporting input method candidate position the code in
> GlassViewEventHandler is not applying the platform scale factors. This is
> causing incorrect IM positions to be reported to glass on hi-dpi monitors.
>
> This PR a no-op on Mac since the platform scale factors are always 1.0. I
> d
On Thu, 4 Jan 2024 14:17:48 GMT, Nir Lisker wrote:
>> Improves performance of selector matching in the CSS subsystem. This is done
>> by using custom set implementation which are highly optimized for the most
>> common cases where the number of selectors is small (most commonly 1 or 2).
>> It
On Thu, 4 Jan 2024 13:57:16 GMT, Nir Lisker wrote:
>> Improves performance of selector matching in the CSS subsystem. This is done
>> by using custom set implementation which are highly optimized for the most
>> common cases where the number of selectors is small (most commonly 1 or 2).
>> It
On Thu, 4 Jan 2024 13:53:28 GMT, Nir Lisker wrote:
>> Improves performance of selector matching in the CSS subsystem. This is done
>> by using custom set implementation which are highly optimized for the most
>> common cases where the number of selectors is small (most commonly 1 or 2).
>> It
On Wed, 3 Jan 2024 01:14:13 GMT, John Hendrikx wrote:
> The regression is caused by the `Collections.unmodifiableSet` wrapper not
> being recognized by `BitSet`, and a fall back is done to a less optimized
> version of `containsAll`.
>
> As this is a regression fix, I've kept the fix as small
On Wed, 3 Jan 2024 01:14:13 GMT, John Hendrikx wrote:
> The regression is caused by the `Collections.unmodifiableSet` wrapper not
> being recognized by `BitSet`, and a fall back is done to a less optimized
> version of `containsAll`.
>
> As this is a regression fix, I've kept the fix as small
On Wed, 27 Dec 2023 00:01:10 GMT, Martin Fox wrote:
> The Mac screen coordinate system is inverted on the y-axis compared to JavaFX
> so glass needs to flip the y coordinate. IM coordinates are relative to the
> primary screen which is NSScreen.screens[0], not NSScreen.mainScreen
> (mainScreen
On Thu, 4 Jan 2024 17:47:42 GMT, Martin Fox wrote:
>> When reporting input method candidate position the code in
>> GlassViewEventHandler is not applying the platform scale factors. This is
>> causing incorrect IM positions to be reported to glass on hi-dpi monitors.
>>
>> This PR a no-op on M
I truly love the fact that you guys are starting to use JFXCentral for
benchmarking / testing :-) If anyone encounters things bad for performance
unrelated to JavaFX itself but caused by JFXCentral then please let me know.
Dirk
> Am 04.01.2024 um 13:31 schrieb John Hendrikx :
>
> Improves per
> When reporting input method candidate position the code in
> GlassViewEventHandler is not applying the platform scale factors. This is
> causing incorrect IM positions to be reported to glass on hi-dpi monitors.
>
> This PR a no-op on Mac since the platform scale factors are always 1.0. I
> d
On Thu, 4 Jan 2024 15:31:12 GMT, Ambarish Rapte wrote:
> Update the copyright year in files modified in year 2023.
This pull request has now been integrated.
Changeset: bad94a6c
Author:Ambarish Rapte
URL:
https://git.openjdk.org/jfx/commit/bad94a6c3551a2f299d387aec0ed597238a3c4f7
St
On Wed, 3 Jan 2024 18:39:58 GMT, Kevin Rushforth wrote:
> This PR updates the version of SWT that we use we use when building and
> testing the `javafx.swt` modules to 4.30.
>
> NOTE: we do not distribute SWT, but only use it during build and (manual)
> test.
>
> We currently use SWT 4.6. In
Update the copyright year in files modified in year 2023.
-
Commit messages:
- copyright year 2023
Changes: https://git.openjdk.org/jfx/pull/1317/files
Webrev: https://webrevs.openjdk.org/?repo=jfx&pr=1317&range=00
Issue: https://bugs.openjdk.org/browse/JDK-8322953
Stats: 27 li
On Thu, 4 Jan 2024 15:31:12 GMT, Ambarish Rapte wrote:
> Update the copyright year in files modified in year 2023.
+1
-
Marked as reviewed by kcr (Lead).
PR Review: https://git.openjdk.org/jfx/pull/1317#pullrequestreview-1804425189
On Thu, 4 Jan 2024 12:21:15 GMT, John Hendrikx wrote:
> Improves performance of selector matching in the CSS subsystem. This is done
> by using custom set implementation which are highly optimized for the most
> common cases where the number of selectors is small (most commonly 1 or 2).
> It a
On Thu, 4 Jan 2024 12:21:15 GMT, John Hendrikx wrote:
> Improves performance of selector matching in the CSS subsystem. This is done
> by using custom set implementation which are highly optimized for the most
> common cases where the number of selectors is small (most commonly 1 or 2).
> It a
On Thu, 4 Jan 2024 14:23:14 GMT, Nir Lisker wrote:
>> Improves performance of selector matching in the CSS subsystem. This is done
>> by using custom set implementation which are highly optimized for the most
>> common cases where the number of selectors is small (most commonly 1 or 2).
>> It
On Thu, 4 Jan 2024 12:21:15 GMT, John Hendrikx wrote:
> Improves performance of selector matching in the CSS subsystem. This is done
> by using custom set implementation which are highly optimized for the most
> common cases where the number of selectors is small (most commonly 1 or 2).
> It a
Improves performance of selector matching in the CSS subsystem. This is done by
using custom set implementation which are highly optimized for the most common
cases where the number of selectors is small (most commonly 1 or 2). It also
should be more memory efficient for medium sized and large a
25 matches
Mail list logo
