On Wed, 3 Jan 2024 01:14:13 GMT, John Hendrikx <jhendr...@openjdk.org> wrote:
> The regression is caused by the `Collections.unmodifiableSet` wrapper not > being recognized by `BitSet`, and a fall back is done to a less optimized > version of `containsAll`. > > As this is a regression fix, I've kept the fix as small as reasonable. I'll > provide a further optimized version as part of > https://bugs.openjdk.org/browse/JDK-8322964 which eliminates the need for > `BitSet` and `StyleClass` in the hot code paths which should result in a > further CSS performance improvement. > > I've tested this solution with the JFXCentral application locally and the > regression seems resolved. This pull request has now been integrated. Changeset: 1dff7a16 Author: John Hendrikx <jhendr...@openjdk.org> URL: https://git.openjdk.org/jfx/commit/1dff7a1618a945a9a10ad2168f78aad3658e91a9 Stats: 6 lines in 1 file changed: 2 ins; 0 del; 4 mod 8322795: CSS performance regression up to 10x Reviewed-by: mstrauss, kcr ------------- PR: https://git.openjdk.org/jfx/pull/1314