In my exploration of a potential Behavior API, I discovered this oddity
in how ToggleButtons work.
1. If you have a single ToggleButton that is not part of a ToggleGroup,
you can't navigate away from it with the arrow keys, only by using Tab
or Shift-Tab.
2. If you have that same single Togg
On Fri, 1 Dec 2023 19:03:23 GMT, Andy Goryachev wrote:
>> Adding missing styleable properties to ImageView:
>>
>>
>> -fx-preserve-ratio
>> -fx-smooth
>> -fx-fit-width
>> -fx-fit-height
>>
>>
>> Updated CSS Reference.
>
> Andy Goryachev has updated the pull request incrementally with one addit
On 02/12/2023 05:35, Nir Lisker wrote:
Lazy initialization in many places that IMHO is not needed
I noticed this for the first time in classes like Box, Sphere and
Cylinder. Their dimension properties are lazily initialized, but are
also initialized on construction, so I never understoo
John answered already to most of the points, but I want to give my own
insights as well.
> Even though the syntax is ugly, the current implementation of the static
> getClassCssMetaData() is *nearly perfect*, considering the lack of some
> kind of a 'lazy' keyword in java.
>
I don't buy Nir's arg
> Please read [this
> document](https://gist.github.com/mstr2/9f46f92c98d3c86aa6a0b4224a9a6548) for
> an introduction to the Platform Preferences API, and how it interacts with
> the proposed style theme and stage appearance features.
Michael Strauß has updated the pull request incrementally wi
On Thu, 30 Nov 2023 23:38:18 GMT, Kevin Rushforth wrote:
>> Michael Strauß has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> initialize field with NULL
>
> modules/javafx.graphics/src/main/native-glass/win/GlassApplication.cpp line
> 189:
On Thu, 30 Nov 2023 23:36:38 GMT, Kevin Rushforth wrote:
>> Michael Strauß has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> initialize field with NULL
>
> modules/javafx.graphics/src/main/native-glass/win/GlassApplication.cpp line
> 174:
On Sat, 2 Dec 2023 00:24:36 GMT, Michael Strauß wrote:
>> Please read [this
>> document](https://gist.github.com/mstr2/9f46f92c98d3c86aa6a0b4224a9a6548)
>> for an introduction to the Platform Preferences API, and how it interacts
>> with the proposed style theme and stage appearance features.
On Thu, 30 Nov 2023 22:54:02 GMT, Kevin Rushforth wrote:
>> Michael Strauß has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> initialize field with NULL
>
> modules/javafx.graphics/src/main/native-glass/gtk/PlatformSupport.cpp line 68:
>
>
On Fri, 1 Dec 2023 20:42:41 GMT, Jose Pereda wrote:
> Clean backport of 8320267: WebView crashes on macOS 11 with WebKit 616.1
> Reviewed-by: jbhaskar, jpereda
This pull request has now been integrated.
Changeset: a9a3f5c5
Author:Jose Pereda
URL:
https://git.openjdk.org/jfx17u/commi
On Wed, 22 Nov 2023 17:05:36 GMT, Ambarish Rapte wrote:
>> Currently we use the value of spinner as it's `UIA_NamePropertyId` when a11y
>> client application requests for it.
>> Ideally we should use the text set by `Node.setAccessibleText()` as the
>> `UIA_NamePropertyId`.
>> For other control
> Please read [this
> document](https://gist.github.com/mstr2/9f46f92c98d3c86aa6a0b4224a9a6548) for
> an introduction to the Platform Preferences API, and how it interacts with
> the proposed style theme and stage appearance features.
Michael Strauß has updated the pull request incrementally wi
On Fri, 1 Dec 2023 19:03:23 GMT, Andy Goryachev wrote:
>> Adding missing styleable properties to ImageView:
>>
>>
>> -fx-preserve-ratio
>> -fx-smooth
>> -fx-fit-width
>> -fx-fit-height
>>
>>
>> Updated CSS Reference.
>
> Andy Goryachev has updated the pull request incrementally with one addit
> Please read [this
> document](https://gist.github.com/mstr2/9f46f92c98d3c86aa6a0b4224a9a6548) for
> an introduction to the Platform Preferences API, and how it interacts with
> the proposed style theme and stage appearance features.
Michael Strauß has updated the pull request incrementally wi
Clean backport of 8320267: WebView crashes on macOS 11 with WebKit 616.1
Reviewed-by: jbhaskar, jpereda
-
Commit messages:
- 8320267: WebView crashes on macOS 11 with WebKit 616.1
Changes: https://git.openjdk.org/jfx17u/pull/168/files
Webrev: https://webrevs.openjdk.org/?repo=jfx17
I've updated the proof of concept PR, and it has a number of changes to
allow more reuse of the behaviors handlers and key bindings. This has
resulted in the Behavior installation process to become a bit more
complex, but the actual use and the API's are still relatively simple.
For example,
On Fri, 1 Dec 2023 19:12:15 GMT, Kevin Rushforth wrote:
> Once you update the CSR
updated already
-
PR Comment: https://git.openjdk.org/jfx/pull/1293#issuecomment-1836639634
On Fri, 1 Dec 2023 19:03:23 GMT, Andy Goryachev wrote:
>> Adding missing styleable properties to ImageView:
>>
>>
>> -fx-preserve-ratio
>> -fx-smooth
>> -fx-fit-width
>> -fx-fit-height
>>
>>
>> Updated CSS Reference.
>
> Andy Goryachev has updated the pull request incrementally with one addit
> Adding missing styleable properties to ImageView:
>
>
> -fx-preserve-ratio
> -fx-smooth
> -fx-fit-width
> -fx-fit-height
>
>
> Updated CSS Reference.
Andy Goryachev has updated the pull request incrementally with one additional
commit since the last revision:
list of
-
Chan
> Adding missing styleable properties to ImageView:
>
>
> -fx-preserve-ratio
> -fx-smooth
> -fx-fit-width
> -fx-fit-height
>
>
> Updated CSS Reference.
Andy Goryachev has updated the pull request incrementally with one additional
commit since the last revision:
class = default
---
On Fri, 1 Dec 2023 17:34:05 GMT, Kevin Rushforth wrote:
>> Andy Goryachev has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> save 8 bytes
>
> modules/javafx.graphics/src/main/docs/javafx/scene/doc-files/cssref.html line
> 1887:
>
>> 1885:
On Thu, 30 Nov 2023 19:03:38 GMT, Andy Goryachev wrote:
>> Adding missing styleable properties to ImageView:
>>
>>
>> -fx-preserve-ratio
>> -fx-smooth
>> -fx-fit-width
>> -fx-fit-height
>>
>>
>> Updated CSS Reference.
>
> Andy Goryachev has updated the pull request incrementally with one addi
On Fri, 1 Dec 2023 15:32:32 GMT, Andy Goryachev wrote:
>> I wouldn't do any of the above unless there is a very good reason (and I'm
>> not seeing one). Just use standard `List.of` as the last step (or use the
>> `Collections.unmodifableList` wrapper); you'll get the most optimized,
>> automa
On Fri, 1 Dec 2023 10:07:37 GMT, Ambarish Rapte wrote:
>> I agree with 2. and I also think that `TextureParameters` would be a better
>> name for this.
>>
>> This should also follow in below method names and such (ex.
>> `setTextureParameters()` instead of `setTextureData()`)
>
> These propert
On Fri, 1 Dec 2023 09:14:28 GMT, Ambarish Rapte wrote:
>> Nir Lisker has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Addressed review comments
>
> modules/javafx.graphics/src/main/native-prism-d3d/D3DContext.cc line 367:
>
>> 365: {
>>
On Tue, 21 Nov 2023 21:11:43 GMT, Nir Lisker wrote:
> Deprecating for removal `getDateFormat()` in `TimeStringConverter` and
> `DateStringConverter` after it was removed already in
> `DateTimeStringConverter`, and `getNumberFormat()` in `NumberStringConverter`
> (and subclasses).
Marked as re
On Fri, 1 Dec 2023 04:32:16 GMT, John Hendrikx wrote:
>> Good point, thanks!
>> This also applies to UnmodifiableArrayList.
>>
>> For completeness sake, I wanted to mention a few issues (not in scope for
>> this PR) that came out of the code review:
>>
>> - could use `UnmodifiableArrayList` bu
On Fri, 1 Dec 2023 14:28:43 GMT, Karthik P K wrote:
>> The change listener on caretPositionProperty() was not getting invoked on
>> replacing the content with same text as there was no change in caret
>> position. Since the textProperty invalidation sets the forward bias to true
>> by default,
> The change listener on caretPositionProperty() was not getting invoked on
> replacing the content with same text as there was no change in caret
> position. Since the textProperty invalidation sets the forward bias to true
> by default, incorrect caret position was calculated when the same te
On Thu, 30 Nov 2023 07:44:13 GMT, Karthik P K wrote:
>> Karthik P K has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Code review
>
> @andy-goryachev-oracle and @Maran23 please re-review when you get a chance.
> @karthikpandelu I think th
On Thu, 30 Nov 2023 17:47:40 GMT, Andy Goryachev wrote:
>> Karthik P K has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Code review
>
> modules/javafx.controls/src/main/java/javafx/scene/control/skin/TextFieldSkin.java
> line 248:
>
>>
On Thu, 30 Nov 2023 08:37:35 GMT, Hima Bindu Meda wrote:
>> Updated libxslt to v1.1.39. Verified build on all platforms.No issue seen.
>
> Hima Bindu Meda has updated the pull request incrementally with two
> additional commits since the last revision:
>
> - update license for libxslt
> - upd
On Fri, 1 Dec 2023 13:24:17 GMT, Kevin Rushforth wrote:
> Clean backport to jfx21u. This backport was already requested and approved in
> JBS.
This pull request has now been integrated.
Changeset: 18fef3f2
Author:Kevin Rushforth
URL:
https://git.openjdk.org/jfx21u/commit/18fef3f28d
Clean backport to jfx21u. This backport was already requested and approved in
JBS.
-
Commit messages:
- Backport b80ec391cbba72d84b4b862b3f1b8db2ff8eb6e2
Changes: https://git.openjdk.org/jfx21u/pull/37/files
Webrev: https://webrevs.openjdk.org/?repo=jfx21u&pr=37&range=00
Issue:
On Thu, 30 Nov 2023 01:38:13 GMT, Michael Strauß wrote:
>> Please read [this
>> document](https://gist.github.com/mstr2/9f46f92c98d3c86aa6a0b4224a9a6548)
>> for an introduction to the Platform Preferences API, and how it interacts
>> with the proposed style theme and stage appearance features.
A clean backport to jfx21u, to update copyright year in doc files.
-
Commit messages:
- update cpr-year in docs to 2024
Changes: https://git.openjdk.org/jfx21u/pull/36/files
Webrev: https://webrevs.openjdk.org/?repo=jfx21u&pr=36&range=00
Issue: https://bugs.openjdk.org/browse/JDK
On Fri, 10 Nov 2023 23:39:21 GMT, Nir Lisker wrote:
>> Moves the filter setting of the samplers from the device parameters
>> configuration to the use-site, allowing for dynamic changes in the sampler.
>> This PR does internal plumbing work only to bring it close to the ES2
>> pipeline. A foll
On Wed, 15 Nov 2023 11:39:30 GMT, Lukasz Kostyra wrote:
>> 1. Not when it will be promoted to public API. Adding record components
>> breaks backwards compatibility, so making this a record will not allow
>> adding more configuration later on. What might be possible is making it an
>> interfac
38 matches
Mail list logo
