On Thu, 30 Nov 2023 23:36:38 GMT, Kevin Rushforth <k...@openjdk.org> wrote:
>> Michael Strauß has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> initialize field with NULL
>
> modules/javafx.graphics/src/main/native-glass/win/GlassApplication.cpp line
> 174:
>
>> 172: lParam != NULL && wcscmp(LPCWSTR(lParam),
>> L"ImmersiveColorSet") == 0) &&
>> 173: m_platformSupport.updatePreferences(m_grefThis)) {
>> 174: return 0;
>
> Do we need to fall through in this case? We used to do so, which is why I'm
> asking.
I decided not to fall through because the documentation for
[WM_SETTINGCHANGE](https://learn.microsoft.com/en-us/windows/win32/winmsg/wm-settingchange)
says that applications should return zero if they process the message.
-------------
PR Review Comment: https://git.openjdk.org/jfx/pull/1014#discussion_r1412690588
