On Wed, 15 Nov 2023 22:00:13 GMT, Alexander Zuev wrote:
>> Create implementation for Slider and Stepper accessibility protocols.
>> Fix mapping.
>> Fix performAction parameter type in declaration.
>
> Alexander Zuev has updated the pull request incrementally with one additional
> commit since th
On Tue, 21 Nov 2023 20:03:31 GMT, Marius Hanl wrote:
>> When a nested column is dragged, the column drag header (blue) is positioned
>> wrong.
>> It appears at the very left of the table and not where the column is.
>>
>> ` in `TimeStringConverter` and
> `DateStringConverter` after it was removed already in
> `DateTimeStringConverter`, and `getNumberFormat()` in `NumberStringConverter`
> (and subclasses).
Marked as re
On Tue, 21 Nov 2023 16:32:26 GMT, Kevin Rushforth wrote:
>> Ambarish Rapte has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> add @since 22
>
> modules/javafx.controls/src/main/java/javafx/scene/control/Spinner.java line
> 851:
>
>> 849:
IMHO, FX should not be consuming keys when they do nothing. Navigation
keys are also always consumed (cursor keys + TAB), even when focus did
not change.
I think this is because of the auto consume flag being set on many key
bindings, while those bindings often have another condition in their
> Currently we use the value of spinner as it's `UIA_NamePropertyId` when a11y
> client application requests for it.
> Ideally we should use the text set by `Node.setAccessibleText()` as the
> `UIA_NamePropertyId`.
> For other controls such as Slider, ListView we use the text set by
> setAccessi
On Wed, 15 Nov 2023 13:00:54 GMT, Nir Lisker wrote:
>> You're right, there's no implicit conversion from scoped enums to integers.
>> While one could get very creative with C++, maybe just using an unscoped
>> enum is easier. You might want to prefix the constants with `MT_` or
>> something li
On Tue, 21 Nov 2023 20:03:31 GMT, Marius Hanl wrote:
>> When a nested column is dragged, the column drag header (blue) is positioned
>> wrong.
>> It appears at the very left of the table and not where the column is.
>>
>> ` in `TimeStringConverter` and
> `DateStringConverter` after it was removed already in
> `DateTimeStringConverter`, and `getNumberFormat()` in `NumberStringConverter`
> (and subclasses).
CSR is neede
On Tue, 21 Nov 2023 21:11:43 GMT, Nir Lisker wrote:
> Deprecating for removal `getDateFormat()` in `TimeStringConverter` and
> `DateStringConverter` after it was removed already in
> `DateTimeStringConverter`, and `getNumberFormat()` in `NumberStringConverter`
> (and subclasses).
Is the const
On Tue, 21 Nov 2023 21:11:43 GMT, Nir Lisker wrote:
> Deprecating for removal `getDateFormat()` in `TimeStringConverter` and
> `DateStringConverter` after it was removed already in
> `DateTimeStringConverter`, and `getNumberFormat()` in `NumberStringConverter`
> (and subclasses).
so the app d
On Tue, 21 Nov 2023 21:11:43 GMT, Nir Lisker wrote:
> Deprecating for removal `getDateFormat()` in `TimeStringConverter` and
> `DateStringConverter` after it was removed already in
> `DateTimeStringConverter`, and `getNumberFormat()` in `NumberStringConverter`
> (and subclasses).
No, they wou
On Tue, 21 Nov 2023 21:11:43 GMT, Nir Lisker wrote:
> Deprecating for removal `getDateFormat()` in `TimeStringConverter` and
> `DateStringConverter` after it was removed already in
> `DateTimeStringConverter`, and `getNumberFormat()` in `NumberStringConverter`
> (and subclasses).
The question
On Tue, 21 Nov 2023 21:11:43 GMT, Nir Lisker wrote:
> Deprecating for removal `getDateFormat()` in `TimeStringConverter` and
> `DateStringConverter` after it was removed already in
> `DateTimeStringConverter`, and `getNumberFormat()` in `NumberStringConverter`
> (and subclasses).
`DateTimeStr
On Tue, 21 Nov 2023 21:11:43 GMT, Nir Lisker wrote:
> Deprecating for removal `getDateFormat()` in `DateTimeStringConverter` and
> `DateTimeStringConverter` after it was removed already in
> `DateTimeStringConverter`, and `getNumberFormat()` in `NumberStringConverter`
> (and subclasses).
Sorr
On Tue, 21 Nov 2023 21:47:36 GMT, Andy Goryachev wrote:
> Are we going to make all these private at some point?
They are going to be made package-private so that they are not public API while
still can be read by subclasses. There's no "internal protected" visibility
that would be ideal here.
On Tue, 21 Nov 2023 21:11:43 GMT, Nir Lisker wrote:
> Deprecating for removal `getDateFormat()` in `DateTimeStringConverter` and
> `DateTimeStringConverter` after it was removed already in
> `DateTimeStringConverter`, and `getNumberFormat()` in `NumberStringConverter`
> (and subclasses).
Are
On Tue, 21 Nov 2023 20:03:31 GMT, Marius Hanl wrote:
>> When a nested column is dragged, the column drag header (blue) is positioned
>> wrong.
>> It appears at the very left of the table and not where the column is.
>>
>> ` in `DateTimeStringConverter` and
`DateTimeStringConverter` after it was removed already in
`DateTimeStringConverter`, and `getNumberFormat()` in `NumberStringConverter`
(and subclasses).
-
Commit messages:
- Deprecate protected methods
Ch
On Wed, 30 Aug 2023 14:21:48 GMT, Ambarish Rapte wrote:
>> Alexander Zuev has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Add commented out debug statements.
>
> I observed few warnings and behavioral differences.
> - Warnings:
> 1.
> m
On Fri, 17 Nov 2023 21:27:04 GMT, Alexander Matveev
wrote:
> - GStreamer updated to 1.22.6 and GLib updated to 2.78.1.
> - Tested on all platforms with all supported media streams.
> - GStreamer 1.22.6 requires GLib 2.62.0, but since we need to support older
> GLib versions on Linux following A
Created https://bugs.openjdk.org/browse/JDK-8320557
Feel free to add additional details.
-andy
From: openjfx-dev on behalf of Andy Goryachev
Date: Tuesday, November 21, 2023 at 12:39
To: Thiago Milczarek Sayão
Cc: openjfx-dev
Subject: Re: [External] : Re: ESC key binding on the Scene
So it
On Tue, 21 Nov 2023 20:00:56 GMT, Marius Hanl wrote:
>> good point.
>>
>> May I suggest to declare constants for column widths and column reordering
>> coordinates so the origin of these numbers becomes clear?
>> Also, we are comparing floating point numbers, so perhaps it's better
>> specify
So it might be a bug in TextInputControl/TextField/TextArea - they should not
consume events if there is nothing to cancel. I see there are more scenarios
like this, to be solved with the InputMap proposal currently being discussed.
I’ll create a separate bug.
Thank you!
-andy
From: Thiago
Backport 16169240667876633895b27464eb90033abb6166
Please review this backport of openjdk/jfx#1253 to JavaFX 21. Please give me a
day or two to test it again before starting your review.
-
Commit messages:
- Backport 16169240667876633895b27464eb90033abb6166
Changes: https://git.ope
Andy,
I think you're right about the formatter.
The idea was to let the key propagate if there's nothing to cancel.
For example:
If I want to cancel the edit, one ESC. The second ESC would propagate
because there's nothing to cancel.
Thank you for the reply.
Em ter., 21 de nov. de 2023 às 14
> When a nested column is dragged, the column drag header (blue) is positioned
> wrong.
> It appears at the very left of the table and not where the column is.
>
> 
>
> The fix is to calculate the bound
On Tue, 21 Nov 2023 17:28:26 GMT, Andy Goryachev wrote:
>> modules/javafx.controls/src/test/java/test/javafx/scene/control/skin/TableViewSkinTest.java
>> line 225:
>>
>>> 223: TableColumnHeaderShim.columnReordering(tableColumnHeader,
>>> bounds.getMinX() + 20, bounds.getMinY());
>>> 22
Most of it is the documentation, but there is also the need to find and
document any cases that could fail. My expectation is that those are
uninteresting corner cases.
The documentation for the property adapter classes indicates that its
use is for inter-operating between JavaFX properties an
On Mon, 20 Nov 2023 22:24:58 GMT, Marius Hanl wrote:
> When a nested column is dragged, the column drag header (blue) is positioned
> wrong.
> It appears at the very left of the table and not where the column is.
>
>  completely? Or perhaps you do want to let
TextField invoke cancelEdit() (see TextInputControlBeh
On Tue, 21 Nov 2023 13:42:05 GMT, Karthik P K wrote:
>> When a nested column is dragged, the column drag header (blue) is positioned
>> wrong.
>> It appears at the very left of the table and not where the column is.
>>
>> ` as the
> `UIA_NamePropertyId`.
> For other controls suc
This one looks OK to me as long as there are no dependencies on other
fixes. It's been in jfx22 for a couple months, and don't recall any
regressions.
Johan and Jose: you reviewed it, any concerns?
-- Kevin
On 11/21/2023 8:13 AM, Thiago Milczarek Sayão wrote:
Hi Kevin,
Some folks from the
Hi Kevin,
Some folks from the JabRef project asked to backport this:
https://github.com/openjdk/jfx/pull/1173
JabRef project issue:
https://github.com/JabRef/jabref/issues/5867
I don't know if it fits the backport rationale.
-- Thiago.
Em seg., 20 de nov. de 2023 às 21:59, Kevin Rushforth
On Mon, 20 Nov 2023 22:24:58 GMT, Marius Hanl wrote:
> When a nested column is dragged, the column drag header (blue) is positioned
> wrong.
> It appears at the very left of the table and not where the column is.
>
> 