On Sat, 5 Aug 2023 12:28:16 GMT, Thorsten Fischer wrote:
> Hi,
>
> I did open the bug report. Some notes to this PR:
>
> My colleagues and I are able to reproduce this bug regularly, even though it
> takes sometimes up to 3 or 4 weeks until the D3DERR_DEVICEHUNG error shows
> up. We are curre
Hi John,
I like that you clearly define the terms Control, Skin and Behavior,
as well as their roles within the control architecture.
However, I don't see how your proposal scales to non-trivial controls,
and I agree with Andy that the Button example doesn't help (because a
Button lacks substruct
On Thu, 2 Nov 2023 06:04:23 GMT, Prasanta Sadhukhan
wrote:
> A manual regression test for JFXPanel orientation fix in
> [JDK-8317836](https://bugs.openjdk.org/browse/JDK-8317836) is added
This pull request has now been integrated.
Changeset: 29f9c4d3
Author:Prasanta Sadhukhan
URL:
On Mon, 6 Nov 2023 06:06:35 GMT, Prasanta Sadhukhan
wrote:
>> A manual regression test for JFXPanel orientation fix in
>> [JDK-8317836](https://bugs.openjdk.org/browse/JDK-8317836) is added
>
> Prasanta Sadhukhan has updated the pull request incrementally with two
> additional commits since th
To clarify,
> some behaviors cannot be decoupled from the skin
Imagine a specific skin that has a Node that accepts a user input. A scroll
bar, a button, or a region with a some function. Unless this element is
proclaimed as must-have for any skin and codified via some new public API
(MySkin
Dear John:
Thank you again for submitting a separate KeyBinding proposal. Ignoring my
objection for its sibling, I just wanted to point to these two items in Goals
and Non-Goals:
* Keep internal details of InputMap implementation hidden (it is too
complex, and consumes far too much resou
On Mon, 6 Nov 2023 19:30:28 GMT, Kevin Rushforth wrote:
> Can you file an enhancement to consider this for the next test sprint?
Created [JDK-8319555](https://bugs.openjdk.org/browse/JDK-8319555)
-
PR Comment: https://git.openjdk.org/jfx/pull/1276#issuecomment-1796178835
Dear John:
Thank you for providing these proposals!
Do I understand correctly that the idea of translating input events into
control-specific events and bubbling them up is now gone?
In “Goals” -
* Allow changing the skin of a control without having to recreate behavior
As we discussed b
On Mon, 6 Nov 2023 18:43:48 GMT, Andy Goryachev wrote:
> I was waiting for changes to set the window position, but can re-approve if
> necessary.
His earlier comments suggested that he felt it wasn't needed for this PR; with
the adjusted window sizes, the windows no longer overlap.
> A side c
On Mon, 6 Nov 2023 13:20:32 GMT, Kevin Rushforth wrote:
> > > Is it possible to add an automated regression test?
> >
> >
> > I'm working on that, but it is not trivial as this functionality requires
> > the QuantumToolkit and can not use the StubToolkit which is used in most
> > tests.
>
>
> When the Java layer removes a systemmenu, release the native resources
> related to this systemmenu.
> This removes the strong JNI Global ref, which prevents its references from
> being gc'ed.
>
> The current implementation for the mac-specific system menu creates a menu,
> but never releases
On Mon, 6 Nov 2023 06:06:35 GMT, Prasanta Sadhukhan
wrote:
>> A manual regression test for JFXPanel orientation fix in
>> [JDK-8317836](https://bugs.openjdk.org/browse/JDK-8317836) is added
>
> Prasanta Sadhukhan has updated the pull request incrementally with two
> additional commits since th
On Mon, 6 Nov 2023 17:53:42 GMT, Ambarish Rapte wrote:
>> @arapte anything else I could do?
>
> @vlaaad
> Yes please, I think we should have a test along with this fix. A test is
> missing for this scenario.
> If a unit test is not feasible, can you please check to add a system test ? (
> may
> When the Java layer removes a systemmenu, release the native resources
> related to this systemmenu.
> This removes the strong JNI Global ref, which prevents its references from
> being gc'ed.
>
> The current implementation for the mac-specific system menu creates a menu,
> but never releases
> When the Java layer removes a systemmenu, release the native resources
> related to this systemmenu.
> This removes the strong JNI Global ref, which prevents its references from
> being gc'ed.
>
> The current implementation for the mac-specific system menu creates a menu,
> but never releases
On Sat, 4 Nov 2023 14:11:46 GMT, Kevin Rushforth wrote:
>> Johan Vos has updated the pull request with a new target base due to a merge
>> or a rebase. The incremental webrev excludes the unrelated changes brought
>> in by the merge/rebase. The pull request contains three additional commits
>>
On Mon, 6 Nov 2023 08:31:54 GMT, vlaaad wrote:
>> When a function key is pressed
>> [NSFunctionKeyMask](https://developer.apple.com/documentation/appkit/nsfunctionkeymask)
>> is automatically included by the system.
>> Hence it looks not breaking behavior with this change.
>> As the warning is
On Mon, 6 Nov 2023 06:06:35 GMT, Prasanta Sadhukhan
wrote:
>> A manual regression test for JFXPanel orientation fix in
>> [JDK-8317836](https://bugs.openjdk.org/browse/JDK-8317836) is added
>
> Prasanta Sadhukhan has updated the pull request incrementally with two
> additional commits since th
On Mon, 6 Nov 2023 06:06:55 GMT, Prasanta Sadhukhan
wrote:
> Is there any in-house or public fx documentation that I can peruse (guess we
> dont have similar to
> https://docs.oracle.com/en/java/javase/21/docs/api/index.html)
Andy already answered your specific question. As for where the docs
On Mon, 6 Nov 2023 06:06:55 GMT, Prasanta Sadhukhan
wrote:
> can you please specify how to do it for my future reference as I dont see
> Scene accepting x,y params
Use Stage (Window) setX(), setY() before show().
-
PR Comment: https://git.openjdk.org/jfx/pull/1276#issuecomment-1
On Mon, 6 Nov 2023 12:34:41 GMT, Johan Vos wrote:
> > Is it possible to add an automated regression test?
>
> I'm working on that, but it is not trivial as this functionality requires the
> QuantumToolkit and can not use the StubToolkit which is used in most tests.
You could add a headful syst
On Thu, 2 Nov 2023 12:17:57 GMT, Kevin Rushforth wrote:
> Is it possible to add an automated regression test?
I'm working on that, but it is not trivial as this functionality requires the
QuantumToolkit and can not use the StubToolkit which is used in most tests.
-
PR Comment: htt
On Thu, 2 Nov 2023 11:43:06 GMT, Ambarish Rapte wrote:
>> vlaaad has updated the pull request incrementally with one additional commit
>> since the last revision:
>>
>> Don't use NSFunctionKeyMask as modifier at all
>
> When a function key is pressed
> [NSFunctionKeyMask](https://developer.a
23 matches
Mail list logo
